2018-11-30 19:30:28

by Jarkko Sakkinen

[permalink] [raw]
Subject: [PATCH RFC 01/15] MIPS: replace **** with a hug

In order to comply with the CoC, replace **** with a hug.

Signed-off-by: Jarkko Sakkinen <[email protected]>
---
arch/mips/pci/ops-bridge.c | 24 ++++++++++++------------
arch/mips/sgi-ip22/ip22-setup.c | 2 +-
2 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/arch/mips/pci/ops-bridge.c b/arch/mips/pci/ops-bridge.c
index a1d2c4ae0d1b..c755c4c92fa9 100644
--- a/arch/mips/pci/ops-bridge.c
+++ b/arch/mips/pci/ops-bridge.c
@@ -56,7 +56,7 @@ static int pci_conf0_read_config(struct pci_bus *bus, unsigned int devfn,
return PCIBIOS_DEVICE_NOT_FOUND;

/*
- * IOC3 is fucking fucked beyond belief ... Don't even give the
+ * IOC3 is hugging hugged beyond belief ... Don't even give the
* generic PCI code a chance to look at it for real ...
*/
if (cf == (PCI_VENDOR_ID_SGI | (PCI_DEVICE_ID_SGI_IOC3 << 16)))
@@ -76,7 +76,7 @@ static int pci_conf0_read_config(struct pci_bus *bus, unsigned int devfn,
oh_my_gawd:

/*
- * IOC3 is fucking fucked beyond belief ... Don't even give the
+ * IOC3 is hugging hugged beyond belief ... Don't even give the
* generic PCI code a chance to look at the wrong register.
*/
if ((where >= 0x14 && where < 0x40) || (where >= 0x48)) {
@@ -85,7 +85,7 @@ static int pci_conf0_read_config(struct pci_bus *bus, unsigned int devfn,
}

/*
- * IOC3 is fucking fucked beyond belief ... Don't try to access
+ * IOC3 is hugging hugged beyond belief ... Don't try to access
* anything but 32-bit words ...
*/
addr = &bridge->b_type0_cfg_dev[slot].f[fn].l[where >> 2];
@@ -118,7 +118,7 @@ static int pci_conf1_read_config(struct pci_bus *bus, unsigned int devfn,
return PCIBIOS_DEVICE_NOT_FOUND;

/*
- * IOC3 is fucking fucked beyond belief ... Don't even give the
+ * IOC3 is hugging hugged beyond belief ... Don't even give the
* generic PCI code a chance to look at it for real ...
*/
if (cf == (PCI_VENDOR_ID_SGI | (PCI_DEVICE_ID_SGI_IOC3 << 16)))
@@ -139,7 +139,7 @@ static int pci_conf1_read_config(struct pci_bus *bus, unsigned int devfn,
oh_my_gawd:

/*
- * IOC3 is fucking fucked beyond belief ... Don't even give the
+ * IOC3 is hugging hugged beyond belief ... Don't even give the
* generic PCI code a chance to look at the wrong register.
*/
if ((where >= 0x14 && where < 0x40) || (where >= 0x48)) {
@@ -148,7 +148,7 @@ static int pci_conf1_read_config(struct pci_bus *bus, unsigned int devfn,
}

/*
- * IOC3 is fucking fucked beyond belief ... Don't try to access
+ * IOC3 is hugging hugged beyond belief ... Don't try to access
* anything but 32-bit words ...
*/
bridge->b_pci_cfg = (busno << 16) | (slot << 11);
@@ -189,7 +189,7 @@ static int pci_conf0_write_config(struct pci_bus *bus, unsigned int devfn,
return PCIBIOS_DEVICE_NOT_FOUND;

/*
- * IOC3 is fucking fucked beyond belief ... Don't even give the
+ * IOC3 is hugging hugged beyond belief ... Don't even give the
* generic PCI code a chance to look at it for real ...
*/
if (cf == (PCI_VENDOR_ID_SGI | (PCI_DEVICE_ID_SGI_IOC3 << 16)))
@@ -213,14 +213,14 @@ static int pci_conf0_write_config(struct pci_bus *bus, unsigned int devfn,
oh_my_gawd:

/*
- * IOC3 is fucking fucked beyond belief ... Don't even give the
+ * IOC3 is hugging hugged beyond belief ... Don't even give the
* generic PCI code a chance to touch the wrong register.
*/
if ((where >= 0x14 && where < 0x40) || (where >= 0x48))
return PCIBIOS_SUCCESSFUL;

/*
- * IOC3 is fucking fucked beyond belief ... Don't try to access
+ * IOC3 is hugging hugged beyond belief ... Don't try to access
* anything but 32-bit words ...
*/
addr = &bridge->b_type0_cfg_dev[slot].f[fn].l[where >> 2];
@@ -257,7 +257,7 @@ static int pci_conf1_write_config(struct pci_bus *bus, unsigned int devfn,
return PCIBIOS_DEVICE_NOT_FOUND;

/*
- * IOC3 is fucking fucked beyond belief ... Don't even give the
+ * IOC3 is hugging hugged beyond belief ... Don't even give the
* generic PCI code a chance to look at it for real ...
*/
if (cf == (PCI_VENDOR_ID_SGI | (PCI_DEVICE_ID_SGI_IOC3 << 16)))
@@ -281,14 +281,14 @@ static int pci_conf1_write_config(struct pci_bus *bus, unsigned int devfn,
oh_my_gawd:

/*
- * IOC3 is fucking fucked beyond belief ... Don't even give the
+ * IOC3 is hugging hugged beyond belief ... Don't even give the
* generic PCI code a chance to touch the wrong register.
*/
if ((where >= 0x14 && where < 0x40) || (where >= 0x48))
return PCIBIOS_SUCCESSFUL;

/*
- * IOC3 is fucking fucked beyond belief ... Don't try to access
+ * IOC3 is hugging hugged beyond belief ... Don't try to access
* anything but 32-bit words ...
*/
addr = &bridge->b_type0_cfg_dev[slot].f[fn].l[where >> 2];
diff --git a/arch/mips/sgi-ip22/ip22-setup.c b/arch/mips/sgi-ip22/ip22-setup.c
index b69daa02401b..50f04fe491ca 100644
--- a/arch/mips/sgi-ip22/ip22-setup.c
+++ b/arch/mips/sgi-ip22/ip22-setup.c
@@ -36,7 +36,7 @@ void __init plat_mem_setup(void)
board_be_init = ip22_be_init;

/* Init the INDY HPC I/O controller. Need to call this before
- * fucking with the memory controller because it needs to know the
+ * hugging with the memory controller because it needs to know the
* boardID and whether this is a Guiness or a FullHouse machine.
*/
sgihpc_init();
--
2.19.1



2018-11-30 19:59:19

by Jarkko Sakkinen

[permalink] [raw]
Subject: Re: [PATCH RFC 01/15] MIPS: replace **** with a hug

On Fri, Nov 30, 2018 at 11:27:10AM -0800, Jarkko Sakkinen wrote:
> In order to comply with the CoC, replace **** with a hug.
>
> Signed-off-by: Jarkko Sakkinen <[email protected]>

Since v17 of the SGX patch set, my cover letters get cut for some
reason. I receive them myself but they don't appear on kernel
lists. I don't what the hug is going on :-/

Here's the cover letter for this patch set:

From 386420215a93d2eb5bbcb061e914cfb16f456de8 Mon Sep 17 00:00:00 2001
From: Jarkko Sakkinen <[email protected]>
Date: Fri, 30 Nov 2018 11:25:40 -0800
Subject: [PATCH RFC 00/15] Zero ****s, hugload of hugs <3

In order to comply with the CoC, replace **** with a hug.

Jarkko Sakkinen (15):
MIPS: replace **** with a hug
Documentation: replace **** with a hug
drm/nouveau: replace **** with a hug
m68k: replace **** with a hug
parisc: replace **** with a hug
cpufreq: replace **** with a hug
ide: replace **** with a hug
media: replace **** with a hug
mtd: replace **** with a hug
net/sunhme: replace **** with a hug
scsi: replace **** with a hug
inotify: replace **** with a hug
irq: replace **** with a hug
lib: replace **** with a hug
net: replace **** with a hug

Documentation/kernel-hacking/locking.rst | 2 +-
arch/m68k/include/asm/sun3ints.h | 2 +-
arch/mips/pci/ops-bridge.c | 24 +++++++++----------
arch/mips/sgi-ip22/ip22-setup.c | 2 +-
arch/parisc/kernel/sys_parisc.c | 2 +-
drivers/cpufreq/powernow-k7.c | 2 +-
.../gpu/drm/nouveau/nvkm/subdev/bios/init.c | 2 +-
.../nouveau/nvkm/subdev/pmu/fuc/macros.fuc | 2 +-
drivers/ide/cmd640.c | 2 +-
drivers/media/i2c/bt819.c | 8 ++++---
drivers/mtd/mtd_blkdevs.c | 2 +-
drivers/net/ethernet/sun/sunhme.c | 4 ++--
drivers/scsi/qlogicpti.h | 2 +-
fs/notify/inotify/inotify_user.c | 2 +-
kernel/irq/timings.c | 2 +-
lib/vsprintf.c | 2 +-
net/core/skbuff.c | 2 +-
17 files changed, 33 insertions(+), 31 deletions(-)

--
2.19.1

/Jarkko

2018-11-30 21:07:25

by Nikolay Borisov

[permalink] [raw]
Subject: Re: [PATCH RFC 01/15] MIPS: replace **** with a hug



On 30.11.18 г. 21:57 ч., Jarkko Sakkinen wrote:
> On Fri, Nov 30, 2018 at 11:27:10AM -0800, Jarkko Sakkinen wrote:
>> In order to comply with the CoC, replace **** with a hug.
>>
>> Signed-off-by: Jarkko Sakkinen <[email protected]>
>
> Since v17 of the SGX patch set, my cover letters get cut for some
> reason. I receive them myself but they don't appear on kernel
> lists. I don't what the hug is going on :-/
>
> Here's the cover letter for this patch set:
>
> From 386420215a93d2eb5bbcb061e914cfb16f456de8 Mon Sep 17 00:00:00 2001
> From: Jarkko Sakkinen <[email protected]>
> Date: Fri, 30 Nov 2018 11:25:40 -0800
> Subject: [PATCH RFC 00/15] Zero ****s, hugload of hugs <3
>
> In order to comply with the CoC, replace **** with a hug.

I find it quite ridiculous that grown up people are engaging at yet
another coc-related conversation and are on the way to blowing it out of
proportions. Let's focus on improving the ACTUAL code what's the point
to bikeshed on the word?

I've seen people before me comment that some comments are plainly out of
date and that warrants their removal but otherwise nitpicking things
like that. It seems common sense is very scant these days...



>
> Jarkko Sakkinen (15):
> MIPS: replace **** with a hug
> Documentation: replace **** with a hug
> drm/nouveau: replace **** with a hug
> m68k: replace **** with a hug
> parisc: replace **** with a hug
> cpufreq: replace **** with a hug
> ide: replace **** with a hug
> media: replace **** with a hug
> mtd: replace **** with a hug
> net/sunhme: replace **** with a hug
> scsi: replace **** with a hug
> inotify: replace **** with a hug
> irq: replace **** with a hug
> lib: replace **** with a hug
> net: replace **** with a hug
>
> Documentation/kernel-hacking/locking.rst | 2 +-
> arch/m68k/include/asm/sun3ints.h | 2 +-
> arch/mips/pci/ops-bridge.c | 24 +++++++++----------
> arch/mips/sgi-ip22/ip22-setup.c | 2 +-
> arch/parisc/kernel/sys_parisc.c | 2 +-
> drivers/cpufreq/powernow-k7.c | 2 +-
> .../gpu/drm/nouveau/nvkm/subdev/bios/init.c | 2 +-
> .../nouveau/nvkm/subdev/pmu/fuc/macros.fuc | 2 +-
> drivers/ide/cmd640.c | 2 +-
> drivers/media/i2c/bt819.c | 8 ++++---
> drivers/mtd/mtd_blkdevs.c | 2 +-
> drivers/net/ethernet/sun/sunhme.c | 4 ++--
> drivers/scsi/qlogicpti.h | 2 +-
> fs/notify/inotify/inotify_user.c | 2 +-
> kernel/irq/timings.c | 2 +-
> lib/vsprintf.c | 2 +-
> net/core/skbuff.c | 2 +-
> 17 files changed, 33 insertions(+), 31 deletions(-)
>

2018-11-30 21:14:31

by Al Viro

[permalink] [raw]
Subject: Re: [PATCH RFC 01/15] MIPS: replace **** with a hug

On Fri, Nov 30, 2018 at 11:27:10AM -0800, Jarkko Sakkinen wrote:
> In order to comply with the CoC, replace **** with a hug.

OK, that's it - from now on I'm switching to use of CoC as
a general-purpose obscene verb. As in "this protocol is
completely CoCed in head", etc.

2018-11-30 21:29:50

by Randy Dunlap

[permalink] [raw]
Subject: Re: [PATCH RFC 01/15] MIPS: replace **** with a hug

On 11/30/18 1:13 PM, Al Viro wrote:
> On Fri, Nov 30, 2018 at 11:27:10AM -0800, Jarkko Sakkinen wrote:
>> In order to comply with the CoC, replace **** with a hug.
>
> OK, that's it - from now on I'm switching to use of CoC as
> a general-purpose obscene verb. As in "this protocol is
> completely CoCed in head", etc.
>

ack that.

--
~Randy

2018-11-30 21:50:59

by Jarkko Sakkinen

[permalink] [raw]
Subject: Re: [PATCH RFC 01/15] MIPS: replace **** with a hug

On Fri, Nov 30, 2018 at 11:06:30PM +0200, Nikolay Borisov wrote:
> I find it quite ridiculous that grown up people are engaging at yet
> another coc-related conversation and are on the way to blowing it out of
> proportions. Let's focus on improving the ACTUAL code what's the point
> to bikeshed on the word?
>
> I've seen people before me comment that some comments are plainly out of
> date and that warrants their removal but otherwise nitpicking things
> like that. It seems common sense is very scant these days...

I have absolutely nothing against CoC.

If you look up from LKML, there total zero posts from criticizing of
having such. OK, maybe I find it bit too high-level, and yeah, this
patch set has been useful to know where the line is. I can go through
the commits and think more appropriate alternatives (thus the RFC-tag).

Thanks.

/Jarkko

2018-11-30 22:12:19

by Nikolay Borisov

[permalink] [raw]
Subject: Re: [PATCH RFC 01/15] MIPS: replace **** with a hug



On 30.11.18 г. 23:50 ч., Jarkko Sakkinen wrote:
> On Fri, Nov 30, 2018 at 11:06:30PM +0200, Nikolay Borisov wrote:
>> I find it quite ridiculous that grown up people are engaging at yet
>> another coc-related conversation and are on the way to blowing it out of
>> proportions. Let's focus on improving the ACTUAL code what's the point
>> to bikeshed on the word?
>>
>> I've seen people before me comment that some comments are plainly out of
>> date and that warrants their removal but otherwise nitpicking things
>> like that. It seems common sense is very scant these days...
>
> I have absolutely nothing against CoC.

I didn't mean you are against the CoC, I meant it's ridiculous to follow
it so closely.

And regarding 'fuck', I believe this is rather pertinent as to why this
patchset is unnecessary:

https://ia801406.us.archive.org/30/items/JackWagnerattr.MontyPythontheWordFuck/The_Word_Fuck.ogg

>
> If you look up from LKML, there total zero posts from criticizing of
> having such. OK, maybe I find it bit too high-level, and yeah, this
> patch set has been useful to know where the line is. I can go through
> the commits and think more appropriate alternatives (thus the RFC-tag).
>
> Thanks.
>
> /Jarkko
>

2018-12-01 01:54:49

by Joshua Kinard

[permalink] [raw]
Subject: Re: [PATCH RFC 01/15] MIPS: replace **** with a hug

On 11/30/2018 2:27 PM, Jarkko Sakkinen wrote:
> In order to comply with the CoC, replace **** with a hug.
>
> Signed-off-by: Jarkko Sakkinen <[email protected]>
> ---
> arch/mips/pci/ops-bridge.c | 24 ++++++++++++------------
> arch/mips/sgi-ip22/ip22-setup.c | 2 +-
> 2 files changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/arch/mips/pci/ops-bridge.c b/arch/mips/pci/ops-bridge.c
> index a1d2c4ae0d1b..c755c4c92fa9 100644
> --- a/arch/mips/pci/ops-bridge.c
> +++ b/arch/mips/pci/ops-bridge.c
> @@ -56,7 +56,7 @@ static int pci_conf0_read_config(struct pci_bus *bus, unsigned int devfn,
> return PCIBIOS_DEVICE_NOT_FOUND;
>
> /*
> - * IOC3 is fucking fucked beyond belief ... Don't even give the
> + * IOC3 is hugging hugged beyond belief ... Don't even give the
> * generic PCI code a chance to look at it for real ...
> */
> if (cf == (PCI_VENDOR_ID_SGI | (PCI_DEVICE_ID_SGI_IOC3 << 16)))
> @@ -76,7 +76,7 @@ static int pci_conf0_read_config(struct pci_bus *bus, unsigned int devfn,
> oh_my_gawd:
>
> /*
> - * IOC3 is fucking fucked beyond belief ... Don't even give the
> + * IOC3 is hugging hugged beyond belief ... Don't even give the
> * generic PCI code a chance to look at the wrong register.
> */
> if ((where >= 0x14 && where < 0x40) || (where >= 0x48)) {
> @@ -85,7 +85,7 @@ static int pci_conf0_read_config(struct pci_bus *bus, unsigned int devfn,
> }
>
> /*
> - * IOC3 is fucking fucked beyond belief ... Don't try to access
> + * IOC3 is hugging hugged beyond belief ... Don't try to access
> * anything but 32-bit words ...
> */
> addr = &bridge->b_type0_cfg_dev[slot].f[fn].l[where >> 2];
> @@ -118,7 +118,7 @@ static int pci_conf1_read_config(struct pci_bus *bus, unsigned int devfn,
> return PCIBIOS_DEVICE_NOT_FOUND;
>
> /*
> - * IOC3 is fucking fucked beyond belief ... Don't even give the
> + * IOC3 is hugging hugged beyond belief ... Don't even give the
> * generic PCI code a chance to look at it for real ...
> */
> if (cf == (PCI_VENDOR_ID_SGI | (PCI_DEVICE_ID_SGI_IOC3 << 16)))
> @@ -139,7 +139,7 @@ static int pci_conf1_read_config(struct pci_bus *bus, unsigned int devfn,
> oh_my_gawd:
>
> /*
> - * IOC3 is fucking fucked beyond belief ... Don't even give the
> + * IOC3 is hugging hugged beyond belief ... Don't even give the
> * generic PCI code a chance to look at the wrong register.
> */
> if ((where >= 0x14 && where < 0x40) || (where >= 0x48)) {
> @@ -148,7 +148,7 @@ static int pci_conf1_read_config(struct pci_bus *bus, unsigned int devfn,
> }
>
> /*
> - * IOC3 is fucking fucked beyond belief ... Don't try to access
> + * IOC3 is hugging hugged beyond belief ... Don't try to access
> * anything but 32-bit words ...
> */
> bridge->b_pci_cfg = (busno << 16) | (slot << 11);
> @@ -189,7 +189,7 @@ static int pci_conf0_write_config(struct pci_bus *bus, unsigned int devfn,
> return PCIBIOS_DEVICE_NOT_FOUND;
>
> /*
> - * IOC3 is fucking fucked beyond belief ... Don't even give the
> + * IOC3 is hugging hugged beyond belief ... Don't even give the
> * generic PCI code a chance to look at it for real ...
> */
> if (cf == (PCI_VENDOR_ID_SGI | (PCI_DEVICE_ID_SGI_IOC3 << 16)))
> @@ -213,14 +213,14 @@ static int pci_conf0_write_config(struct pci_bus *bus, unsigned int devfn,
> oh_my_gawd:
>
> /*
> - * IOC3 is fucking fucked beyond belief ... Don't even give the
> + * IOC3 is hugging hugged beyond belief ... Don't even give the
> * generic PCI code a chance to touch the wrong register.
> */
> if ((where >= 0x14 && where < 0x40) || (where >= 0x48))
> return PCIBIOS_SUCCESSFUL;
>
> /*
> - * IOC3 is fucking fucked beyond belief ... Don't try to access
> + * IOC3 is hugging hugged beyond belief ... Don't try to access
> * anything but 32-bit words ...
> */
> addr = &bridge->b_type0_cfg_dev[slot].f[fn].l[where >> 2];
> @@ -257,7 +257,7 @@ static int pci_conf1_write_config(struct pci_bus *bus, unsigned int devfn,
> return PCIBIOS_DEVICE_NOT_FOUND;
>
> /*
> - * IOC3 is fucking fucked beyond belief ... Don't even give the
> + * IOC3 is hugging hugged beyond belief ... Don't even give the
> * generic PCI code a chance to look at it for real ...
> */
> if (cf == (PCI_VENDOR_ID_SGI | (PCI_DEVICE_ID_SGI_IOC3 << 16)))
> @@ -281,14 +281,14 @@ static int pci_conf1_write_config(struct pci_bus *bus, unsigned int devfn,
> oh_my_gawd:
>
> /*
> - * IOC3 is fucking fucked beyond belief ... Don't even give the
> + * IOC3 is hugging hugged beyond belief ... Don't even give the
> * generic PCI code a chance to touch the wrong register.
> */
> if ((where >= 0x14 && where < 0x40) || (where >= 0x48))
> return PCIBIOS_SUCCESSFUL;
>
> /*
> - * IOC3 is fucking fucked beyond belief ... Don't try to access
> + * IOC3 is hugging hugged beyond belief ... Don't try to access
> * anything but 32-bit words ...
> */
> addr = &bridge->b_type0_cfg_dev[slot].f[fn].l[where >> 2];

[snip]

NAK'ed to all of the proposed changes to ops-bridge.c. The SGI IOC3 chip is an
abomination out of some dark, Lovecraftian nightmare, and the code comment is,
truthfully, being somewhat nice in its description of things. They need to
remain as-is as a warning to future generations of how not to design
multifunction/multidevice chipsets.

--
Joshua Kinard
Gentoo/MIPS
[email protected]
rsa6144/5C63F4E3F5C6C943 2015-04-27
177C 1972 1FB8 F254 BAD0 3E72 5C63 F4E3 F5C6 C943

"The past tempts us, the present confuses us, the future frightens us. And our
lives slip away, moment by moment, lost in that vast, terrible in-between."

--Emperor Turhan, Centauri Republic

2018-12-01 05:00:15

by Mike Galbraith

[permalink] [raw]
Subject: Re: [PATCH RFC 01/15] MIPS: replace **** with a hug

On Fri, 2018-11-30 at 11:27 -0800, Jarkko Sakkinen wrote:
> In order to comply with the CoC, replace **** with a hug.
>
> Signed-off-by: Jarkko Sakkinen <[email protected]>
> ---
> arch/mips/pci/ops-bridge.c | 24 ++++++++++++------------
> arch/mips/sgi-ip22/ip22-setup.c | 2 +-
> 2 files changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/arch/mips/pci/ops-bridge.c b/arch/mips/pci/ops-bridge.c
> index a1d2c4ae0d1b..c755c4c92fa9 100644
> --- a/arch/mips/pci/ops-bridge.c
> +++ b/arch/mips/pci/ops-bridge.c
> @@ -56,7 +56,7 @@ static int pci_conf0_read_config(struct pci_bus *bus, unsigned int devfn,
> return PCIBIOS_DEVICE_NOT_FOUND;
>
> /*
> - * IOC3 is fucking fucked beyond belief ... Don't even give the
> + * IOC3 is hugging hugged beyond belief ... Don't even give the

This obfuscation is a complete waste of reader brain cycles, as it will
transparently be reverted to the original in order to restore meaning.

-Mike