2018-02-13 21:45:53

by Shuah Khan

Subject: [PATCH] selftests: memory-hotplug: silence test command echo

Silence the following command being printed while running test.

./mem-on-off-test.sh -r 2 && echo "selftests: memory-hotplug [PASS]" ||
echo "selftests: memory-hotplug [FAIL]"

Signed-off-by: Shuah Khan <[email protected]>
---
tools/testing/selftests/memory-hotplug/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/memory-hotplug/Makefile b/tools/testing/selftests/memory-hotplug/Makefile
index 86636d207adf..183b46883875 100644
--- a/tools/testing/selftests/memory-hotplug/Makefile
+++ b/tools/testing/selftests/memory-hotplug/Makefile
@@ -4,7 +4,7 @@ all:
include ../lib.mk

TEST_PROGS := mem-on-off-test.sh
-override RUN_TESTS := ./mem-on-off-test.sh -r 2 && echo "selftests: memory-hotplug [PASS]" || echo "selftests: memory-hotplug [FAIL]"
+override RUN_TESTS := @./mem-on-off-test.sh -r 2 && echo "selftests: memory-hotplug [PASS]" || echo "selftests: memory-hotplug [FAIL]"
override EMIT_TESTS := echo "$(RUN_TESTS)"

run_full_test:
--
2.14.1

2018-03-01 09:13:47

by Naresh Kamboju

Subject: Re: [PATCH] selftests: memory-hotplug: silence test command echo

On 14 February 2018 at 03:14, Shuah Khan <[email protected]> wrote:
> Silence the following command being printed while running test.
>
> ./mem-on-off-test.sh -r 2 && echo "selftests: memory-hotplug [PASS]" ||
> echo "selftests: memory-hotplug [FAIL]"
>
> Signed-off-by: Shuah Khan <[email protected]>
> ---
> tools/testing/selftests/memory-hotplug/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/memory-hotplug/Makefile b/tools/testing/selftests/memory-hotplug/Makefile
> index 86636d207adf..183b46883875 100644
> --- a/tools/testing/selftests/memory-hotplug/Makefile
> +++ b/tools/testing/selftests/memory-hotplug/Makefile
> @@ -4,7 +4,7 @@ all:
> include ../lib.mk
>
> TEST_PROGS := mem-on-off-test.sh
> -override RUN_TESTS := ./mem-on-off-test.sh -r 2 && echo "selftests: memory-hotplug [PASS]" || echo "selftests: memory-hotplug [FAIL]"
> +override RUN_TESTS := @./mem-on-off-test.sh -r 2 && echo "selftests: memory-hotplug [PASS]" || echo "selftests: memory-hotplug [FAIL]"
> override EMIT_TESTS := echo "$(RUN_TESTS)"
>
> run_full_test:

The test execution broken due to this patch ?

Running tests in memory-hotplug
========================================
./run_kselftest.sh: line 121: @./mem-on-off-test.sh: No such file or directory
selftests: memory-hotplug [FAIL]

LAVA job id:
https://lkft.validation.linaro.org/scheduler/job/132699#L2526

- Naresh

> --
> 2.14.1
>

2018-03-01 14:42:54

by Shuah Khan

Subject: Re: [PATCH] selftests: memory-hotplug: silence test command echo

On 03/01/2018 02:11 AM, Naresh Kamboju wrote:
> On 14 February 2018 at 03:14, Shuah Khan <[email protected]> wrote:
>> Silence the following command being printed while running test.
>>
>> ./mem-on-off-test.sh -r 2 && echo "selftests: memory-hotplug [PASS]" ||
>> echo "selftests: memory-hotplug [FAIL]"
>>
>> Signed-off-by: Shuah Khan <[email protected]>
>> ---
>> tools/testing/selftests/memory-hotplug/Makefile | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/memory-hotplug/Makefile b/tools/testing/selftests/memory-hotplug/Makefile
>> index 86636d207adf..183b46883875 100644
>> --- a/tools/testing/selftests/memory-hotplug/Makefile
>> +++ b/tools/testing/selftests/memory-hotplug/Makefile
>> @@ -4,7 +4,7 @@ all:
>> include ../lib.mk
>>
>> TEST_PROGS := mem-on-off-test.sh
>> -override RUN_TESTS := ./mem-on-off-test.sh -r 2 && echo "selftests: memory-hotplug [PASS]" || echo "selftests: memory-hotplug [FAIL]"
>> +override RUN_TESTS := @./mem-on-off-test.sh -r 2 && echo "selftests: memory-hotplug [PASS]" || echo "selftests: memory-hotplug [FAIL]"
>> override EMIT_TESTS := echo "$(RUN_TESTS)"
>>
>> run_full_test:
>
> The test execution broken due to this patch ?

Thanks for reporting this. I will look at this. The change probably
broke the EMIT_TESTS case.

thanks,
-- Shuah