On 27.04.23 22:12, Hugo Villeneuve wrote:
> On Thu, 27 Apr 2023 17:07:59 -0300
> Fabio Estevam <[email protected]> wrote:
>
>> On Thu, Apr 27, 2023 at 5:06 PM Hugo Villeneuve <[email protected]> wrote:
>>
>>> Hi Fabio,
>>> it uses a ADIN1300 PHY.
>>>
>>> The datasheet indicate that the "Management interface active (t4)" state is reached at most 5ms after the reset signal is deasserted.
>>
>> Please add this information to the commit log and please add a Fixes: tag.
>
> Good idea, will do.
Please also add the PHY name into the DT, e.g.:
ethphy: ethernet-phy@4 { /* ADIN1300 */
I find this very useful when bringing up a new board and looking
for similar DTs.
Thanks,
Ahmad
>
> Hugo.
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
On Thu, 27 Apr 2023 22:16:45 +0200
Ahmad Fatoum <[email protected]> wrote:
> On 27.04.23 22:12, Hugo Villeneuve wrote:
> > On Thu, 27 Apr 2023 17:07:59 -0300
> > Fabio Estevam <[email protected]> wrote:
> >
> >> On Thu, Apr 27, 2023 at 5:06 PM Hugo Villeneuve <[email protected]> wrote:
> >>
> >>> Hi Fabio,
> >>> it uses a ADIN1300 PHY.
> >>>
> >>> The datasheet indicate that the "Management interface active (t4)" state is reached at most 5ms after the reset signal is deasserted.
> >>
> >> Please add this information to the commit log and please add a Fixes: tag.
> >
> > Good idea, will do.
>
> Please also add the PHY name into the DT, e.g.:
>
> ethphy: ethernet-phy@4 { /* ADIN1300 */
>
> I find this very useful when bringing up a new board and looking
> for similar DTs.
>
> Thanks,
> Ahmad
Hi Ahmad,
altough I agree it is a good idea, I prefer to not add this information for now, because there is probably some (old) versions of this SOM which use other PHY devices (maybe AR8033), but I am not 100% sure as this is not clear from the SOM manufacturer infos/website.
Hugo.
Hello Hugo,
On 28.04.23 00:18, Hugo Villeneuve wrote:
> On Thu, 27 Apr 2023 22:16:45 +0200
> Ahmad Fatoum <[email protected]> wrote:
>> Please also add the PHY name into the DT, e.g.:
>>
>> ethphy: ethernet-phy@4 { /* ADIN1300 */
>>
>> I find this very useful when bringing up a new board and looking
>> for similar DTs.
>
> Hi Ahmad,
> altough I agree it is a good idea, I prefer to not add this information for now, because there is probably some (old) versions of this SOM which use other PHY devices (maybe AR8033), but I am not 100% sure as this is not clear from the SOM manufacturer infos/website.
/* ADIN1300 on new revisions */ would work too.
Cheers,
Ahmad
>
> Hugo.
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |