2021-05-19 20:22:53

by Alex Elder

[permalink] [raw]
Subject: Re: [PATCH] staging: greybus: spi: add blank line after variable declaration

On 5/19/21 2:39 PM, Philippe Dixon wrote:
> This patch fixes the following checkpatch.pl warning:
>
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Philippe Dixon <[email protected]>

Looks good.

Reviewed-by: Alex Elder <[email protected]>

> ---
> drivers/staging/greybus/spilib.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/greybus/spilib.c b/drivers/staging/greybus/spilib.c
> index 30655153df6a..ad0700a0bb81 100644
> --- a/drivers/staging/greybus/spilib.c
> +++ b/drivers/staging/greybus/spilib.c
> @@ -246,6 +246,7 @@ static struct gb_operation *gb_spi_operation_create(struct gb_spilib *spi,
> xfer = spi->first_xfer;
> while (msg->state != GB_SPI_STATE_OP_DONE) {
> int xfer_delay;
> +
> if (xfer == spi->last_xfer)
> xfer_len = spi->last_xfer_size;
> else
>