2021-10-01 16:21:35

by Dave Hansen

Subject: Re: [PATCH v3 3/4] x86/mm: Flush global TLB when switching to trampoline page-table

On 10/1/21 8:48 AM, Joerg Roedel wrote:
> Move the switching code into a function so that it can be re-used and
> add a global TLB flush. This makes sure that usage of memory which is
> not mapped in the trampoline page-table is reliably caught.

This looks fine. But, just to be clear, nothing in this series reuses
the code, right?

2021-10-01 17:59:13

by Jörg Rödel

Subject: Re: [PATCH v3 3/4] x86/mm: Flush global TLB when switching to trampoline page-table

> Am 01.10.2021 um 18:13 schrieb Dave Hansen <[email protected]>:
>
> On 10/1/21 8:48 AM, Joerg Roedel wrote:
>> Move the switching code into a function so that it can be re-used and
>> add a global TLB flush. This makes sure that usage of memory which is
>> not mapped in the trampoline page-table is reliably caught.
>
> This looks fine. But, just to be clear, nothing in this series reuses
> the code, right?

Correct, but my SEV-ES kexec series will re-use it, as it also uses the trampoline_pgd and switches to real-mode to park the APs.

Regards,

Jörg