2023-02-15 21:47:40

by Guenter Roeck

Subject: [PATCH v2] media: cec: i2c: ch7322: Drop of_match_ptr

The driver does not instantiate on ACPI based systems if OF is disabled.
Fix the problem by dropping of_match_ptr.

Cc: Joshua Pius <[email protected]>
Tested-by: Joshua Pius <[email protected]>
Fixes: 21b9a47e0ec7 ("media: cec: i2c: ch7322: Add ch7322 CEC controller driver")
Signed-off-by: Guenter Roeck <[email protected]>
---
v2: Added Joshua's Tested-by: tag

drivers/media/cec/i2c/ch7322.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/cec/i2c/ch7322.c b/drivers/media/cec/i2c/ch7322.c
index 34fad7123704..3c6e6496a001 100644
--- a/drivers/media/cec/i2c/ch7322.c
+++ b/drivers/media/cec/i2c/ch7322.c
@@ -589,7 +589,7 @@ MODULE_DEVICE_TABLE(of, ch7322_of_match);
static struct i2c_driver ch7322_i2c_driver = {
.driver = {
.name = "ch7322",
- .of_match_table = of_match_ptr(ch7322_of_match),
+ .of_match_table = ch7322_of_match,
},
.probe_new = ch7322_probe,
.remove = ch7322_remove,
--
2.39.1

2023-02-16 17:23:05

by Joe Tessler

Subject: Re: [PATCH v2] media: cec: i2c: ch7322: Drop of_match_ptr

Hey Guenter,

Thank you for this fix.

On Wed, Feb 15, 2023 at 4:47 PM Guenter Roeck <[email protected]> wrote:
>
> The driver does not instantiate on ACPI based systems if OF is disabled.
> Fix the problem by dropping of_match_ptr.
>
> Cc: Joshua Pius <[email protected]>
> Tested-by: Joshua Pius <[email protected]>
> Fixes: 21b9a47e0ec7 ("media: cec: i2c: ch7322: Add ch7322 CEC controller driver")
> Signed-off-by: Guenter Roeck <[email protected]>

Reviewed-by: Joe Tessler <[email protected]>

> ---
> v2: Added Joshua's Tested-by: tag
>
> drivers/media/cec/i2c/ch7322.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/cec/i2c/ch7322.c b/drivers/media/cec/i2c/ch7322.c
> index 34fad7123704..3c6e6496a001 100644
> --- a/drivers/media/cec/i2c/ch7322.c
> +++ b/drivers/media/cec/i2c/ch7322.c
> @@ -589,7 +589,7 @@ MODULE_DEVICE_TABLE(of, ch7322_of_match);
> static struct i2c_driver ch7322_i2c_driver = {
> .driver = {
> .name = "ch7322",
> - .of_match_table = of_match_ptr(ch7322_of_match),
> + .of_match_table = ch7322_of_match,
> },
> .probe_new = ch7322_probe,
> .remove = ch7322_remove,
> --
> 2.39.1
>

Joe

2023-03-08 18:21:12

by Guenter Roeck

Subject: Re: [PATCH v2] media: cec: i2c: ch7322: Drop of_match_ptr

On Wed, Feb 15, 2023 at 01:47:24PM -0800, Guenter Roeck wrote:
> The driver does not instantiate on ACPI based systems if OF is disabled.
> Fix the problem by dropping of_match_ptr.
>

This patch has still not been applied, so ... ping ...

Is there anything else I need to do to get it applied ?

Thanks,
Guenter

> Cc: Joshua Pius <[email protected]>
> Tested-by: Joshua Pius <[email protected]>
> Fixes: 21b9a47e0ec7 ("media: cec: i2c: ch7322: Add ch7322 CEC controller driver")
> Signed-off-by: Guenter Roeck <[email protected]>
> ---
> v2: Added Joshua's Tested-by: tag
>
> drivers/media/cec/i2c/ch7322.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/cec/i2c/ch7322.c b/drivers/media/cec/i2c/ch7322.c
> index 34fad7123704..3c6e6496a001 100644
> --- a/drivers/media/cec/i2c/ch7322.c
> +++ b/drivers/media/cec/i2c/ch7322.c
> @@ -589,7 +589,7 @@ MODULE_DEVICE_TABLE(of, ch7322_of_match);
> static struct i2c_driver ch7322_i2c_driver = {
> .driver = {
> .name = "ch7322",
> - .of_match_table = of_match_ptr(ch7322_of_match),
> + .of_match_table = ch7322_of_match,
> },
> .probe_new = ch7322_probe,
> .remove = ch7322_remove,
> --
> 2.39.1
>