2017-03-02 13:53:00

by Piotr Sroka

Subject: [PATCH] mmc: core: fix changing bus witdh in hs400es mode

Fix the code to avoid changing bus width if HS400ES mode is selected.

Signed-off-by: Piotr Sroka <[email protected]>
---
drivers/mmc/core/mmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
index 7fd7228..c7d9c9f 100644
--- a/drivers/mmc/core/mmc.c
+++ b/drivers/mmc/core/mmc.c
@@ -1730,7 +1730,7 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr,
err = mmc_select_hs400(card);
if (err)
goto free_card;
- } else {
+ } else if (!mmc_card_hs400(card)) {
/* Select the desired bus width optionally */
err = mmc_select_bus_width(card);
if (err > 0 && mmc_card_hs(card)) {
--
2.2.2

2017-03-03 03:45:39

by Shawn Lin

Subject: Re: [PATCH] mmc: core: fix changing bus witdh in hs400es mode

Hi Poitr,

On 2017/3/2 21:47, Piotr Sroka wrote:
> Fix the code to avoid changing bus width if HS400ES mode is selected.
>

Thanks for catching this, but Guenter posted a fix[1] already. :)

[1]: https://patchwork.kernel.org/patch/9599261/

> Signed-off-by: Piotr Sroka <[email protected]>
> ---
> drivers/mmc/core/mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index 7fd7228..c7d9c9f 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -1730,7 +1730,7 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr,
> err = mmc_select_hs400(card);
> if (err)
> goto free_card;
> - } else {
> + } else if (!mmc_card_hs400(card)) {
> /* Select the desired bus width optionally */
> err = mmc_select_bus_width(card);
> if (err > 0 && mmc_card_hs(card)) {
>


--
Best Regards
Shawn Lin

2017-03-03 07:14:26

by Piotr Sroka

Subject: RE: [PATCH] mmc: core: fix changing bus witdh in hs400es mode

Hi Shawn

Thanks for the information.

Best Regards
Piotr Sroka

> -----Original Message-----
> From: Shawn Lin [mailto:[email protected]]
> Sent: 03 March, 2017 4:43 AM
> Subject: Re: [PATCH] mmc: core: fix changing bus witdh in hs400es mode
>
> Hi Poitr,
>
> On 2017/3/2 21:47, Piotr Sroka wrote:
> > Fix the code to avoid changing bus width if HS400ES mode is selected.
> >
>
> Thanks for catching this, but Guenter posted a fix[1] already. :)
>
> [1]: https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__patchwork.kernel.org_patch_9599261_&d=DwICbg&c=aUq983L2pue2FqKFoP6PGHMJQyoJ7kl3s3GZ-
> _haXqY&r=TGZtNfZu5Cjhu2K8A0Qhsot4HlKpSJ0Xmyc_L8hPwSI&m=z53GwiPyaRw9P09VfO84zhV8cTwdYWUhcbZBPTOUbXE&s=vtPh-
> 0g7-O6PZJOdgFp0jZeMrve8EG6qLDpphJN1vuM&e=
>
> > Signed-off-by: Piotr Sroka <[email protected]>
> > ---
> > drivers/mmc/core/mmc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c index
> > 7fd7228..c7d9c9f 100644
> > --- a/drivers/mmc/core/mmc.c
> > +++ b/drivers/mmc/core/mmc.c
> > @@ -1730,7 +1730,7 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr,
> > err = mmc_select_hs400(card);
> > if (err)
> > goto free_card;
> > - } else {
> > + } else if (!mmc_card_hs400(card)) {
> > /* Select the desired bus width optionally */
> > err = mmc_select_bus_width(card);
> > if (err > 0 && mmc_card_hs(card)) {
> >
>
>
> --
> Best Regards
> Shawn Lin