2021-08-12 07:49:19

by Rajesh Patil

[permalink] [raw]
Subject: [PATCH V5 5/7] arm64: dts: sc7280: Configure debug uart for sc7280-idp

Configure uart5 as debug uart and split the pinctrl functions
to match with SoC dt.

Signed-off-by: Rajesh Patil <[email protected]>
---
arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 19 ++++++++-----------
1 file changed, 8 insertions(+), 11 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
index c41c2d0..53993b3 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
@@ -254,6 +254,7 @@
};

&uart5 {
+ compatible = "qcom,geni-debug-uart";
status = "okay";
};

@@ -311,18 +312,14 @@
bias-pull-up;
};

-&qup_uart5_default {
- tx {
- pins = "gpio46";
- drive-strength = <2>;
- bias-disable;
- };
+&qup_uart5_tx {
+ drive-strength = <2>;
+ bias-disable;
+};

- rx {
- pins = "gpio47";
- drive-strength = <2>;
- bias-pull-up;
- };
+&qup_uart5_rx {
+ drive-strength = <2>;
+ bias-pull-up;
};

&sdc1_on {
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation


2021-08-12 17:49:54

by Matthias Kaehlcke

[permalink] [raw]
Subject: Re: [PATCH V5 5/7] arm64: dts: sc7280: Configure debug uart for sc7280-idp

On Thu, Aug 12, 2021 at 01:11:16PM +0530, Rajesh Patil wrote:
> Configure uart5 as debug uart and split the pinctrl functions
> to match with SoC dt.
>
> Signed-off-by: Rajesh Patil <[email protected]>

As I mentioned on '[4/7] arm64: dts: sc7280: Update QUPv3 UART5 DT node',
I think you need to squash the two patches to avoid breaking (temporarily)
the SC7280 IDP DT due to the undefined node 'qup_uart5_default'

2021-08-26 13:11:32

by Rajesh Patil

[permalink] [raw]
Subject: Re: [PATCH V5 5/7] arm64: dts: sc7280: Configure debug uart for sc7280-idp

On 2021-08-12 21:35, Matthias Kaehlcke wrote:
> On Thu, Aug 12, 2021 at 01:11:16PM +0530, Rajesh Patil wrote:
>> Configure uart5 as debug uart and split the pinctrl functions
>> to match with SoC dt.
>>
>> Signed-off-by: Rajesh Patil <[email protected]>
>
> As I mentioned on '[4/7] arm64: dts: sc7280: Update QUPv3 UART5 DT
> node',
> I think you need to squash the two patches to avoid breaking
> (temporarily)
> the SC7280 IDP DT due to the undefined node 'qup_uart5_default'

Okay