2022-04-23 03:50:33

by Vasily Averin

Subject: [PATCH] mm/memcg: minor cleanup in non-memcg_kmem version of mem_cgroup_from_obj()

Replace leading spaces by tab:
WARNING: please, no spaces at the start of a line
#X: FILE: include/linux/memcontrol.h:1480:
+ return NULL;$

Fixes: commit 8380ce479010 ("mm: fork: fix kernel_stack memcg stats for various stack implementations")
Signed-off-by: Vasily Averin <[email protected]>
---
include/linux/memcontrol.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
index a68dce3873fc..294515d06dbe 100644
--- a/include/linux/memcontrol.h
+++ b/include/linux/memcontrol.h
@@ -1753,7 +1753,7 @@ static inline int memcg_kmem_id(struct mem_cgroup *memcg)

static inline struct mem_cgroup *mem_cgroup_from_obj(void *p)
{
- return NULL;
+ return NULL;
}

#endif /* CONFIG_MEMCG_KMEM */
--
2.25.1

2022-04-23 15:20:19

by Shakeel Butt

Subject: Re: [PATCH] mm/memcg: minor cleanup in non-memcg_kmem version of mem_cgroup_from_obj()

On Sat, Apr 23, 2022 at 05:23:03AM +0300, Vasily Averin wrote:
> Replace leading spaces by tab:
> WARNING: please, no spaces at the start of a line
> #X: FILE: include/linux/memcontrol.h:1480:
> + return NULL;$
>
> Fixes: commit 8380ce479010 ("mm: fork: fix kernel_stack memcg stats for various stack implementations")
> Signed-off-by: Vasily Averin <[email protected]>

Acked-by: Shakeel Butt <[email protected]>

2022-04-25 12:24:20

by Michal Hocko

Subject: Re: [PATCH] mm/memcg: minor cleanup in non-memcg_kmem version of mem_cgroup_from_obj()

On Sat 23-04-22 05:23:03, Vasily Averin wrote:
> Replace leading spaces by tab:
> WARNING: please, no spaces at the start of a line
> #X: FILE: include/linux/memcontrol.h:1480:
> + return NULL;$
>
> Fixes: commit 8380ce479010 ("mm: fork: fix kernel_stack memcg stats for various stack implementations")

Please drop the Fixes tag. The tag is supposed to point to a functional
breakage and this is purely a style fix.

> Signed-off-by: Vasily Averin <[email protected]>

Acked-by: Michal Hocko <[email protected]>

> ---
> include/linux/memcontrol.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
> index a68dce3873fc..294515d06dbe 100644
> --- a/include/linux/memcontrol.h
> +++ b/include/linux/memcontrol.h
> @@ -1753,7 +1753,7 @@ static inline int memcg_kmem_id(struct mem_cgroup *memcg)
>
> static inline struct mem_cgroup *mem_cgroup_from_obj(void *p)
> {
> - return NULL;
> + return NULL;
> }
>
> #endif /* CONFIG_MEMCG_KMEM */
> --
> 2.25.1

--
Michal Hocko
SUSE Labs

2022-04-25 13:48:32

by Vasily Averin

Subject: Re: [PATCH] mm/memcg: minor cleanup in non-memcg_kmem version of mem_cgroup_from_obj()

On 4/25/22 10:37, Michal Hocko wrote:
> On Sat 23-04-22 05:23:03, Vasily Averin wrote:
>> Replace leading spaces by tab:
>> WARNING: please, no spaces at the start of a line
>> #X: FILE: include/linux/memcontrol.h:1480:
>> + return NULL;$
>>
>> Fixes: commit 8380ce479010 ("mm: fork: fix kernel_stack memcg stats for various stack implementations")
>
> Please drop the Fixes tag. The tag is supposed to point to a functional
> breakage and this is purely a style fix.
>
>> Signed-off-by: Vasily Averin <[email protected]>
>
> Acked-by: Michal Hocko <[email protected]>

Andrew Morton suggested do not create separate patch for this change,
So I'm going to combine it with my next patch, which adds a few lines below.
Even if it will not be approved -- it isn't a big problem, someone will fix it later.