2018-02-01 16:25:52

by SF Markus Elfring

Subject: [PATCH] i2c-mux-reg: Delete an error message for a failed memory allocation in i2c_mux_reg_probe_dt()

From: Markus Elfring <[email protected]>
Date: Thu, 1 Feb 2018 17:17:19 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/i2c/muxes/i2c-mux-reg.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/i2c/muxes/i2c-mux-reg.c b/drivers/i2c/muxes/i2c-mux-reg.c
index c948e5a4cb04..f624ed64a47b 100644
--- a/drivers/i2c/muxes/i2c-mux-reg.c
+++ b/drivers/i2c/muxes/i2c-mux-reg.c
@@ -127,10 +127,8 @@ static int i2c_mux_reg_probe_dt(struct regmux *mux,
values = devm_kzalloc(&pdev->dev,
sizeof(*mux->data.values) * mux->data.n_values,
GFP_KERNEL);
- if (!values) {
- dev_err(&pdev->dev, "Cannot allocate values array");
+ if (!values)
return -ENOMEM;
- }

for_each_child_of_node(np, child) {
of_property_read_u32(child, "reg", values + i);
--
2.16.1

2018-02-01 16:49:48

by Alexander Sverdlin

Subject: Re: [PATCH] i2c-mux-reg: Delete an error message for a failed memory allocation in i2c_mux_reg_probe_dt()

On 01/02/18 17:24, SF Markus Elfring wrote:
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <[email protected]>

Reviewed-by: Alexander Sverdlin <[email protected]>

> ---
> drivers/i2c/muxes/i2c-mux-reg.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/muxes/i2c-mux-reg.c b/drivers/i2c/muxes/i2c-mux-reg.c
> index c948e5a4cb04..f624ed64a47b 100644
> --- a/drivers/i2c/muxes/i2c-mux-reg.c
> +++ b/drivers/i2c/muxes/i2c-mux-reg.c
> @@ -127,10 +127,8 @@ static int i2c_mux_reg_probe_dt(struct regmux *mux,
> values = devm_kzalloc(&pdev->dev,
> sizeof(*mux->data.values) * mux->data.n_values,
> GFP_KERNEL);
> - if (!values) {
> - dev_err(&pdev->dev, "Cannot allocate values array");
> + if (!values)
> return -ENOMEM;
> - }
>
> for_each_child_of_node(np, child) {
> of_property_read_u32(child, "reg", values + i);

--
Best regards,
Alexander Sverdlin.

2018-05-24 12:02:39

by Peter Rosin

Subject: Re: [PATCH] i2c-mux-reg: Delete an error message for a failed memory allocation in i2c_mux_reg_probe_dt()

On 2018-02-01 17:24, SF Markus Elfring wrote:
> From: Markus Elfring <[email protected]>
> Date: Thu, 1 Feb 2018 17:17:19 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <[email protected]>

Applied to i2c-mux/for-next with a shortened subject.

Cheers,
Peter