2024-02-04 16:06:52

by Ricardo B. Marliere

Subject: [PATCH] device-dax: make dax_bus_type const

Now that the driver core can properly handle constant struct bus_type,
move the dax_bus_type variable to be a constant structure as well,
placing it into read-only memory which can not be modified at runtime.

Cc: Greg Kroah-Hartman <[email protected]>
Suggested-by: Greg Kroah-Hartman <[email protected]>
Signed-off-by: Ricardo B. Marliere <[email protected]>
---
drivers/dax/bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c
index 1659b787b65f..fe0a415c854d 100644
--- a/drivers/dax/bus.c
+++ b/drivers/dax/bus.c
@@ -222,7 +222,7 @@ static void dax_bus_remove(struct device *dev)
dax_drv->remove(dev_dax);
}

-static struct bus_type dax_bus_type = {
+static const struct bus_type dax_bus_type = {
.name = "dax",
.uevent = dax_bus_uevent,
.match = dax_bus_match,

---
base-commit: 73bf93edeeea866b0b6efbc8d2595bdaaba7f1a5
change-id: 20240204-bus_cleanup-dax-52c34f72615f

Best regards,
--
Ricardo B. Marliere <[email protected]>

2024-02-05 20:27:54

by Greg KH

Subject: Re: [PATCH] device-dax: make dax_bus_type const

On Sun, Feb 04, 2024 at 01:07:11PM -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the dax_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <[email protected]>
> Suggested-by: Greg Kroah-Hartman <[email protected]>
> Signed-off-by: Ricardo B. Marliere <[email protected]>

Reviewed-by: Greg Kroah-Hartman <[email protected]>

2024-02-05 22:32:21

by Dave Jiang

Subject: Re: [PATCH] device-dax: make dax_bus_type const

On 2/4/24 9:07 AM, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the dax_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <[email protected]>
> Suggested-by: Greg Kroah-Hartman <[email protected]>
> Signed-off-by: Ricardo B. Marliere <[email protected]>

Reviewed-by: Dave Jiang <[email protected]>
> ---
> drivers/dax/bus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c
> index 1659b787b65f..fe0a415c854d 100644
> --- a/drivers/dax/bus.c
> +++ b/drivers/dax/bus.c
> @@ -222,7 +222,7 @@ static void dax_bus_remove(struct device *dev)
> dax_drv->remove(dev_dax);
> }
>
> -static struct bus_type dax_bus_type = {
> +static const struct bus_type dax_bus_type = {
> .name = "dax",
> .uevent = dax_bus_uevent,
> .match = dax_bus_match,
>
> ---
> base-commit: 73bf93edeeea866b0b6efbc8d2595bdaaba7f1a5
> change-id: 20240204-bus_cleanup-dax-52c34f72615f
>
> Best regards,