2022-05-11 19:41:11

by Florian Weimer

[permalink] [raw]
Subject: Re: [PATCH] x86/vsyscall: Remove CONFIG_LEGACY_VSYSCALL_EMULATE

* Andy Lutomirski:

> CONFIG_LEGACY_VSYSCALL_EMULATE is, as far as I know, only needed for the
> combined use of exotic and outdated debugging mechanisms with outdated
> binaries. At this point, no one should be using it. We would like to
> implement dynamic switching of vsyscalls, but this is much more
> complicated to support in EMULATE mode than XONLY mode.
>
> So let's force all the distros off of EMULATE mode. If anyone actually
> needs it, they can set vsyscall=emulate, and we can then get away with
> refusing to support newer security models if that option is set.
>
> Cc: [email protected]
> Cc: Kees Cook <[email protected]>
> Cc: Florian Weimer <[email protected]>
> Signed-off-by: Andy Lutomirski <[email protected]>

Sounds a good idea to me.

Acked-by: Florian Weimer <[email protected]>

Regarding the mechanics, is it customary to remove the actual code (the
EMULATE enum constant) in later commits?

Thanks,
Florian



2022-05-12 08:42:32

by Andy Lutomirski

[permalink] [raw]
Subject: Re: [PATCH] x86/vsyscall: Remove CONFIG_LEGACY_VSYSCALL_EMULATE



On Wed, May 11, 2022, at 11:35 AM, Florian Weimer wrote:
> * Andy Lutomirski:
>
>> CONFIG_LEGACY_VSYSCALL_EMULATE is, as far as I know, only needed for the
>> combined use of exotic and outdated debugging mechanisms with outdated
>> binaries. At this point, no one should be using it. We would like to
>> implement dynamic switching of vsyscalls, but this is much more
>> complicated to support in EMULATE mode than XONLY mode.
>>
>> So let's force all the distros off of EMULATE mode. If anyone actually
>> needs it, they can set vsyscall=emulate, and we can then get away with
>> refusing to support newer security models if that option is set.
>>
>> Cc: [email protected]
>> Cc: Kees Cook <[email protected]>
>> Cc: Florian Weimer <[email protected]>
>> Signed-off-by: Andy Lutomirski <[email protected]>
>
> Sounds a good idea to me.
>
> Acked-by: Florian Weimer <[email protected]>
>
> Regarding the mechanics, is it customary to remove the actual code (the
> EMULATE enum constant) in later commits?
>

Might be several versions later. This patch intentionally still supports booting with vsyscall=emulate.

2022-05-14 00:46:28

by Borislav Petkov

[permalink] [raw]
Subject: Re: [PATCH] x86/vsyscall: Remove CONFIG_LEGACY_VSYSCALL_EMULATE

On Wed, May 11, 2022 at 08:35:02PM +0200, Florian Weimer wrote:
> Regarding the mechanics, is it customary to remove the actual code (the
> EMULATE enum constant) in later commits?

It is still needed for

"Emulate mode is deprecated and can only be enabled using the kernel
command line."

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette