2024-03-18 06:08:21

by Yufeng Wang

Subject: [PATCH] floppy: remove duplicated code, unlock_fdc() function has the same code "do_floppy = NULL" inside.

Cc: [email protected]
Signed-off-by: Yufeng Wang <[email protected]>
---
drivers/block/floppy.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
index 1b399ec8c07d..25c9d85667f1 100644
--- a/drivers/block/floppy.c
+++ b/drivers/block/floppy.c
@@ -2787,7 +2787,6 @@ static void redo_fd_request(void)
pending = set_next_request();
spin_unlock_irq(&floppy_lock);
if (!pending) {
- do_floppy = NULL;
unlock_fdc();
return;
}
--
2.34.1

2024-03-18 08:34:46

by Denis Efremov

Subject: Re: [PATCH] floppy: remove duplicated code, unlock_fdc() function has the same code "do_floppy = NULL" inside.

Hello,

Please, add a small commit message to the patch. The commit title
is too long and can be reduced to something like "floppy: remove duplicated
code in redo_fd_request()". Rest can be added to the commit message.

On 3/18/24 10:07, Yufeng Wang wrote:
> Cc: [email protected]

We don't need to send this patch to stable. It's not a bugfix.

Please, send v2 with commit message and new title.
The change looks good to me.

> Signed-off-by: Yufeng Wang <[email protected]>
> ---
> drivers/block/floppy.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
> index 1b399ec8c07d..25c9d85667f1 100644
> --- a/drivers/block/floppy.c
> +++ b/drivers/block/floppy.c
> @@ -2787,7 +2787,6 @@ static void redo_fd_request(void)
> pending = set_next_request();
> spin_unlock_irq(&floppy_lock);
> if (!pending) {
> - do_floppy = NULL;
> unlock_fdc();
> return;
> }

Thanks,
Denis