2017-06-19 05:45:01

by Arvind Yadav

Subject: [PATCH v2] macintosh: rack-meter: make of_device_ids const.

of_device_ids are not supposed to change at runtime. All functions
working with of_device_ids provided by <linux/of.h> work with const
of_device_ids. So mark the non-const structs as const.

File size before:
text data bss dec hex filename
407 576 0 983 3d7 drivers/macintosh/rack-meter.o

File size after constify rackmeter_match.
text data bss dec hex filename
807 176 0 983 3d7 drivers/macintosh/rack-meter.o

Signed-off-by: Arvind Yadav <[email protected]>
---
Changes in v1:
Subject was wrong. It should be constify rackmeter_match.

drivers/macintosh/rack-meter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/macintosh/rack-meter.c b/drivers/macintosh/rack-meter.c
index e199fd6..35582eb 100644
--- a/drivers/macintosh/rack-meter.c
+++ b/drivers/macintosh/rack-meter.c
@@ -579,7 +579,7 @@ static int rackmeter_shutdown(struct macio_dev* mdev)
return 0;
}

-static struct of_device_id rackmeter_match[] = {
+static const struct of_device_id rackmeter_match[] = {
{ .name = "i2s" },
{ }
};
--
1.9.1

2017-08-21 13:39:10

by Michael Ellerman

Subject: Re: [v2] macintosh: rack-meter: make of_device_ids const.

On Mon, 2017-06-19 at 05:44:25 UTC, Arvind Yadav wrote:
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by <linux/of.h> work with const
> of_device_ids. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 407 576 0 983 3d7 drivers/macintosh/rack-meter.o
>
> File size after constify rackmeter_match.
> text data bss dec hex filename
> 807 176 0 983 3d7 drivers/macintosh/rack-meter.o
>
> Signed-off-by: Arvind Yadav <[email protected]>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/516fa8d0e19d854253460ea7692551

cheers