2023-10-23 23:01:06

by Randy Dunlap

Subject: [PATCH] nvme-keyring: add MODULE_LICENSE()

When NVME_KEYRING=y (NVME_AUTH is not set), there is a modpost build
error:

ERROR: modpost: missing MODULE_LICENSE() in drivers/nvme/common/nvme-common.o

so add a MODULE_LICENSE() to keyring.c (copied from auth.c).

Fixes: 9d77eb527784 ("nvme-keyring: register '.nvme' keyring")
Signed-off-by: Randy Dunlap <[email protected]>
Cc: Keith Busch <[email protected]>
Cc: Jens Axboe <[email protected]>
Cc: Christoph Hellwig <[email protected]>
Cc: Sagi Grimberg <[email protected]>
Cc: Hannes Reinecke <[email protected]>
Cc: [email protected]
---
drivers/nvme/common/keyring.c | 2 ++
1 file changed, 2 insertions(+)

diff -- a/drivers/nvme/common/keyring.c b/drivers/nvme/common/keyring.c
--- a/drivers/nvme/common/keyring.c
+++ b/drivers/nvme/common/keyring.c
@@ -180,3 +180,5 @@ void nvme_keyring_exit(void)
key_put(nvme_keyring);
}
EXPORT_SYMBOL_GPL(nvme_keyring_exit);
+
+MODULE_LICENSE("GPL v2");

2023-10-24 05:25:11

by Hannes Reinecke

Subject: Re: [PATCH] nvme-keyring: add MODULE_LICENSE()

On 10/24/23 01:00, Randy Dunlap wrote:
> When NVME_KEYRING=y (NVME_AUTH is not set), there is a modpost build
> error:
>
> ERROR: modpost: missing MODULE_LICENSE() in drivers/nvme/common/nvme-common.o
>
> so add a MODULE_LICENSE() to keyring.c (copied from auth.c).
>
> Fixes: 9d77eb527784 ("nvme-keyring: register '.nvme' keyring")
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Keith Busch <[email protected]>
> Cc: Jens Axboe <[email protected]>
> Cc: Christoph Hellwig <[email protected]>
> Cc: Sagi Grimberg <[email protected]>
> Cc: Hannes Reinecke <[email protected]>
> Cc: [email protected]
> ---
> drivers/nvme/common/keyring.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff -- a/drivers/nvme/common/keyring.c b/drivers/nvme/common/keyring.c
> --- a/drivers/nvme/common/keyring.c
> +++ b/drivers/nvme/common/keyring.c
> @@ -180,3 +180,5 @@ void nvme_keyring_exit(void)
> key_put(nvme_keyring);
> }
> EXPORT_SYMBOL_GPL(nvme_keyring_exit);
> +
> +MODULE_LICENSE("GPL v2");

Reviewed-by: Hannes Reinecke <[email protected]>

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
[email protected] +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew
Myers, Andrew McDonald, Martje Boudien Moerman

2023-10-24 06:30:02

by Christoph Hellwig

Subject: Re: [PATCH] nvme-keyring: add MODULE_LICENSE()

Looks good:

Reviewed-by: Christoph Hellwig <[email protected]>

2023-11-20 14:43:14

by Sagi Grimberg

Subject: Re: [PATCH] nvme-keyring: add MODULE_LICENSE()

Reviewed-by: Sagi Grimberg <[email protected]>