2016-12-04 10:33:58

by Pan Bian

Subject: [PATCH 1/1] isdn: hisax: set error code on failure

From: Pan Bian <[email protected]>

In function hfc4s8s_probe(), the value of return variable err should be
negative on failures. However, when the call to request_region() returns
NULL, the value of err is 0. This patch fixes the bug, assiging
"-EBUSY" to err on the path that request_region() fails.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188931

Signed-off-by: Pan Bian <[email protected]>
---
drivers/isdn/hisax/hfc4s8s_l1.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/isdn/hisax/hfc4s8s_l1.c b/drivers/isdn/hisax/hfc4s8s_l1.c
index 9600cd7..3172cee 100644
--- a/drivers/isdn/hisax/hfc4s8s_l1.c
+++ b/drivers/isdn/hisax/hfc4s8s_l1.c
@@ -1499,6 +1499,7 @@ struct hfc4s8s_l1 {
printk(KERN_INFO
"HFC-4S/8S: failed to request address space at 0x%04x\n",
hw->iobase);
+ err = -EBUSY;
goto out;
}

--
1.9.1

2016-12-04 10:40:55

by Sergei Shtylyov

Subject: Re: [PATCH 1/1] isdn: hisax: set error code on failure

On 12/4/2016 1:33 PM, Pan Bian wrote:

You now need to indicate the patch version in hte subject, like this:

[PATCH 1/1 v2] isdn:...

> From: Pan Bian <[email protected]>
>
> In function hfc4s8s_probe(), the value of return variable err should be
> negative on failures. However, when the call to request_region() returns
> NULL, the value of err is 0. This patch fixes the bug, assiging

Assigning.

> "-EBUSY" to err on the path that request_region() fails.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188931
>
> Signed-off-by: Pan Bian <[email protected]>
> ---

And here you're supposed to describe changes in the different patch
versions...

[...]

MBR, Sergei