2023-07-11 09:39:06

by Li, Hua Qian

Subject: [PATCH v2 2/3] arm64: dts: ti: Add reserved memory for watchdog

From: Li Hua Qian <[email protected]>

This patch adds a reserved memory for the TI AM65X platform watchdog to
reserve the specific info, triggering the watchdog reset in last boot,
to know if the board reboot is due to a watchdog reset.

Signed-off-by: Li Hua Qian <[email protected]>
---
arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi | 11 +++++++++++
1 file changed, 11 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
index e26bd988e522..77380e52a334 100644
--- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
@@ -63,6 +63,12 @@ rtos_ipc_memory_region: ipc-memories@a2000000 {
alignment = <0x1000>;
no-map;
};
+
+ /* To reserve the power-on(PON) reason for watchdog reset */
+ wdt_reset_memory_region: wdt-memory@a2200000 {
+ reg = <0x00 0xa2200000 0x00 0x00001000>;
+ no-map;
+ };
};

leds {
@@ -718,3 +724,8 @@ &mcu_r5fss0_core1 {
<&mcu_r5fss0_core1_memory_region>;
mboxes = <&mailbox0_cluster1>, <&mbox_mcu_r5fss0_core1>;
};
+
+&mcu_rti1 {
+ reg = <0x0 0x40610000 0x0 0x100>,
+ <0x0 0xa2200000 0x0 0x1000>;
+};
--
2.34.1

2023-07-11 09:42:49

by Krzysztof Kozlowski

Subject: Re: [PATCH v2 2/3] arm64: dts: ti: Add reserved memory for watchdog

On 11/07/2023 11:17, [email protected] wrote:
> From: Li Hua Qian <[email protected]>
>
> This patch adds a reserved memory for the TI AM65X platform watchdog to
> reserve the specific info, triggering the watchdog reset in last boot,
> to know if the board reboot is due to a watchdog reset.
>
> Signed-off-by: Li Hua Qian <[email protected]>
> ---
> arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> index e26bd988e522..77380e52a334 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> @@ -63,6 +63,12 @@ rtos_ipc_memory_region: ipc-memories@a2000000 {
> alignment = <0x1000>;
> no-map;
> };
> +
> + /* To reserve the power-on(PON) reason for watchdog reset */
> + wdt_reset_memory_region: wdt-memory@a2200000 {
> + reg = <0x00 0xa2200000 0x00 0x00001000>;
> + no-map;
> + };
> };
>
> leds {
> @@ -718,3 +724,8 @@ &mcu_r5fss0_core1 {
> <&mcu_r5fss0_core1_memory_region>;
> mboxes = <&mailbox0_cluster1>, <&mbox_mcu_r5fss0_core1>;
> };
> +
> +&mcu_rti1 {
> + reg = <0x0 0x40610000 0x0 0x100>,
> + <0x0 0xa2200000 0x0 0x1000>;

That's a total mess. reserved memory and IO address space. Nope.



Best regards,
Krzysztof

2023-07-12 02:32:38

by Li, Hua Qian

Subject: Re: [PATCH v2 2/3] arm64: dts: ti: Add reserved memory for watchdog

On Tue, 2023-07-11 at 11:24 +0200, Krzysztof Kozlowski wrote:
> On 11/07/2023 11:17, [email protected] wrote:
> > From: Li Hua Qian <[email protected]>
> >
> > This patch adds a reserved memory for the TI AM65X platform
> > watchdog to
> > reserve the specific info, triggering the watchdog reset in last
> > boot,
> > to know if the board reboot is due to a watchdog reset.
> >
> > Signed-off-by: Li Hua Qian <[email protected]>
> > ---
> >  arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi | 11
> > +++++++++++
> >  1 file changed, 11 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> > b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> > index e26bd988e522..77380e52a334 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> > @@ -63,6 +63,12 @@ rtos_ipc_memory_region: ipc-memories@a2000000 {
> >                         alignment = <0x1000>;
> >                         no-map;
> >                 };
> > +
> > +               /* To reserve the power-on(PON) reason for watchdog
> > reset */
> > +               wdt_reset_memory_region: wdt-memory@a2200000 {
> > +                       reg = <0x00 0xa2200000 0x00 0x00001000>;
> > +                       no-map;
> > +               };
> >         };
> >  
> >         leds {
> > @@ -718,3 +724,8 @@ &mcu_r5fss0_core1 {
> >                         <&mcu_r5fss0_core1_memory_region>;
> >         mboxes = <&mailbox0_cluster1>, <&mbox_mcu_r5fss0_core1>;
> >  };
> > +
> > +&mcu_rti1 {
> > +       reg = <0x0 0x40610000 0x0 0x100>,
> > +             <0x0 0xa2200000 0x0 0x1000>;
>
> That's a total mess. reserved memory and IO address space. Nope.
>
>
>
> Best regards,
> Krzysztof
>
Yes, I misunderstood the advice. I intend to roll back as I mentioned
in my last email. Any new suggestions please let me know, thank you!

Best regards,
Li Hua Qian