2021-02-17 09:34:26

by Allen

Subject: [PATCH 0/2] optee: fix OOM seen due to tee_shm_free()

From: Allen Pais <[email protected]>

The following out of memory errors are seen on kexec reboot
from the optee core.

[ 0.368428] tee_bnxt_fw optee-clnt0: tee_shm_alloc failed
[ 0.368461] tee_bnxt_fw: probe of optee-clnt0 failed with error -22

tee_shm_release() is not invoked on dma shm buffer.

Implement .shutdown() in optee core as well as bnxt firmware driver
to handle the release of the buffers correctly.

More info:
https://github.com/OP-TEE/optee_os/issues/3637

Allen Pais (2):
optee: fix tee out of memory failure seen during kexec reboot
firmware: tee_bnxt: implement shutdown method to handle kexec reboots

drivers/firmware/broadcom/tee_bnxt_fw.c | 9 ++++
drivers/tee/optee/core.c | 69 ++++++++++++++++++-------
2 files changed, 58 insertions(+), 20 deletions(-)

--
2.25.1

2021-02-18 19:23:16

by Dhananjay Phadke

Subject: [PATCH 0/2] optee: fix OOM seen due to tee_shm_free()

From: Allen Pais <[email protected]>

On Wed, 17 Feb 2021 14:57:12 +0530, Allen Pais wrote:
> The following out of memory errors are seen on kexec reboot
> from the optee core.
>
> [ 0.368428] tee_bnxt_fw optee-clnt0: tee_shm_alloc failed
> [ 0.368461] tee_bnxt_fw: probe of optee-clnt0 failed with error -22
>
> tee_shm_release() is not invoked on dma shm buffer.
>
> Implement .shutdown() in optee core as well as bnxt firmware driver
> to handle the release of the buffers correctly.
>
> More info:
> https://github.com/OP-TEE/optee_os/issues/3637

CC: [email protected] instead of linux-mips?
TEE / TrustZone is ARM.

Also, for Broadcom specific -
CC: [email protected]

2021-02-23 06:27:33

by Allen Pais

Subject: Re: [PATCH 0/2] optee: fix OOM seen due to tee_shm_free()

>
> The following out of memory errors are seen on kexec reboot
> from the optee core.
>
> [ 0.368428] tee_bnxt_fw optee-clnt0: tee_shm_alloc failed
> [ 0.368461] tee_bnxt_fw: probe of optee-clnt0 failed with error -22
>
> tee_shm_release() is not invoked on dma shm buffer.
>
> Implement .shutdown() in optee core as well as bnxt firmware driver
> to handle the release of the buffers correctly.
>
> More info:
> https://github.com/OP-TEE/optee_os/issues/3637

Jens,

Could you please take sometime out and review the series.

Thanks.

>
> Allen Pais (2):
> optee: fix tee out of memory failure seen during kexec reboot
> firmware: tee_bnxt: implement shutdown method to handle kexec reboots
>
> drivers/firmware/broadcom/tee_bnxt_fw.c | 9 ++++
> drivers/tee/optee/core.c | 69 ++++++++++++++++++-------
> 2 files changed, 58 insertions(+), 20 deletions(-)
>