2023-06-17 17:28:29

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 01/15] arm64: dts: qcom: msm8916-gt5: drop incorrect accelerometer interrupt-names

st,lis2hh12 accelerometer binding does not allow interrupt-names:

msm8916-samsung-gt58.dtb: accelerometer@1d: 'interrupt-names' does not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi b/arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi
index 7943bb619116..54d648972d35 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi
@@ -101,7 +101,6 @@ accelerometer@1d {

interrupt-parent = <&tlmm>;
interrupts = <115 IRQ_TYPE_LEVEL_HIGH>;
- interrupt-names = "INT1";

st,drdy-int-pin = <1>;
mount-matrix = "0", "1", "0",
--
2.34.1



2023-06-17 17:29:10

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 14/15] arm64: dts: qcom: sc8180x-flex-5g: align gpio-keys node name with bindings

Bindings except certain pattern for gpio-keys children:

sc8180x-lenovo-flex-5g.dtb: gpio-keys: 'lid' does not match any of the regexes: '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$', 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
index 39c6ef0802aa..fca08db89769 100644
--- a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
+++ b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
@@ -36,7 +36,7 @@ gpio-keys {
pinctrl-0 = <&hall_int_active_state>;
pinctrl-names = "default";

- lid {
+ lid-switch {
gpios = <&tlmm 121 GPIO_ACTIVE_LOW>;
linux,input-type = <EV_SW>;
linux,code = <SW_LID>;
--
2.34.1


2023-06-17 17:29:51

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 02/15] arm64: dts: qcom: msm8916-l8150: correct light sensor VDDIO supply

liteon,ltr559 light sensor takes VDDIO, not VIO, supply:

msm8916-longcheer-l8150.dtb: light-sensor@23: 'vio-supply' does not match any of the regexes: 'pinctrl-[0-9]+'

Fixes: 3016af34ef8d ("arm64: dts: qcom: msm8916-longcheer-l8150: Add light and proximity sensor")
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts b/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts
index 97262b8519b3..3892ad4f639a 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts
+++ b/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts
@@ -165,7 +165,7 @@ light-sensor@23 {
pinctrl-0 = <&light_int_default>;

vdd-supply = <&pm8916_l17>;
- vio-supply = <&pm8916_l6>;
+ vddio-supply = <&pm8916_l6>;
};

gyroscope@68 {
--
2.34.1


2023-06-17 17:30:49

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 08/15] arm64: dts: qcom: sc7180-aspire1: use generic ADC channel node names

ADC channel node names were changed to require generic 'channel'. The
user-visible part is defined via label.

sc7180-acer-aspire1.dtb: adc@3100: 'charger-thermistor@4f', 'thermistor@4e' do not match any of the regexes: '^channel@[0-9a-f]+$', 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts b/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts
index b637b4270f88..dbb48934d499 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts
+++ b/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts
@@ -314,16 +314,18 @@ &mdss_dsi0_phy {
};

&pm6150_adc {
- thermistor@4e {
+ channel@4e {
reg = <ADC5_AMUX_THM2_100K_PU>;
qcom,ratiometric;
qcom,hw-settle-time = <200>;
+ label = "thermistor";
};

- charger-thermistor@4f {
+ channel@4f {
reg = <ADC5_AMUX_THM3_100K_PU>;
qcom,ratiometric;
qcom,hw-settle-time = <200>;
+ label = "charger_thermistor";
};
};

--
2.34.1


2023-06-17 17:30:51

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 04/15] arm64: dts: qcom: apq8096-db820c: drop label from I2C

I2C controller bindings do not allow label property:

apq8096-db820c.dtb: i2c@7577000: Unevaluated properties are not allowed ('label' was unexpected)

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/apq8096-db820c.dts | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
index 537547b97459..002cf5806d83 100644
--- a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
+++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
@@ -138,8 +138,7 @@ wlan_en: wlan-en-1-8v {
};

&blsp1_i2c3 {
- /* On Low speed expansion */
- label = "LS-I2C0";
+ /* On Low speed expansion: LS-I2C0 */
status = "okay";
};

@@ -168,14 +167,12 @@ &adsp_pil {
};

&blsp2_i2c1 {
- /* On High speed expansion */
- label = "HS-I2C2";
+ /* On High speed expansion: HS-I2C2 */
status = "okay";
};

&blsp2_i2c1 {
- /* On Low speed expansion */
- label = "LS-I2C1";
+ /* On Low speed expansion: LS-I2C1 */
status = "okay";
};

--
2.34.1


2023-06-17 17:32:02

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 03/15] arm64: dts: qcom: apq8016-sbc: drop label from I2C and SPI

I2C and SPI controller bindings do not allow label property:

apq8016-sbc.dtb: spi@78b7000: Unevaluated properties are not allowed ('label' was unexpected)
apq8016-sbc.dtb: i2c@78b6000: Unevaluated properties are not allowed ('label' was unexpected)

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/apq8016-sbc.dts | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
index f3d65a606194..e0993e32ee38 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
@@ -172,15 +172,13 @@ led@6 {
};

&blsp_i2c2 {
- /* On Low speed expansion */
+ /* On Low speed expansion: LS-I2C0 */
status = "okay";
- label = "LS-I2C0";
};

&blsp_i2c4 {
- /* On High speed expansion */
+ /* On High speed expansion: HS-I2C2 */
status = "okay";
- label = "HS-I2C2";

adv_bridge: bridge@39 {
status = "okay";
@@ -228,21 +226,18 @@ adv7533_out: endpoint {
};

&blsp_i2c6 {
- /* On Low speed expansion */
+ /* On Low speed expansion: LS-I2C1 */
status = "okay";
- label = "LS-I2C1";
};

&blsp_spi3 {
- /* On High speed expansion */
+ /* On High speed expansion: HS-SPI1 */
status = "okay";
- label = "HS-SPI1";
};

&blsp_spi5 {
- /* On Low speed expansion */
+ /* On Low speed expansion: LS-SPI0 */
status = "okay";
- label = "LS-SPI0";
};

&blsp_uart1 {
--
2.34.1


2023-06-17 17:32:29

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 13/15] arm64: dts: qcom: sc8180x-primus: correct panel ports

Panel takes only one port:

sc8180x-primus.dtb: panel: 'ports' does not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sc8180x-primus.dts | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc8180x-primus.dts b/arch/arm64/boot/dts/qcom/sc8180x-primus.dts
index fc038474cb71..9b8695b92c48 100644
--- a/arch/arm64/boot/dts/qcom/sc8180x-primus.dts
+++ b/arch/arm64/boot/dts/qcom/sc8180x-primus.dts
@@ -377,11 +377,9 @@ panel {

backlight = <&backlight>;

- ports {
- port {
- auo_b133han05_in: endpoint {
- remote-endpoint = <&mdss_edp_out>;
- };
+ port {
+ auo_b133han05_in: endpoint {
+ remote-endpoint = <&mdss_edp_out>;
};
};
};
--
2.34.1


2023-06-17 17:35:37

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 07/15] arm64: dts: qcom: msm8996-xiaomi: use generic node names

Use generic node names for I2C devices.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
index 8c2d6e9e851b..bcd2397eb373 100644
--- a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
@@ -189,7 +189,7 @@ &blsp2_i2c2 {
status = "okay";
clock-frequency = <400000>;

- nfc: pn548@28 {
+ nfc: nfc@28 {
compatible = "nxp,nxp-nci-i2c";

reg = <0x28>;
@@ -208,7 +208,7 @@ nfc: pn548@28 {
&blsp2_i2c3 {
status = "okay";

- typec: tusb320l@47 {
+ typec: typec@47 {
compatible = "ti,tusb320l";
reg = <0x47>;
interrupt-parent = <&tlmm>;
--
2.34.1


2023-06-17 17:37:17

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 06/15] arm64: dts: qcom: msm8996-xiaomi: drop label from I2C

I2C controller bindings do not allow label property:

msm8996-xiaomi-gemini.dtb: i2c@75b6000: Unevaluated properties are not allowed ('label' was unexpected)

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
index 47f55c7311e9..8c2d6e9e851b 100644
--- a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
@@ -187,7 +187,6 @@ &adsp_pil {

&blsp2_i2c2 {
status = "okay";
- label = "NFC_I2C";
clock-frequency = <400000>;

nfc: pn548@28 {
@@ -208,7 +207,6 @@ nfc: pn548@28 {

&blsp2_i2c3 {
status = "okay";
- label = "TYPEC_I2C";

typec: tusb320l@47 {
compatible = "ti,tusb320l";
@@ -220,7 +218,7 @@ typec: tusb320l@47 {

&blsp2_i2c6 {
status = "okay";
- label = "MSM_TS_I2C";
+ /* MSM_TS */
};

&blsp1_uart2 {
--
2.34.1


2023-06-17 17:41:57

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 12/15] arm64: dts: qcom: sc8180x-flex-5g: correct panel ports

Panel takes only one port:

sc8180x-lenovo-flex-5g.dtb: panel: 'ports' does not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
index b12e0a61b3c0..39c6ef0802aa 100644
--- a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
+++ b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
@@ -298,11 +298,9 @@ panel {

backlight = <&backlight>;

- ports {
- port {
- auo_b140han06_in: endpoint {
- remote-endpoint = <&mdss_edp_out>;
- };
+ port {
+ auo_b140han06_in: endpoint {
+ remote-endpoint = <&mdss_edp_out>;
};
};
};
--
2.34.1


2023-06-17 17:41:57

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 15/15] arm64: dts: qcom: sm6115-pro1x: fix incorrect gpio-key,wakeup

Use 'wakeup-source' instead of 'gpio-key,wakeup' to indicate key can
wake-up the device:

sm6115-fxtec-pro1x.dtb: gpio-keys: key-volume-up: Unevaluated properties are not allowed ('gpio-key,wakeup' was unexpected)

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts b/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
index 3ce9875e932c..9b70a87906dc 100644
--- a/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
+++ b/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
@@ -44,7 +44,7 @@ key-volume-up {
gpios = <&pm6125_gpios 5 GPIO_ACTIVE_LOW>;
debounce-interval = <15>;
linux,can-disable;
- gpio-key,wakeup;
+ wakeup-source;
};
};
};
--
2.34.1


2023-06-17 17:44:12

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 05/15] arm64: dts: qcom: msm8939: drop incorrect smp2p Hexagon properties

The children of qcom,smp2p do not need address/size-cells:

msm8939-sony-xperia-kanuti-tulip.dtb: smp2p-hexagon: slave-kernel: '#address-cells', '#size-cells' do not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/msm8939.dtsi | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8939.dtsi b/arch/arm64/boot/dts/qcom/msm8939.dtsi
index 895cafc11480..05d8abbbc840 100644
--- a/arch/arm64/boot/dts/qcom/msm8939.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8939.dtsi
@@ -386,8 +386,6 @@ hexagon_smp2p_in: slave-kernel {

interrupt-controller;
#interrupt-cells = <2>;
- #address-cells = <0>;
- #size-cells = <0>;
};
};

--
2.34.1


2023-06-17 18:25:51

by Nikita Travkin

[permalink] [raw]
Subject: Re: [PATCH 02/15] arm64: dts: qcom: msm8916-l8150: correct light sensor VDDIO supply

Krzysztof Kozlowski писал(а) 17.06.2023 22:15:
> liteon,ltr559 light sensor takes VDDIO, not VIO, supply:
>
> msm8916-longcheer-l8150.dtb: light-sensor@23: 'vio-supply' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Fixes: 3016af34ef8d ("arm64: dts: qcom: msm8916-longcheer-l8150: Add light and proximity sensor")
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Oops, thanks for noticing!

Reviewed-by: Nikita Travkin <[email protected]>

> ---
> arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts b/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts
> index 97262b8519b3..3892ad4f639a 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts
> @@ -165,7 +165,7 @@ light-sensor@23 {
> pinctrl-0 = <&light_int_default>;
>
> vdd-supply = <&pm8916_l17>;
> - vio-supply = <&pm8916_l6>;
> + vddio-supply = <&pm8916_l6>;
> };
>
> gyroscope@68 {

2023-06-17 18:28:12

by Nikita Travkin

[permalink] [raw]
Subject: Re: [PATCH 08/15] arm64: dts: qcom: sc7180-aspire1: use generic ADC channel node names

Krzysztof Kozlowski писал(а) 17.06.2023 22:15:
> ADC channel node names were changed to require generic 'channel'. The
> user-visible part is defined via label.
>
> sc7180-acer-aspire1.dtb: adc@3100: 'charger-thermistor@4f', 'thermistor@4e' do not match any of the regexes: '^channel@[0-9a-f]+$', 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Thanks for fixing this up!

Reviewed-by: Nikita Travkin <[email protected]>

> ---
> arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts b/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts
> index b637b4270f88..dbb48934d499 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts
> @@ -314,16 +314,18 @@ &mdss_dsi0_phy {
> };
>
> &pm6150_adc {
> - thermistor@4e {
> + channel@4e {
> reg = <ADC5_AMUX_THM2_100K_PU>;
> qcom,ratiometric;
> qcom,hw-settle-time = <200>;
> + label = "thermistor";
> };
>
> - charger-thermistor@4f {
> + channel@4f {
> reg = <ADC5_AMUX_THM3_100K_PU>;
> qcom,ratiometric;
> qcom,hw-settle-time = <200>;
> + label = "charger_thermistor";
> };
> };

2023-06-17 18:45:48

by Nikita Travkin

[permalink] [raw]
Subject: Re: [PATCH 01/15] arm64: dts: qcom: msm8916-gt5: drop incorrect accelerometer interrupt-names

Krzysztof Kozlowski писал(а) 17.06.2023 22:15:
> st,lis2hh12 accelerometer binding does not allow interrupt-names:
>
> msm8916-samsung-gt58.dtb: accelerometer@1d: 'interrupt-names' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

This indeed seems redundant... Thanks!

Reviewed-by: Nikita Travkin <[email protected]>

> ---
> arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi b/arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi
> index 7943bb619116..54d648972d35 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi
> @@ -101,7 +101,6 @@ accelerometer@1d {
>
> interrupt-parent = <&tlmm>;
> interrupts = <115 IRQ_TYPE_LEVEL_HIGH>;
> - interrupt-names = "INT1";
>
> st,drdy-int-pin = <1>;
> mount-matrix = "0", "1", "0",

2023-06-19 13:16:51

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 05/15] arm64: dts: qcom: msm8939: drop incorrect smp2p Hexagon properties

On 17.06.2023 19:15, Krzysztof Kozlowski wrote:
> The children of qcom,smp2p do not need address/size-cells:
>
> msm8939-sony-xperia-kanuti-tulip.dtb: smp2p-hexagon: slave-kernel: '#address-cells', '#size-cells' do not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/msm8939.dtsi | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8939.dtsi b/arch/arm64/boot/dts/qcom/msm8939.dtsi
> index 895cafc11480..05d8abbbc840 100644
> --- a/arch/arm64/boot/dts/qcom/msm8939.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8939.dtsi
> @@ -386,8 +386,6 @@ hexagon_smp2p_in: slave-kernel {
>
> interrupt-controller;
> #interrupt-cells = <2>;
> - #address-cells = <0>;
> - #size-cells = <0>;
> };
> };
>

2023-06-19 13:23:47

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 03/15] arm64: dts: qcom: apq8016-sbc: drop label from I2C and SPI

On 17.06.2023 19:15, Krzysztof Kozlowski wrote:
> I2C and SPI controller bindings do not allow label property:
>
> apq8016-sbc.dtb: spi@78b7000: Unevaluated properties are not allowed ('label' was unexpected)
> apq8016-sbc.dtb: i2c@78b6000: Unevaluated properties are not allowed ('label' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/apq8016-sbc.dts | 15 +++++----------
> 1 file changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
> index f3d65a606194..e0993e32ee38 100644
> --- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
> +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
> @@ -172,15 +172,13 @@ led@6 {
> };
>
> &blsp_i2c2 {
> - /* On Low speed expansion */
> + /* On Low speed expansion: LS-I2C0 */
> status = "okay";
> - label = "LS-I2C0";
> };
>
> &blsp_i2c4 {
> - /* On High speed expansion */
> + /* On High speed expansion: HS-I2C2 */
> status = "okay";
> - label = "HS-I2C2";
>
> adv_bridge: bridge@39 {
> status = "okay";
> @@ -228,21 +226,18 @@ adv7533_out: endpoint {
> };
>
> &blsp_i2c6 {
> - /* On Low speed expansion */
> + /* On Low speed expansion: LS-I2C1 */
> status = "okay";
> - label = "LS-I2C1";
> };
>
> &blsp_spi3 {
> - /* On High speed expansion */
> + /* On High speed expansion: HS-SPI1 */
> status = "okay";
> - label = "HS-SPI1";
> };
>
> &blsp_spi5 {
> - /* On Low speed expansion */
> + /* On Low speed expansion: LS-SPI0 */
> status = "okay";
> - label = "LS-SPI0";
> };
>
> &blsp_uart1 {

2023-06-19 13:23:48

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 07/15] arm64: dts: qcom: msm8996-xiaomi: use generic node names

On 17.06.2023 19:15, Krzysztof Kozlowski wrote:
> Use generic node names for I2C devices.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
> index 8c2d6e9e851b..bcd2397eb373 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
> @@ -189,7 +189,7 @@ &blsp2_i2c2 {
> status = "okay";
> clock-frequency = <400000>;
>
> - nfc: pn548@28 {
> + nfc: nfc@28 {
> compatible = "nxp,nxp-nci-i2c";
>
> reg = <0x28>;
> @@ -208,7 +208,7 @@ nfc: pn548@28 {
> &blsp2_i2c3 {
> status = "okay";
>
> - typec: tusb320l@47 {
> + typec: typec@47 {
> compatible = "ti,tusb320l";
> reg = <0x47>;
> interrupt-parent = <&tlmm>;

2023-06-19 13:27:43

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 08/15] arm64: dts: qcom: sc7180-aspire1: use generic ADC channel node names

On 17.06.2023 19:15, Krzysztof Kozlowski wrote:
> ADC channel node names were changed to require generic 'channel'. The
> user-visible part is defined via label.
>
> sc7180-acer-aspire1.dtb: adc@3100: 'charger-thermistor@4f', 'thermistor@4e' do not match any of the regexes: '^channel@[0-9a-f]+$', 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts b/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts
> index b637b4270f88..dbb48934d499 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts
> @@ -314,16 +314,18 @@ &mdss_dsi0_phy {
> };
>
> &pm6150_adc {
> - thermistor@4e {
> + channel@4e {
> reg = <ADC5_AMUX_THM2_100K_PU>;
> qcom,ratiometric;
> qcom,hw-settle-time = <200>;
> + label = "thermistor";
> };
>
> - charger-thermistor@4f {
> + channel@4f {
> reg = <ADC5_AMUX_THM3_100K_PU>;
> qcom,ratiometric;
> qcom,hw-settle-time = <200>;
> + label = "charger_thermistor";
> };
> };
>

2023-06-19 13:28:04

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 13/15] arm64: dts: qcom: sc8180x-primus: correct panel ports

On 17.06.2023 19:15, Krzysztof Kozlowski wrote:
> Panel takes only one port:
>
> sc8180x-primus.dtb: panel: 'ports' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/sc8180x-primus.dts | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8180x-primus.dts b/arch/arm64/boot/dts/qcom/sc8180x-primus.dts
> index fc038474cb71..9b8695b92c48 100644
> --- a/arch/arm64/boot/dts/qcom/sc8180x-primus.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8180x-primus.dts
> @@ -377,11 +377,9 @@ panel {
>
> backlight = <&backlight>;
>
> - ports {
> - port {
> - auo_b133han05_in: endpoint {
> - remote-endpoint = <&mdss_edp_out>;
> - };
> + port {
> + auo_b133han05_in: endpoint {
> + remote-endpoint = <&mdss_edp_out>;
> };
> };
> };

2023-06-19 13:28:56

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 14/15] arm64: dts: qcom: sc8180x-flex-5g: align gpio-keys node name with bindings

On 17.06.2023 19:15, Krzysztof Kozlowski wrote:
> Bindings except certain pattern for gpio-keys children:
>
> sc8180x-lenovo-flex-5g.dtb: gpio-keys: 'lid' does not match any of the regexes: '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$', 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
> index 39c6ef0802aa..fca08db89769 100644
> --- a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
> @@ -36,7 +36,7 @@ gpio-keys {
> pinctrl-0 = <&hall_int_active_state>;
> pinctrl-names = "default";
>
> - lid {
> + lid-switch {
> gpios = <&tlmm 121 GPIO_ACTIVE_LOW>;
> linux,input-type = <EV_SW>;
> linux,code = <SW_LID>;

2023-06-19 13:30:04

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 15/15] arm64: dts: qcom: sm6115-pro1x: fix incorrect gpio-key,wakeup

On 17.06.2023 19:15, Krzysztof Kozlowski wrote:
> Use 'wakeup-source' instead of 'gpio-key,wakeup' to indicate key can
> wake-up the device:
>
> sm6115-fxtec-pro1x.dtb: gpio-keys: key-volume-up: Unevaluated properties are not allowed ('gpio-key,wakeup' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts b/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
> index 3ce9875e932c..9b70a87906dc 100644
> --- a/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
> +++ b/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
> @@ -44,7 +44,7 @@ key-volume-up {
> gpios = <&pm6125_gpios 5 GPIO_ACTIVE_LOW>;
> debounce-interval = <15>;
> linux,can-disable;
> - gpio-key,wakeup;
> + wakeup-source;
> };
> };
> };

2023-06-19 13:33:43

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 12/15] arm64: dts: qcom: sc8180x-flex-5g: correct panel ports

On 17.06.2023 19:15, Krzysztof Kozlowski wrote:
> Panel takes only one port:
>
> sc8180x-lenovo-flex-5g.dtb: panel: 'ports' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
> index b12e0a61b3c0..39c6ef0802aa 100644
> --- a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
> @@ -298,11 +298,9 @@ panel {
>
> backlight = <&backlight>;
>
> - ports {
> - port {
> - auo_b140han06_in: endpoint {
> - remote-endpoint = <&mdss_edp_out>;
> - };
> + port {
> + auo_b140han06_in: endpoint {
> + remote-endpoint = <&mdss_edp_out>;
> };
> };
> };

2023-06-19 13:37:15

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 04/15] arm64: dts: qcom: apq8096-db820c: drop label from I2C

On 17.06.2023 19:15, Krzysztof Kozlowski wrote:
> I2C controller bindings do not allow label property:
>
> apq8096-db820c.dtb: i2c@7577000: Unevaluated properties are not allowed ('label' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/apq8096-db820c.dts | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
> index 537547b97459..002cf5806d83 100644
> --- a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
> +++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
> @@ -138,8 +138,7 @@ wlan_en: wlan-en-1-8v {
> };
>
> &blsp1_i2c3 {
> - /* On Low speed expansion */
> - label = "LS-I2C0";
> + /* On Low speed expansion: LS-I2C0 */
> status = "okay";
> };
>
> @@ -168,14 +167,12 @@ &adsp_pil {
> };
>
> &blsp2_i2c1 {
> - /* On High speed expansion */
> - label = "HS-I2C2";
> + /* On High speed expansion: HS-I2C2 */
> status = "okay";
> };
>
> &blsp2_i2c1 {
> - /* On Low speed expansion */
> - label = "LS-I2C1";
> + /* On Low speed expansion: LS-I2C1 */
> status = "okay";
> };
>

2023-06-19 13:38:28

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 06/15] arm64: dts: qcom: msm8996-xiaomi: drop label from I2C

On 17.06.2023 19:15, Krzysztof Kozlowski wrote:
> I2C controller bindings do not allow label property:
>
> msm8996-xiaomi-gemini.dtb: i2c@75b6000: Unevaluated properties are not allowed ('label' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
> index 47f55c7311e9..8c2d6e9e851b 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
> @@ -187,7 +187,6 @@ &adsp_pil {
>
> &blsp2_i2c2 {
> status = "okay";
> - label = "NFC_I2C";
> clock-frequency = <400000>;
>
> nfc: pn548@28 {
> @@ -208,7 +207,6 @@ nfc: pn548@28 {
>
> &blsp2_i2c3 {
> status = "okay";
> - label = "TYPEC_I2C";
>
> typec: tusb320l@47 {
> compatible = "ti,tusb320l";
> @@ -220,7 +218,7 @@ typec: tusb320l@47 {
>
> &blsp2_i2c6 {
> status = "okay";
> - label = "MSM_TS_I2C";
> + /* MSM_TS */
> };
>
> &blsp1_uart2 {

2023-07-10 05:29:19

by Bjorn Andersson

[permalink] [raw]
Subject: Re: (subset) [PATCH 01/15] arm64: dts: qcom: msm8916-gt5: drop incorrect accelerometer interrupt-names


On Sat, 17 Jun 2023 19:15:27 +0200, Krzysztof Kozlowski wrote:
> st,lis2hh12 accelerometer binding does not allow interrupt-names:
>
> msm8916-samsung-gt58.dtb: accelerometer@1d: 'interrupt-names' does not match any of the regexes: 'pinctrl-[0-9]+'
>
>

Applied, thanks!

[01/15] arm64: dts: qcom: msm8916-gt5: drop incorrect accelerometer interrupt-names
commit: c756d233715a899dd1cce4b1db4cbd50b0f55a9e
[02/15] arm64: dts: qcom: msm8916-l8150: correct light sensor VDDIO supply
commit: 6a541eaa6e8e5283efb993ae7a947bede8d01fa5
[03/15] arm64: dts: qcom: apq8016-sbc: drop label from I2C and SPI
commit: 031df8e650a8584d24c91fa64465e0660accd339
[04/15] arm64: dts: qcom: apq8096-db820c: drop label from I2C
commit: d4bbcf50baa9d7f70e97a3fd3b0d5e4f599a6217
[05/15] arm64: dts: qcom: msm8939: drop incorrect smp2p Hexagon properties
commit: 35cda57217adceee2f6bc738a1d98a2cccab709e
[06/15] arm64: dts: qcom: msm8996-xiaomi: drop label from I2C
commit: 368f8d196976e691af9cb8e61c9c852d574759fb
[07/15] arm64: dts: qcom: msm8996-xiaomi: use generic node names
commit: f7eb45427af670e48a9d28e6bbe7c6b8f68c3bfe
[08/15] arm64: dts: qcom: sc7180-aspire1: use generic ADC channel node names
commit: 0ec3a3e1b84bc27d482a6cab4e7ab7e2dd26ecf6
[10/15] arm64: dts: qcom: sc8180x: use generic ADC channel node names
commit: 978869867216e669b6bed11aa669317a11e0dc7a
[11/15] arm64: dts: qcom: sc8180x: align thermal node name with bindings
commit: 9ca4673201cc08df152a4ec054d81ae6a6895938
[12/15] arm64: dts: qcom: sc8180x-flex-5g: correct panel ports
commit: bee2dea5be813eafc7979c09854b447abd75dfd0
[13/15] arm64: dts: qcom: sc8180x-primus: correct panel ports
commit: 0f06e8cbd18e7f0e016f21c870f7d7af20ffd47e
[14/15] arm64: dts: qcom: sc8180x-flex-5g: align gpio-keys node name with bindings
commit: adc2ee325806e805f9d729f28dd1ac77dd82932a
[15/15] arm64: dts: qcom: sm6115-pro1x: fix incorrect gpio-key,wakeup
commit: c8df0c62cb6a21b98845c44c3539aa727874cd08

Best regards,
--
Bjorn Andersson <[email protected]>