2020-07-05 01:28:01

by Chris Healy

Subject: [PATCH] ARM64: dts: update MDIO speed and preamble for zii-ultra device

Update MDIO configuration with zii-ultra device to fully utilize
MDIO endpoint capabilities. Device supports 12.5MHz clock and
doesn't require MDIO preamble.

Signed-off-by: Chris Healy <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
index 6a55165bd76a..98aa67a4c040 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
@@ -132,6 +132,8 @@
#address-cells = <1>;
#size-cells = <0>;
status = "okay";
+ suppress-preamble = <1>;
+ clock-frequency = <12500000>;

switch: switch@0 {
compatible = "marvell,mv88e6085";
--
2.21.3

2020-07-07 21:57:32

by Fabio Estevam

Subject: Re: [PATCH] ARM64: dts: update MDIO speed and preamble for zii-ultra device

Hi Chris,

The subject pattern used for ARM64 i.MX patches is like:

arm64: dts: zii-ultra: update MDIO speed and preamble

On Sat, Jul 4, 2020 at 10:26 PM Chris Healy <[email protected]> wrote:
>
> Update MDIO configuration with zii-ultra device to fully utilize
> MDIO endpoint capabilities. Device supports 12.5MHz clock and
> doesn't require MDIO preamble.
>
> Signed-off-by: Chris Healy <[email protected]>

Other than that:

Reviewed-by: Fabio Estevam <[email protected]>

2020-07-07 22:00:50

by Florian Fainelli

Subject: Re: [PATCH] ARM64: dts: update MDIO speed and preamble for zii-ultra device

Hi Chris,

On 7/4/2020 6:26 PM, Chris Healy wrote:
> Update MDIO configuration with zii-ultra device to fully utilize
> MDIO endpoint capabilities. Device supports 12.5MHz clock and
> doesn't require MDIO preamble.
>
> Signed-off-by: Chris Healy <[email protected]>
> ---
> arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> index 6a55165bd76a..98aa67a4c040 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> @@ -132,6 +132,8 @@
> #address-cells = <1>;
> #size-cells = <0>;
> status = "okay";
> + suppress-preamble = <1>;

suppress-preamble is defined as a boolean, so you can remove the "= <1>"
part entirely.
--
Florian

2020-07-07 22:51:27

by Chris Healy

Subject: Re: [PATCH] ARM64: dts: update MDIO speed and preamble for zii-ultra device

On Tue, Jul 7, 2020 at 2:54 PM Fabio Estevam <[email protected]> wrote:
>
> Hi Chris,
>
> The subject pattern used for ARM64 i.MX patches is like:
>
> arm64: dts: zii-ultra: update MDIO speed and preamble

Thanks for pointing this out. I have to make a change to this patch
anyway so I will resubmit with the correct subject pattern.

>
> On Sat, Jul 4, 2020 at 10:26 PM Chris Healy <[email protected]> wrote:
> >
> > Update MDIO configuration with zii-ultra device to fully utilize
> > MDIO endpoint capabilities. Device supports 12.5MHz clock and
> > doesn't require MDIO preamble.
> >
> > Signed-off-by: Chris Healy <[email protected]>
>
> Other than that:
>
> Reviewed-by: Fabio Estevam <[email protected]>

2020-07-07 22:51:27

by Chris Healy

Subject: Re: [PATCH] ARM64: dts: update MDIO speed and preamble for zii-ultra device

On Tue, Jul 7, 2020 at 2:59 PM Florian Fainelli <[email protected]> wrote:
>
> Hi Chris,
>
> On 7/4/2020 6:26 PM, Chris Healy wrote:
> > Update MDIO configuration with zii-ultra device to fully utilize
> > MDIO endpoint capabilities. Device supports 12.5MHz clock and
> > doesn't require MDIO preamble.
> >
> > Signed-off-by: Chris Healy <[email protected]>
> > ---
> > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> > index 6a55165bd76a..98aa67a4c040 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> > @@ -132,6 +132,8 @@
> > #address-cells = <1>;
> > #size-cells = <0>;
> > status = "okay";
> > + suppress-preamble = <1>;
>
> suppress-preamble is defined as a boolean, so you can remove the "= <1>"
> part entirely.

Good point, I'll make the necessary change.

> --
> Florian