2022-02-11 12:27:09

by Christophe JAILLET

Subject: [PATCH 1/3] VMCI: Fix the description of vmci_check_host_caps()

vmci_check_host_caps() doesn't return a bool but an int.
Fix the description accordingly.

Fixes: 782f24453536 ("VMCI: fix error handling path when registering guest driver")
Signed-off-by: Christophe JAILLET <[email protected]>
---
drivers/misc/vmw_vmci/vmci_guest.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/misc/vmw_vmci/vmci_guest.c b/drivers/misc/vmw_vmci/vmci_guest.c
index aa61a687b3e2..1a1858742f75 100644
--- a/drivers/misc/vmw_vmci/vmci_guest.c
+++ b/drivers/misc/vmw_vmci/vmci_guest.c
@@ -253,9 +253,9 @@ static void vmci_guest_cid_update(u32 sub_id,

/*
* Verify that the host supports the hypercalls we need. If it does not,
- * try to find fallback hypercalls and use those instead. Returns
- * true if required hypercalls (or fallback hypercalls) are
- * supported by the host, false otherwise.
+ * try to find fallback hypercalls and use those instead. Returns 0 if
+ * required hypercalls (or fallback hypercalls) are supported by the host,
+ * an error code otherwise.
*/
static int vmci_check_host_caps(struct pci_dev *pdev)
{
--
2.32.0

2022-02-17 09:13:24

by Vishnu Dasa

Subject: Re: [PATCH 1/3] VMCI: Fix the description of vmci_check_host_caps()

> On Feb 10, 2022, at 2:27 PM, Christophe JAILLET <[email protected]> wrote:
>
> vmci_check_host_caps() doesn't return a bool but an int.
> Fix the description accordingly.
>
> Fixes: 782f24453536 ("VMCI: fix error handling path when registering guest driver")
> Signed-off-by: Christophe JAILLET <[email protected]>
> ---
> drivers/misc/vmw_vmci/vmci_guest.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/misc/vmw_vmci/vmci_guest.c b/drivers/misc/vmw_vmci/vmci_guest.c
> index aa61a687b3e2..1a1858742f75 100644
> --- a/drivers/misc/vmw_vmci/vmci_guest.c
> +++ b/drivers/misc/vmw_vmci/vmci_guest.c
> @@ -253,9 +253,9 @@ static void vmci_guest_cid_update(u32 sub_id,
>
> /*
> * Verify that the host supports the hypercalls we need. If it does not,
> - * try to find fallback hypercalls and use those instead. Returns
> - * true if required hypercalls (or fallback hypercalls) are
> - * supported by the host, false otherwise.
> + * try to find fallback hypercalls and use those instead. Returns 0 if
> + * required hypercalls (or fallback hypercalls) are supported by the host,
> + * an error code otherwise.
> */
> static int vmci_check_host_caps(struct pci_dev *pdev)
> {
> --
> 2.32.0
>

Thanks!

Acked-by: Vishnu Dasa <[email protected]>