2024-04-28 11:16:27

by Liao Yuanhong

Subject: [PATCH] f2fs:remove the restriction on zone sector being align to pow2

For zoned-UFS, sector size may not aligned to pow2, so we need to remove
the pow2 limitation.

Signed-off-by: Liao Yuanhong <[email protected]>
---
drivers/md/dm-table.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
index 41f1d731ae5a..823f2f6a2d53 100644
--- a/drivers/md/dm-table.c
+++ b/drivers/md/dm-table.c
@@ -1663,10 +1663,6 @@ static int validate_hardware_zoned(struct dm_table *t, bool zoned,
return -EINVAL;
}

- /* Check zone size validity and compatibility */
- if (!zone_sectors || !is_power_of_2(zone_sectors))
- return -EINVAL;
-
if (dm_table_any_dev_attr(t, device_not_matches_zone_sectors, &zone_sectors)) {
DMERR("%s: zone sectors is not consistent across all zoned devices",
dm_device_name(t->md));
--
2.25.1

2024-04-28 11:23:30

by Chao Yu

Subject: Re: [PATCH] f2fs:remove the restriction on zone sector being align to pow2

On 2024/4/28 19:14, Liao Yuanhong wrote:
> For zoned-UFS, sector size may not aligned to pow2, so we need to remove
> the pow2 limitation.
>
> Signed-off-by: Liao Yuanhong <[email protected]>
> ---
> drivers/md/dm-table.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
> index 41f1d731ae5a..823f2f6a2d53 100644
> --- a/drivers/md/dm-table.c
> +++ b/drivers/md/dm-table.c

Hi, please discuss this in [email protected], thanks.

Thanks,

> @@ -1663,10 +1663,6 @@ static int validate_hardware_zoned(struct dm_table *t, bool zoned,
> return -EINVAL;
> }
>
> - /* Check zone size validity and compatibility */
> - if (!zone_sectors || !is_power_of_2(zone_sectors))
> - return -EINVAL;
> -
> if (dm_table_any_dev_attr(t, device_not_matches_zone_sectors, &zone_sectors)) {
> DMERR("%s: zone sectors is not consistent across all zoned devices",
> dm_device_name(t->md));