2005-12-07 17:33:07

by Ben Gardner

[permalink] [raw]
Subject: [PATCH 2/3] i386: CS5535 chip support - GPIO

Provides a simple GPIO char driver for the AMD CS5535, modeled after
the scx200_gpio driver.

Signed-off-by: Ben Gardner <[email protected]>

Attachments:
(No filename) (143.00 B)
 cs5535-gpio.patch.txt (6.48 kB)
 Download all attachments

2005-12-09 23:25:36

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH 2/3] i386: CS5535 chip support - GPIO

Ben Gardner <[email protected]> wrote:
>
> +/* These are defined in cs5535.c */
> +extern u32 cs5535_gpio_base;
> +extern u32 cs5535_gpio_mask;

And they should be declared in a header file, please.

Is there a reason for these being exported to non-GPL modules, or can they
be EXPORT_SYMBOL_GPL()?