2021-10-08 14:03:21

by Andriy Tryshnivskyy

Subject: [PATCH v4 0/1] iio/scmi: Add reading "raw" attribute.

This patch implements reading "raw" attribute.

The patch is based on v5.14.

Comparing to the previous version it has:
* do not use scmi_iio_get_raw() for reading raw attribute due to 32bit
return value limitation (actually I reverted the previous v3)
* introduce scmi_iio_read_raw to scmi_iio_ext_info[] which can return 64 bit
value
* enabling/disabling and reading raw attribute is done in direct mode

Any comments are very welcome.

Thanks,
Andriy.

Andriy Tryshnivskyy (1):
iio/scmi: Add reading "raw" attribute.

drivers/iio/common/scmi_sensors/scmi_iio.c | 66 ++++++++++++++++++++++
1 file changed, 66 insertions(+)


base-commit: 7d2a07b769330c34b4deabeed939325c77a7ec2f
--
2.17.1

2021-10-08 15:05:40

by Andriy Tryshnivskyy

Subject: Re: [PATCH v4 0/1] iio/scmi: Add reading "raw" attribute.

Hi All,

Please do not review this patch version, since iio_device_release_direct_mode is missing in error path.

Thanks,
Andriy.

On 08.10.21 16:58, Andriy Tryshnivskyy wrote:

> This patch implements reading "raw" attribute.
>
> The patch is based on v5.14.
>
> Comparing to the previous version it has:
> * do not use scmi_iio_get_raw() for reading raw attribute due to 32bit
> return value limitation (actually I reverted the previous v3)
> * introduce scmi_iio_read_raw to scmi_iio_ext_info[] which can return 64 bit
> value
> * enabling/disabling and reading raw attribute is done in direct mode
>
> Any comments are very welcome.
>
> Thanks,
> Andriy.
>
> Andriy Tryshnivskyy (1):
> iio/scmi: Add reading "raw" attribute.
>
> drivers/iio/common/scmi_sensors/scmi_iio.c | 66 ++++++++++++++++++++++
> 1 file changed, 66 insertions(+)
>
>
> base-commit: 7d2a07b769330c34b4deabeed939325c77a7ec2f