2017-11-08 21:20:06

by Boris Ostrovsky

[permalink] [raw]
Subject: Re: [PATCH] xen/pvcalls: fix unsigned less than zero error check

On 11/03/2017 05:01 AM, Juergen Gross wrote:
> On 03/11/17 09:42, Colin King wrote:
>> From: Colin Ian King <[email protected]>
>>
>> The check on bedata->ref is never true because ref is an unsigned
>> integer. Fix this by assigning signed int ret to the return of the
>> call to gnttab_claim_grant_reference so the -ve return can be checked.
>>
>> Detected by CoverityScan, CID#1460358 ("Unsigned compared against 0")
>>
>> Fixes: 219681909913 ("xen/pvcalls: connect to the backend")
>> Signed-off-by: Colin Ian King <[email protected]>
> Reviewed-by: Juergen Gross <[email protected]>


Applied to for-linus-4.15.

-boris

From 1583034918072649834@xxx Fri Nov 03 09:02:23 +0000 2017
X-GM-THRID: 1583033712795190059
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread