2023-10-16 13:10:21

by Andy Shevchenko

Subject: [PATCH v2 05/10] xhci: dbc: Check for errors first in xhci_dbc_stop()

The usual patter is to check for errors and then continue if none.
Apply that pattern to xhci_dbc_stop() code.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/usb/host/xhci-dbgcap.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/host/xhci-dbgcap.c b/drivers/usb/host/xhci-dbgcap.c
index 660e3ee31dc6..6b9f4b839270 100644
--- a/drivers/usb/host/xhci-dbgcap.c
+++ b/drivers/usb/host/xhci-dbgcap.c
@@ -646,11 +646,11 @@ static void xhci_dbc_stop(struct xhci_dbc *dbc)
spin_lock_irqsave(&dbc->lock, flags);
ret = xhci_do_dbc_stop(dbc);
spin_unlock_irqrestore(&dbc->lock, flags);
+ if (ret)
+ return;

- if (!ret) {
- xhci_dbc_mem_cleanup(dbc);
- pm_runtime_put_sync(dbc->dev); /* note, was self.controller */
- }
+ xhci_dbc_mem_cleanup(dbc);
+ pm_runtime_put_sync(dbc->dev); /* note, was self.controller */
}

static void
--
2.40.0.1.gaa8946217a0b

2023-10-16 17:08:35

by Sergei Shtylyov

Subject: Re: [PATCH v2 05/10] xhci: dbc: Check for errors first in xhci_dbc_stop()

On 10/16/23 4:09 PM, Andy Shevchenko wrote:

> The usual patter is to check for errors and then continue if none.

Pattern. :-)

> Apply that pattern to xhci_dbc_stop() code.
>
> Signed-off-by: Andy Shevchenko <[email protected]>
[...]

MBR, Sergey

2023-10-23 14:05:17

by Mathias Nyman

Subject: Re: [PATCH v2 05/10] xhci: dbc: Check for errors first in xhci_dbc_stop()

On 16.10.2023 19.55, Sergei Shtylyov wrote:
> On 10/16/23 4:09 PM, Andy Shevchenko wrote:
>
>> The usual patter is to check for errors and then continue if none.
>
> Pattern. :-)
>

I'll fix it while applying

-Mathias