On 2021/3/26 17:14, Herbert Xu wrote:
> On Fri, Mar 19, 2021 at 03:33:07PM +0800, Yang Shen wrote:
>>
>> +const struct hisi_zip_sqe_ops hisi_zip_ops_v2 = {
>> + .sqe_type = 0x3,
>> + .fill_addr = hisi_zip_fill_addr,
>> + .fill_buf_size = hisi_zip_fill_buf_size,
>> + .fill_buf_type = hisi_zip_fill_buf_type,
>> + .fill_req_type = hisi_zip_fill_req_type,
>> + .fill_tag = hisi_zip_fill_tag_v2,
>> + .fill_sqe_type = hisi_zip_fill_sqe_type,
>> + .get_tag = hisi_zip_get_tag_v2,
>> + .get_status = hisi_zip_get_status,
>> + .get_dstlen = hisi_zip_get_dstlen,
>> +};
>> +
>
> This triggers a new warning:
>
> CHECK ../drivers/crypto/hisilicon/zip/zip_crypto.c
> ../drivers/crypto/hisilicon/zip/zip_crypto.c:527:31: warning: symbol 'hisi_zip_ops_v1' was not declared. Should it be static?
> ../drivers/crypto/hisilicon/zip/zip_crypto.c:540:31: warning: symbol 'hisi_zip_ops_v2' was not declared. Should it be static?
>
> Please fix. Thanks.
>
Sorry， I'll fix this in next version.
Thanks.