2023-02-16 01:01:37

by Jesper Juhl

Subject: [Patch] [testing][wireguard] Remove unneeded version.h include pointed out by 'make versioncheck'

From e2fa4955c676960d0809e4afe8273075c94451c9 Mon Sep 17 00:00:00 2001
From: Jesper Juhl <[email protected]>
Date: Mon, 13 Feb 2023 02:58:36 +0100
Subject: [PATCH 06/12] [testing][wireguard] Remove unneeded version.h include
pointed out by 'make versioncheck'

Signed-off-by: Jesper Juhl <[email protected]>
---
tools/testing/selftests/wireguard/qemu/init.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/tools/testing/selftests/wireguard/qemu/init.c b/tools/testing/selftests/wireguard/qemu/init.c
index 3e49924dd77e..20d8d3192f75 100644
--- a/tools/testing/selftests/wireguard/qemu/init.c
+++ b/tools/testing/selftests/wireguard/qemu/init.c
@@ -24,7 +24,6 @@
#include <sys/sysmacros.h>
#include <sys/random.h>
#include <linux/random.h>
-#include <linux/version.h>

__attribute__((noreturn)) static void poweroff(void)
{
--
2.39.2

2023-02-16 17:11:50

by Alexander Lobakin

Subject: Re: [Patch] [testing][wireguard] Remove unneeded version.h include pointed out by 'make versioncheck'

From: Jesper Juhl <[email protected]>
Date: Thu, 16 Feb 2023 02:01:05 +0100 (CET)

>> From e2fa4955c676960d0809e4afe8273075c94451c9 Mon Sep 17 00:00:00 2001
> From: Jesper Juhl <[email protected]>
> Date: Mon, 13 Feb 2023 02:58:36 +0100
> Subject: [PATCH 06/12] [testing][wireguard] Remove unneeded version.h
> include
>  pointed out by 'make versioncheck'

Your patch is broken, pls resend.
Also I've no idea about the subject/prefix, shouldn't it be like:

[PATCH net-next] wireguard: selftests: remove unneeded version.h

?

>
> Signed-off-by: Jesper Juhl <[email protected]>
> ---
>  tools/testing/selftests/wireguard/qemu/init.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/tools/testing/selftests/wireguard/qemu/init.c
> b/tools/testing/selftests/wireguard/qemu/init.c
> index 3e49924dd77e..20d8d3192f75 100644
> --- a/tools/testing/selftests/wireguard/qemu/init.c
> +++ b/tools/testing/selftests/wireguard/qemu/init.c
> @@ -24,7 +24,6 @@
>  #include <sys/sysmacros.h>
>  #include <sys/random.h>
>  #include <linux/random.h>
> -#include <linux/version.h>
>
>  __attribute__((noreturn)) static void poweroff(void)
>  {

Thanks,
Olek

2023-02-16 17:36:14

by Jason A. Donenfeld

Subject: Re: [Patch] [testing][wireguard] Remove unneeded version.h include pointed out by 'make versioncheck'

No idea if this is something intended for me to apply or if it's an
automated email. Fix the formatting, resend, and then maybe I'll apply
it?