From: alinayu <[email protected]>
Add bindings for Richtek RTQ2208 IC controlled SubPMIC
Signed-off-by: Alina Yu <[email protected]>
---
v3
- Fix some typos
- Modify the descriptions for "richtek,mtp-sel"
- Modify the node name to lowercase and remove underscore
- Remove '|' from description
- Remove "regulator-compatible" from property
- Remove "regulator-state-mem" from pattern
- Modify node name to generic one
---
.../regulator/richtek,rtq2208-regulator.yaml | 206 +++++++++++++++++++++
1 file changed, 206 insertions(+)
create mode 100644 Documentation/devicetree/bindings/regulator/richtek,rtq2208-regulator.yaml
diff --git a/Documentation/devicetree/bindings/regulator/richtek,rtq2208-regulator.yaml b/Documentation/devicetree/bindings/regulator/richtek,rtq2208-regulator.yaml
new file mode 100644
index 0000000..2fc92e5
--- /dev/null
+++ b/Documentation/devicetree/bindings/regulator/richtek,rtq2208-regulator.yaml
@@ -0,0 +1,206 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/regulator/richtek,rtq2208-regulator.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Richtek RTQ2208 SubPMIC Regulator
+
+maintainers:
+ - Alina Yu <[email protected]>
+
+description: |
+ RTQ2208 is a highly integrated power converter that offers functional safety dual
+ multi-configurable synchronous buck converters and two LDOs.
+
+ Bucks support "regulator-allowed-modes" and "regulator-mode". The former defines the permitted
+ switching operation in normal mode; the latter defines the operation in suspend to RAM mode.
+
+ No matter the RTQ2208 is configured to normal or suspend to RAM mode, there are two switching
+ operation modes for all buck rails, automatic power saving mode (Auto mode) and forced continuous
+ conduction mode (FCCM).
+
+ The definition of modes is in the datasheet which is available in below link
+ and their meaning is::
+ 0 - Auto mode for power saving, which reducing the switching frequency at light load condition
+ to maintain high frequency.
+ 1 - FCCM to meet the strict voltage regulation accuracy, which keeping constant switching frequency.
+
+ Datasheet will be available soon at
+ https://www.richtek.com/assets/Products
+
+properties:
+ compatible:
+ enum:
+ - richtek,rtq2208
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ richtek,mtp-sel:
+ type: boolean
+ description:
+ vout register selection besed on this boolean value.
+ false - Using DVS0 register setting to adjust vout
+ true - Using DVS1 register setting to adjust vout
+
+ regulators:
+ type: object
+
+ patternProperties:
+ "^buck-[a-h]$":
+ type: object
+ $ref: regulator.yaml#
+ unevaluatedProperties: false
+ description:
+ description for buck-[a-h] regulator.
+
+ properties:
+ regulator-allowed-modes:
+ description:
+ two buck modes in different switching accuracy.
+ items:
+ enum: [0, 1]
+
+ regulator-mode:
+ enum: [0, 1]
+ description:
+ describe buck initial operating mode in suspend state.
+
+ "^ldo[1-2]$":
+ type: object
+ $ref: regulator.yaml#
+ description:
+ regulator description for ldo[1-2].
+
+ properties:
+ regulator-compatible:
+ pattern: "^LDO[1-2]$"
+
+ richtek,fixed-uV:
+ $ref: "/schemas/types.yaml#/definitions/uint32"
+ enum: [ 900000, 1200000, 1800000, 3300000 ]
+ description:
+ the fixed voltage in micro volt which is decided at the factory.
+
+required:
+ - compatible
+ - reg
+ - regulators
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ pmic@10 {
+ compatible = "richtek,rtq2208";
+ reg = <0x10>;
+ interrupts-extended = <&gpio26 0 IRQ_TYPE_LEVEL_LOW>;
+ richtek,mtp-sel;
+
+ regulators {
+ buck-a {
+ regulator-min-microvolt = <400000>;
+ regulator-max-microvolt = <2050000>;
+ regulator-allowed-modes = <0 1>;
+ regulator-always-on;
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ regulator-mode = <1>;
+ };
+ };
+ buck-b {
+ regulator-min-microvolt = <400000>;
+ regulator-max-microvolt = <2050000>;
+ regulator-allowed-modes = <0 1>;
+ regulator-always-on;
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ regulator-mode = <1>;
+ };
+ };
+ buck-c {
+ regulator-min-microvolt = <400000>;
+ regulator-max-microvolt = <2050000>;
+ regulator-allowed-modes = <0 1>;
+ regulator-always-on;
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ regulator-mode = <1>;
+ };
+ };
+ buck-d {
+ regulator-min-microvolt = <400000>;
+ regulator-max-microvolt = <2050000>;
+ regulator-allowed-modes = <0 1>;
+ regulator-always-on;
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ regulator-mode = <1>;
+ };
+ };
+ buck-e {
+ regulator-min-microvolt = <400000>;
+ regulator-max-microvolt = <2050000>;
+ regulator-allowed-modes = <0 1>;
+ regulator-always-on;
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ regulator-mode = <1>;
+ };
+ };
+ buck-f {
+ regulator-min-microvolt = <400000>;
+ regulator-max-microvolt = <2050000>;
+ regulator-allowed-modes = <0 1>;
+ regulator-always-on;
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ regulator-mode = <1>;
+ };
+ };
+ buck-g {
+ regulator-min-microvolt = <400000>;
+ regulator-max-microvolt = <2050000>;
+ regulator-allowed-modes = <0 1>;
+ regulator-always-on;
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ regulator-mode = <1>;
+ };
+ };
+ buck-h {
+ regulator-min-microvolt = <400000>;
+ regulator-max-microvolt = <2050000>;
+ regulator-allowed-modes = <0 1>;
+ regulator-always-on;
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ regulator-mode = <1>;
+ };
+ };
+ ldo1 {
+ richtek,fixed-uV = <1200000>;
+ regulator-always-on;
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ };
+ };
+ ldo2 {
+ regulator-always-on;
+ richtek,fixed-uV = <3300000>;
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ };
+ };
+ };
+ };
+ };
--
2.7.4
On 19/07/2023 06:25, [email protected] wrote:
> From: alinayu <[email protected]>
>
> Add bindings for Richtek RTQ2208 IC controlled SubPMIC
>
> Signed-off-by: Alina Yu <[email protected]>
> ---
> v3
> - Fix some typos
> - Modify the descriptions for "richtek,mtp-sel"
> - Modify the node name to lowercase and remove underscore
> - Remove '|' from description
> - Remove "regulator-compatible" from property
> - Remove "regulator-state-mem" from pattern
> - Modify node name to generic one
> ---
> .../regulator/richtek,rtq2208-regulator.yaml | 206 +++++++++++++++++++++
> 1 file changed, 206 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/regulator/richtek,rtq2208-regulator.yaml
>
> diff --git a/Documentation/devicetree/bindings/regulator/richtek,rtq2208-regulator.yaml b/Documentation/devicetree/bindings/regulator/richtek,rtq2208-regulator.yaml
> new file mode 100644
> index 0000000..2fc92e5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/richtek,rtq2208-regulator.yaml
No improvements here.
This is a friendly reminder during the review process.
It seems my previous comments were not fully addressed. Maybe my
feedback got lost between the quotes, maybe you just forgot to apply it.
Please go back to the previous discussion and either implement all
requested changes or keep discussing them.
Thank you.
Best regards,
Krzysztof
Hi,
Krzysztof,
On Wed, Jul 19, 2023 at 09:43:03AM +0200, Krzysztof Kozlowski wrote:
> On 19/07/2023 06:25, [email protected] wrote:
> > From: alinayu <[email protected]>
> >
> > Add bindings for Richtek RTQ2208 IC controlled SubPMIC
> >
> > Signed-off-by: Alina Yu <[email protected]>
> > ---
> > v3
> > - Fix some typos
> > - Modify the descriptions for "richtek,mtp-sel"
> > - Modify the node name to lowercase and remove underscore
> > - Remove '|' from description
> > - Remove "regulator-compatible" from property
> > - Remove "regulator-state-mem" from pattern
> > - Modify node name to generic one
> > ---
> > .../regulator/richtek,rtq2208-regulator.yaml | 206 +++++++++++++++++++++
> > 1 file changed, 206 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/regulator/richtek,rtq2208-regulator.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/regulator/richtek,rtq2208-regulator.yaml b/Documentation/devicetree/bindings/regulator/richtek,rtq2208-regulator.yaml
> > new file mode 100644
> > index 0000000..2fc92e5
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/regulator/richtek,rtq2208-regulator.yaml
>
> No improvements here.
>
> This is a friendly reminder during the review process.
>
> It seems my previous comments were not fully addressed. Maybe my
> feedback got lost between the quotes, maybe you just forgot to apply it.
> Please go back to the previous discussion and either implement all
> requested changes or keep discussing them.
>
> Thank you.
>
> Best regards,
> Krzysztof
>
Sorry, I missed this one "Filename like compatible".
If I modify the filename to "richtek,rtq2208.yaml", is it unlike a compatible ?
Best regards,
Alina
On 19/07/2023 10:46, Alina Yu wrote:
> Hi,
> Krzysztof,
>
> On Wed, Jul 19, 2023 at 09:43:03AM +0200, Krzysztof Kozlowski wrote:
>> On 19/07/2023 06:25, [email protected] wrote:
>>> From: alinayu <[email protected]>
>>>
>>> Add bindings for Richtek RTQ2208 IC controlled SubPMIC
>>>
>>> Signed-off-by: Alina Yu <[email protected]>
>>> ---
>>> v3
>>> - Fix some typos
>>> - Modify the descriptions for "richtek,mtp-sel"
>>> - Modify the node name to lowercase and remove underscore
>>> - Remove '|' from description
>>> - Remove "regulator-compatible" from property
>>> - Remove "regulator-state-mem" from pattern
>>> - Modify node name to generic one
>>> ---
>>> .../regulator/richtek,rtq2208-regulator.yaml | 206 +++++++++++++++++++++
>>> 1 file changed, 206 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/regulator/richtek,rtq2208-regulator.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/regulator/richtek,rtq2208-regulator.yaml b/Documentation/devicetree/bindings/regulator/richtek,rtq2208-regulator.yaml
>>> new file mode 100644
>>> index 0000000..2fc92e5
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/regulator/richtek,rtq2208-regulator.yaml
>>
>> No improvements here.
>>
>> This is a friendly reminder during the review process.
>>
>> It seems my previous comments were not fully addressed. Maybe my
>> feedback got lost between the quotes, maybe you just forgot to apply it.
>> Please go back to the previous discussion and either implement all
>> requested changes or keep discussing them.
>>
>> Thank you.
>>
>> Best regards,
>> Krzysztof
>>
>
>
> Sorry, I missed this one "Filename like compatible".
> If I modify the filename to "richtek,rtq2208.yaml", is it unlike a compatible ?
Yes.
Best regards,
Krzysztof