2023-02-16 01:04:00

by Jesper Juhl

Subject: [Patch] [samples/trace_events] Remove unnecessary version.h include pointed out by 'make versioncheck'

From 8917ba4246c3fa7344523a0c46b793c5dbb0400b Mon Sep 17 00:00:00 2001
From: Jesper Juhl <[email protected]>
Date: Mon, 13 Feb 2023 02:53:37 +0100
Subject: [PATCH 07/12] [samples/trace_events] Remove unneeded version.h
include pointed out by 'make versioncheck'

Signed-ogg-by: Jesper Juhl <[email protected]>
---
samples/trace_events/trace_custom_sched.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/samples/trace_events/trace_custom_sched.c b/samples/trace_events/trace_custom_sched.c
index b99d9ab7db85..dd409b704b35 100644
--- a/samples/trace_events/trace_custom_sched.c
+++ b/samples/trace_events/trace_custom_sched.c
@@ -8,7 +8,6 @@
#define pr_fmt(fmt) fmt

#include <linux/trace_events.h>
-#include <linux/version.h>
#include <linux/module.h>
#include <linux/sched.h>

--
2.39.2

2023-02-17 02:31:20

by Steven Rostedt

Subject: Re: [Patch] [samples/trace_events] Remove unnecessary version.h include pointed out by 'make versioncheck'

On Thu, 16 Feb 2023 02:03:29 +0100 (CET)
Jesper Juhl <[email protected]> wrote:

> >From 8917ba4246c3fa7344523a0c46b793c5dbb0400b Mon Sep 17 00:00:00 2001
> From: Jesper Juhl <[email protected]>
> Date: Mon, 13 Feb 2023 02:53:37 +0100
> Subject: [PATCH 07/12] [samples/trace_events] Remove unneeded version.h
> include pointed out by 'make versioncheck'
>

The subject is not formatted correctly. There's no body to the commit.
And the Signed-off-by tag is incorrect. Not to mention that the patch
itself is corrupted.

Please fix all of these.

-- Steve


> Signed-ogg-by: Jesper Juhl <[email protected]>
> ---
> samples/trace_events/trace_custom_sched.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/samples/trace_events/trace_custom_sched.c b/samples/trace_events/trace_custom_sched.c
> index b99d9ab7db85..dd409b704b35 100644
> --- a/samples/trace_events/trace_custom_sched.c
> +++ b/samples/trace_events/trace_custom_sched.c
> @@ -8,7 +8,6 @@
> #define pr_fmt(fmt) fmt
>
> #include <linux/trace_events.h>
> -#include <linux/version.h>
> #include <linux/module.h>
> #include <linux/sched.h>
>