2024-04-10 08:22:43

by Krzysztof Kozlowski

Subject: [PATCH RESEND] drm/armada: drop unneeded MODULE_ALIAS

The MODULE_DEVICE_TABLE already creates proper alias for platform
driver. Having another MODULE_ALIAS causes the alias to be duplicated.

Signed-off-by: Krzysztof Kozlowski <[email protected]>

---

Resent third time
https://lore.kernel.org/all/[email protected]/

Cc: Dmitry Baryshkov <[email protected]>
Cc: Neil Armstrong <[email protected]>
---
drivers/gpu/drm/armada/armada_drv.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/armada/armada_drv.c b/drivers/gpu/drm/armada/armada_drv.c
index e51ecc4f7ef4..f48e2cf8de43 100644
--- a/drivers/gpu/drm/armada/armada_drv.c
+++ b/drivers/gpu/drm/armada/armada_drv.c
@@ -283,4 +283,3 @@ module_exit(armada_drm_exit);
MODULE_AUTHOR("Russell King <[email protected]>");
MODULE_DESCRIPTION("Armada DRM Driver");
MODULE_LICENSE("GPL");
-MODULE_ALIAS("platform:armada-drm");
--
2.34.1

2024-04-10 15:20:28

by Neil Armstrong

Subject: Re: [PATCH RESEND] drm/armada: drop unneeded MODULE_ALIAS

On 10/04/2024 10:22, Krzysztof Kozlowski wrote:
> The MODULE_DEVICE_TABLE already creates proper alias for platform
> driver. Having another MODULE_ALIAS causes the alias to be duplicated.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
>
> Resent third time
> https://lore.kernel.org/all/[email protected]/
>
> Cc: Dmitry Baryshkov <[email protected]>
> Cc: Neil Armstrong <[email protected]>
> ---
> drivers/gpu/drm/armada/armada_drv.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/armada/armada_drv.c b/drivers/gpu/drm/armada/armada_drv.c
> index e51ecc4f7ef4..f48e2cf8de43 100644
> --- a/drivers/gpu/drm/armada/armada_drv.c
> +++ b/drivers/gpu/drm/armada/armada_drv.c
> @@ -283,4 +283,3 @@ module_exit(armada_drm_exit);
> MODULE_AUTHOR("Russell King <[email protected]>");
> MODULE_DESCRIPTION("Armada DRM Driver");
> MODULE_LICENSE("GPL");
> -MODULE_ALIAS("platform:armada-drm");

Reviewed-by: Neil Armstrong <[email protected]>

I think we'll need maxime or thomas ack to apply this via drm-misc-next

Neil

2024-04-11 07:02:03

by Javier Martinez Canillas

Subject: Re: [PATCH RESEND] drm/armada: drop unneeded MODULE_ALIAS

Neil Armstrong <[email protected]> writes:

Hello Neal,

> On 10/04/2024 10:22, Krzysztof Kozlowski wrote:
>> The MODULE_DEVICE_TABLE already creates proper alias for platform
>> driver. Having another MODULE_ALIAS causes the alias to be duplicated.
>>
>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>>
>> ---
>>
>> Resent third time
>> https://lore.kernel.org/all/[email protected]/
>>
>> Cc: Dmitry Baryshkov <[email protected]>
>> Cc: Neil Armstrong <[email protected]>
>> ---
>> drivers/gpu/drm/armada/armada_drv.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/armada/armada_drv.c b/drivers/gpu/drm/armada/armada_drv.c
>> index e51ecc4f7ef4..f48e2cf8de43 100644
>> --- a/drivers/gpu/drm/armada/armada_drv.c
>> +++ b/drivers/gpu/drm/armada/armada_drv.c
>> @@ -283,4 +283,3 @@ module_exit(armada_drm_exit);
>> MODULE_AUTHOR("Russell King <[email protected]>");
>> MODULE_DESCRIPTION("Armada DRM Driver");
>> MODULE_LICENSE("GPL");
>> -MODULE_ALIAS("platform:armada-drm");
>
> Reviewed-by: Neil Armstrong <[email protected]>
>
> I think we'll need maxime or thomas ack to apply this via drm-misc-next
>

I don't think you need an explicit ack for them to commit it:

https://drm.pages.freedesktop.org/maintainer-tools/committer-drm-misc.html#merge-criteria

BTW, the patch looks good to me as well.

Reviewed-by: Javier Martinez Canillas <[email protected]>

--
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat