LinuxLists.cc - [PATCH] x86/apic/timer: set ->min_delta_ticks and ->max_delta

In preparation for making the clockevents core NTP correction aware,
all clockevent device drivers must set ->min_delta_ticks and
->max_delta_ticks rather than ->min_delta_ns and ->max_delta_ns: a
clockevent device's rate is going to change dynamically and thus, the
ratio of ns to ticks ceases to stay invariant.

Make the MIPS arch's clockevent drivers initialize these fields properly.

This patch alone doesn't introduce any change in functionality as the
clockevents core still looks exclusively at the (untouched) ->min_delta_ns
and ->max_delta_ns. As soon as this has changed, a followup patch will
purge the initialization of ->min_delta_ns and ->max_delta_ns from these
drivers.

Signed-off-by: Nicolai Stange <[email protected]>
---

Notes:
This prerequisite patch is part of a larger effort to feed NTP
corrections into the clockevent devices' frequencies and thus
avoiding their notion of time to diverge from the system's
one. If you're interested, the current state of the whole series
can be found at [1].

If you haven't got any objections and these prerequisites get
merged by 4.12 everywhere, I'll proceed with the remainder of
this series in 4.13.

Applicable to next-20170324 as well as to John' Stultz tree [2].

[1]
git://nicst.de/linux.git cev-freq-adj.v10.fortglx-4.12-time
https://nicst.de/git/?p=linux.git;a=shortlog;h=refs/heads/cev-freq-adj.v10.fortglx-4.12-time

[2]
https://git.linaro.org/people/john.stultz/linux.git fortglx/4.12/time

arch/mips/alchemy/common/time.c | 4 +++-
arch/mips/jz4740/time.c | 2 ++
arch/mips/kernel/cevt-bcm1480.c | 2 ++
arch/mips/kernel/cevt-ds1287.c | 2 ++
arch/mips/kernel/cevt-gt641xx.c | 2 ++
arch/mips/kernel/cevt-sb1250.c | 2 ++
arch/mips/kernel/cevt-txx9.c | 2 ++
arch/mips/loongson32/common/time.c | 2 ++
arch/mips/loongson64/common/cs5536/cs5536_mfgpt.c | 2 ++
arch/mips/loongson64/loongson-3/hpet.c | 2 ++
arch/mips/ralink/cevt-rt3352.c | 2 ++
arch/mips/sgi-ip27/ip27-timer.c | 2 ++
12 files changed, 25 insertions(+), 1 deletion(-)

diff --git a/arch/mips/alchemy/common/time.c b/arch/mips/alchemy/common/time.c
index e1bec5a77c39..32d1333bb243 100644
--- a/arch/mips/alchemy/common/time.c
+++ b/arch/mips/alchemy/common/time.c
@@ -138,7 +138,9 @@ static int __init alchemy_time_init(unsigned int m2int)
cd->shift = 32;
cd->mult = div_sc(32768, NSEC_PER_SEC, cd->shift);
cd->max_delta_ns = clockevent_delta2ns(0xffffffff, cd);
- cd->min_delta_ns = clockevent_delta2ns(9, cd); /* ~0.28ms */
+ cd->max_delta_ticks = 0xffffffff;
+ cd->min_delta_ns = clockevent_delta2ns(9, cd);
+ cd->min_delta_ticks = 9; /* ~0.28ms */
clockevents_register_device(cd);
setup_irq(m2int, &au1x_rtcmatch2_irqaction);

diff --git a/arch/mips/jz4740/time.c b/arch/mips/jz4740/time.c
index bcf8f8c62737..bb1ad5119da4 100644
--- a/arch/mips/jz4740/time.c
+++ b/arch/mips/jz4740/time.c
@@ -145,7 +145,9 @@ void __init plat_time_init(void)

clockevent_set_clock(&jz4740_clockevent, clk_rate);
jz4740_clockevent.min_delta_ns = clockevent_delta2ns(100, &jz4740_clockevent);
+ jz4740_clockevent.min_delta_ticks = 100;
jz4740_clockevent.max_delta_ns = clockevent_delta2ns(0xffff, &jz4740_clockevent);
+ jz4740_clockevent.max_delta_ticks = 0xffff;
jz4740_clockevent.cpumask = cpumask_of(0);

clockevents_register_device(&jz4740_clockevent);
diff --git a/arch/mips/kernel/cevt-bcm1480.c b/arch/mips/kernel/cevt-bcm1480.c
index 940ac00e9129..8f9f2daf06a3 100644
--- a/arch/mips/kernel/cevt-bcm1480.c
+++ b/arch/mips/kernel/cevt-bcm1480.c
@@ -123,7 +123,9 @@ void sb1480_clockevent_init(void)
CLOCK_EVT_FEAT_ONESHOT;
clockevent_set_clock(cd, V_SCD_TIMER_FREQ);
cd->max_delta_ns = clockevent_delta2ns(0x7fffff, cd);
+ cd->max_delta_ticks = 0x7fffff;
cd->min_delta_ns = clockevent_delta2ns(2, cd);
+ cd->min_delta_ticks = 2;
cd->rating = 200;
cd->irq = irq;
cd->cpumask = cpumask_of(cpu);
diff --git a/arch/mips/kernel/cevt-ds1287.c b/arch/mips/kernel/cevt-ds1287.c
index 77a5ddf53f57..61ad9079fa16 100644
--- a/arch/mips/kernel/cevt-ds1287.c
+++ b/arch/mips/kernel/cevt-ds1287.c
@@ -128,7 +128,9 @@ int __init ds1287_clockevent_init(int irq)
cd->irq = irq;
clockevent_set_clock(cd, 32768);
cd->max_delta_ns = clockevent_delta2ns(0x7fffffff, cd);
+ cd->max_delta_ticks = 0x7fffffff;
cd->min_delta_ns = clockevent_delta2ns(0x300, cd);
+ cd->min_delta_ticks = 0x300;
cd->cpumask = cpumask_of(0);

clockevents_register_device(&ds1287_clockevent);
diff --git a/arch/mips/kernel/cevt-gt641xx.c b/arch/mips/kernel/cevt-gt641xx.c
index 66040051151d..fd90c82dc17d 100644
--- a/arch/mips/kernel/cevt-gt641xx.c
+++ b/arch/mips/kernel/cevt-gt641xx.c
@@ -152,7 +152,9 @@ static int __init gt641xx_timer0_clockevent_init(void)
cd->rating = 200 + gt641xx_base_clock / 10000000;
clockevent_set_clock(cd, gt641xx_base_clock);
cd->max_delta_ns = clockevent_delta2ns(0x7fffffff, cd);
+ cd->max_delta_ticks = 0x7fffffff;
cd->min_delta_ns = clockevent_delta2ns(0x300, cd);
+ cd->min_delta_ticks = 0x300;
cd->cpumask = cpumask_of(0);

clockevents_register_device(&gt641xx_timer0_clockevent);
diff --git a/arch/mips/kernel/cevt-sb1250.c b/arch/mips/kernel/cevt-sb1250.c
index 3d860efd63b9..9d1edb5938b8 100644
--- a/arch/mips/kernel/cevt-sb1250.c
+++ b/arch/mips/kernel/cevt-sb1250.c
@@ -123,7 +123,9 @@ void sb1250_clockevent_init(void)
CLOCK_EVT_FEAT_ONESHOT;
clockevent_set_clock(cd, V_SCD_TIMER_FREQ);
cd->max_delta_ns = clockevent_delta2ns(0x7fffff, cd);
+ cd->max_delta_ticks = 0x7fffff;
cd->min_delta_ns = clockevent_delta2ns(2, cd);
+ cd->min_delta_ticks = 2;
cd->rating = 200;
cd->irq = irq;
cd->cpumask = cpumask_of(cpu);
diff --git a/arch/mips/kernel/cevt-txx9.c b/arch/mips/kernel/cevt-txx9.c
index aaca60d6ffc3..7b17c8f5009d 100644
--- a/arch/mips/kernel/cevt-txx9.c
+++ b/arch/mips/kernel/cevt-txx9.c
@@ -196,7 +196,9 @@ void __init txx9_clockevent_init(unsigned long baseaddr, int irq,
clockevent_set_clock(cd, TIMER_CLK(imbusclk));
cd->max_delta_ns =
clockevent_delta2ns(0xffffffff >> (32 - TXX9_TIMER_BITS), cd);
+ cd->max_delta_ticks = 0xffffffff >> (32 - TXX9_TIMER_BITS);
cd->min_delta_ns = clockevent_delta2ns(0xf, cd);
+ cd->min_delta_ticks = 0xf;
cd->irq = irq;
cd->cpumask = cpumask_of(0),
clockevents_register_device(cd);
diff --git a/arch/mips/loongson32/common/time.c b/arch/mips/loongson32/common/time.c
index e6f972d35252..1c4332a26cf1 100644
--- a/arch/mips/loongson32/common/time.c
+++ b/arch/mips/loongson32/common/time.c
@@ -199,7 +199,9 @@ static void __init ls1x_time_init(void)

clockevent_set_clock(cd, mips_hpt_frequency);
cd->max_delta_ns = clockevent_delta2ns(0xffffff, cd);
+ cd->max_delta_ticks = 0xffffff;
cd->min_delta_ns = clockevent_delta2ns(0x000300, cd);
+ cd->min_delta_ticks = 0x000300;
cd->cpumask = cpumask_of(smp_processor_id());
clockevents_register_device(cd);

diff --git a/arch/mips/loongson64/common/cs5536/cs5536_mfgpt.c b/arch/mips/loongson64/common/cs5536/cs5536_mfgpt.c
index b817d6d3a060..a6adcc4f8960 100644
--- a/arch/mips/loongson64/common/cs5536/cs5536_mfgpt.c
+++ b/arch/mips/loongson64/common/cs5536/cs5536_mfgpt.c
@@ -123,7 +123,9 @@ void __init setup_mfgpt0_timer(void)
cd->cpumask = cpumask_of(cpu);
clockevent_set_clock(cd, MFGPT_TICK_RATE);
cd->max_delta_ns = clockevent_delta2ns(0xffff, cd);
+ cd->max_delta_ticks = 0xffff;
cd->min_delta_ns = clockevent_delta2ns(0xf, cd);
+ cd->min_delta_ticks = 0xf;

/* Enable MFGPT0 Comparator 2 Output to the Interrupt Mapper */
_wrmsr(DIVIL_MSR_REG(MFGPT_IRQ), 0, 0x100);
diff --git a/arch/mips/loongson64/loongson-3/hpet.c b/arch/mips/loongson64/loongson-3/hpet.c
index 24afe364637b..4df9d4b7356a 100644
--- a/arch/mips/loongson64/loongson-3/hpet.c
+++ b/arch/mips/loongson64/loongson-3/hpet.c
@@ -241,7 +241,9 @@ void __init setup_hpet_timer(void)
cd->cpumask = cpumask_of(cpu);
clockevent_set_clock(cd, HPET_FREQ);
cd->max_delta_ns = clockevent_delta2ns(0x7fffffff, cd);
+ cd->max_delta_ticks = 0x7fffffff;
cd->min_delta_ns = clockevent_delta2ns(HPET_MIN_PROG_DELTA, cd);
+ cd->min_delta_ticks = HPET_MIN_PROG_DELTA;

clockevents_register_device(cd);
setup_irq(HPET_T0_IRQ, &hpet_irq);
diff --git a/arch/mips/ralink/cevt-rt3352.c b/arch/mips/ralink/cevt-rt3352.c
index f24eee04e16a..b8a1376165b0 100644
--- a/arch/mips/ralink/cevt-rt3352.c
+++ b/arch/mips/ralink/cevt-rt3352.c
@@ -129,7 +129,9 @@ static int __init ralink_systick_init(struct device_node *np)
systick.dev.name = np->name;
clockevents_calc_mult_shift(&systick.dev, SYSTICK_FREQ, 60);
systick.dev.max_delta_ns = clockevent_delta2ns(0x7fff, &systick.dev);
+ systick.dev.max_delta_ticks = 0x7fff;
systick.dev.min_delta_ns = clockevent_delta2ns(0x3, &systick.dev);
+ systick.dev.min_delta_ticks = 0x3;
systick.dev.irq = irq_of_parse_and_map(np, 0);
if (!systick.dev.irq) {
pr_err("%s: request_irq failed", np->name);
diff --git a/arch/mips/sgi-ip27/ip27-timer.c b/arch/mips/sgi-ip27/ip27-timer.c
index 695c51bdd7dc..a53f0c8c901e 100644
--- a/arch/mips/sgi-ip27/ip27-timer.c
+++ b/arch/mips/sgi-ip27/ip27-timer.c
@@ -113,7 +113,9 @@ void hub_rt_clock_event_init(void)
cd->features = CLOCK_EVT_FEAT_ONESHOT;
clockevent_set_clock(cd, CYCLES_PER_SEC);
cd->max_delta_ns = clockevent_delta2ns(0xfffffffffffff, cd);
+ cd->max_delta_ticks = 0xfffffffffffff;
cd->min_delta_ns = clockevent_delta2ns(0x300, cd);
+ cd->min_delta_ticks = 0x300;
cd->rating = 200;
cd->irq = irq;
cd->cpumask = cpumask_of(cpu);
--
2.12.0

2017-03-30 19:53:30

by Nicolai Stange

[permalink] [raw]

Subject: [PATCH] powerpc/time: set ->min_delta_ticks and ->max_delta_ticks

2017-03-30 19:55:01

by Nicolai Stange

[permalink] [raw]

Subject: [PATCH] s390/time: set ->min_delta_ticks and ->max_delta_ticks

2017-03-30 19:56:01

by Nicolai Stange

[permalink] [raw]

Subject: [PATCH] score/time: set ->min_delta_ticks and ->max_delta_ticks

2017-03-30 19:57:03

by Nicolai Stange

[permalink] [raw]

Subject: [PATCH] sparc/time: set ->min_delta_ticks and ->max_delta_ticks

2017-03-30 19:57:49

by Nicolai Stange

[permalink] [raw]

Subject: [PATCH] tile/time: set ->min_delta_ticks and ->max_delta_ticks

2017-03-30 19:59:48

by Nicolai Stange

[permalink] [raw]

Subject: [PATCH] um/time: set ->min_delta_ticks and ->max_delta_ticks

2017-03-30 20:01:19

by Nicolai Stange

[permalink] [raw]

Subject: [PATCH] unicore32/time: set ->min_delta_ticks and ->max_delta_ticks

2017-03-30 20:03:52

by Nicolai Stange

[permalink] [raw]

Subject: [PATCH] x86/lguest/timer: set ->min_delta_ticks and ->max_delta_ticks

2017-03-30 20:05:05

by Nicolai Stange

[permalink] [raw]

Subject: [PATCH] x86/uv/time: set ->min_delta_ticks and ->max_delta_ticks

2017-03-30 20:06:50

by Nicolai Stange

[permalink] [raw]

Subject: [PATCH] x86/xen/time: set ->min_delta_ticks and ->max_delta_ticks

2017-03-30 20:07:56

by Nicolai Stange

[permalink] [raw]

Subject: [PATCH] clockevents/drivers/dw_apb: set ->min_delta_ticks and ->max_delta_ticks

2017-03-30 20:08:26

by Nicolai Stange

[permalink] [raw]

Subject: [PATCH] clockevents/drivers/metag: set ->min_delta_ticks and ->max_delta_ticks

2017-03-30 20:08:55

by Nicolai Stange

[permalink] [raw]

Subject: [PATCH] x86/numachip timer: set ->min_delta_ticks and ->max_delta_ticks

2017-03-30 20:09:19

by Nicolai Stange

[permalink] [raw]

Subject: [PATCH] clockevents/drivers/sh_cmt: set ->min_delta_ticks and ->max_delta_ticks

2017-03-30 20:10:29

by Nicolai Stange

[permalink] [raw]

Subject: [PATCH] clockevents/drivers/atlas7: set ->min_delta_ticks and ->max_delta_ticks

2017-03-30 23:00:53

by Boris Ostrovsky

[permalink] [raw]

Subject: Re: [PATCH] x86/xen/time: set ->min_delta_ticks and ->max_delta_ticks

On 03/30/2017 04:06 PM, Nicolai Stange wrote:
> In preparation for making the clockevents core NTP correction aware,
> all clockevent device drivers must set ->min_delta_ticks and
> ->max_delta_ticks rather than ->min_delta_ns and ->max_delta_ns: a
> clockevent device's rate is going to change dynamically and thus, the
> ratio of ns to ticks ceases to stay invariant.
>
> Make the x86 arch's xen clockevent driver initialize these fields properly.
>
> This patch alone doesn't introduce any change in functionality as the
> clockevents core still looks exclusively at the (untouched) ->min_delta_ns
> and ->max_delta_ns. As soon as this has changed, a followup patch will
> purge the initialization of ->min_delta_ns and ->max_delta_ns from this
> driver.
>
> Signed-off-by: Nicolai Stange <[email protected]>

Reviewed-by: Boris Ostrovsky <[email protected]>

2017-03-31 01:10:48

by Greg Ungerer

[permalink] [raw]

Subject: Re: [PATCH] m68k/coldfire/pit: set ->min_delta_ticks and ->max_delta_ticks

Hi Nicolai,

On 31/03/17 05:44, Nicolai Stange wrote:
> In preparation for making the clockevents core NTP correction aware,
> all clockevent device drivers must set ->min_delta_ticks and
> ->max_delta_ticks rather than ->min_delta_ns and ->max_delta_ns: a
> clockevent device's rate is going to change dynamically and thus, the
> ratio of ns to ticks ceases to stay invariant.
>
> Make the m68k arch's coldfire clockevent driver initialize these fields
> properly.
>
> This patch alone doesn't introduce any change in functionality as the
> clockevents core still looks exclusively at the (untouched) ->min_delta_ns
> and ->max_delta_ns. As soon as this has changed, a followup patch will
> purge the initialization of ->min_delta_ns and ->max_delta_ns from this
> driver.
>
> Signed-off-by: Nicolai Stange <[email protected]>

Looks ok to me.

Acked-by: Greg Ungerer <[email protected]>

Are you pushing this through some other git tree?
Or do you want me to push up to Linus?

Regards
Greg

> ---
>
> Notes:
> This prerequisite patch is part of a larger effort to feed NTP
> corrections into the clockevent devices' frequencies and thus
> avoiding their notion of time to diverge from the system's
> one. If you're interested, the current state of the whole series
> can be found at [1].
>
> If you haven't got any objections and these prerequisites get
> merged by 4.12 everywhere, I'll proceed with the remainder of
> this series in 4.13.
>
> Applicable to next-20170324 as well as to John' Stultz tree [2].
>
> [1]
> git://nicst.de/linux.git cev-freq-adj.v10.fortglx-4.12-time
> https://nicst.de/git/?p=linux.git;a=shortlog;h=refs/heads/cev-freq-adj.v10.fortglx-4.12-time
>
> [2]
> https://git.linaro.org/people/john.stultz/linux.git fortglx/4.12/time
>
> arch/m68k/coldfire/pit.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/m68k/coldfire/pit.c b/arch/m68k/coldfire/pit.c
> index 175553d5b8ed..6c0878018b44 100644
> --- a/arch/m68k/coldfire/pit.c
> +++ b/arch/m68k/coldfire/pit.c
> @@ -149,8 +149,10 @@ void hw_timer_init(irq_handler_t handler)
> cf_pit_clockevent.mult = div_sc(FREQ, NSEC_PER_SEC, 32);
> cf_pit_clockevent.max_delta_ns =
> clockevent_delta2ns(0xFFFF, &cf_pit_clockevent);
> + cf_pit_clockevent.max_delta_ticks = 0xFFFF;
> cf_pit_clockevent.min_delta_ns =
> clockevent_delta2ns(0x3f, &cf_pit_clockevent);
> + cf_pit_clockevent.min_delta_ticks = 0x3f;
> clockevents_register_device(&cf_pit_clockevent);
>
> setup_irq(MCF_IRQ_PIT1, &pit_irq);
>

2017-03-31 02:35:21

by Xuetao Guan

[permalink] [raw]

Subject: Re: [PATCH] unicore32/time: set ->min_delta_ticks and ->max_delta_ticks

> In preparation for making the clockevents core NTP correction aware,
> all clockevent device drivers must set ->min_delta_ticks and
> ->max_delta_ticks rather than ->min_delta_ns and ->max_delta_ns: a
> clockevent device's rate is going to change dynamically and thus, the
> ratio of ns to ticks ceases to stay invariant.
>
> Make the unicore32 arch's clockevent driver initialize these fields
> properly.
>
> This patch alone doesn't introduce any change in functionality as the
> clockevents core still looks exclusively at the (untouched) ->min_delta_ns
> and ->max_delta_ns. As soon as this has changed, a followup patch will
> purge the initialization of ->min_delta_ns and ->max_delta_ns from this
> driver.
>
> Signed-off-by: Nicolai Stange <[email protected]>

Thanks,
Acked-by: Guan Xuetao <[email protected]>

> ---
>
> Notes:
> This prerequisite patch is part of a larger effort to feed NTP
> corrections into the clockevent devices' frequencies and thus
> avoiding their notion of time to diverge from the system's
> one. If you're interested, the current state of the whole series
> can be found at [1].
>
> If you haven't got any objections and these prerequisites get
> merged by 4.12 everywhere, I'll proceed with the remainder of
> this series in 4.13.
>
> Applicable to next-20170324 as well as to John' Stultz tree [2].
>
> [1]
> git://nicst.de/linux.git cev-freq-adj.v10.fortglx-4.12-time
> https://nicst.de/git/?p=linux.git;a=shortlog;h=refs/heads/cev-freq-adj.v10.fortglx-4.12-time
>
> [2]
> https://git.linaro.org/people/john.stultz/linux.git
> fortglx/4.12/time
>
> arch/unicore32/kernel/time.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/unicore32/kernel/time.c b/arch/unicore32/kernel/time.c
> index fceaa673f861..c6b3fa3ee0b6 100644
> --- a/arch/unicore32/kernel/time.c
> +++ b/arch/unicore32/kernel/time.c
> @@ -91,8 +91,10 @@ void __init time_init(void)
>
> ckevt_puv3_osmr0.max_delta_ns =
> clockevent_delta2ns(0x7fffffff, &ckevt_puv3_osmr0);
> + ckevt_puv3_osmr0.max_delta_ticks = 0x7fffffff;
> ckevt_puv3_osmr0.min_delta_ns =
> clockevent_delta2ns(MIN_OSCR_DELTA * 2, &ckevt_puv3_osmr0) + 1;
> + ckevt_puv3_osmr0.min_delta_ticks = MIN_OSCR_DELTA * 2;
> ckevt_puv3_osmr0.cpumask = cpumask_of(0);
>
> setup_irq(IRQ_TIMER0, &puv3_timer_irq);
> --
> 2.12.0
>

2017-03-31 03:03:30

by Michael Ellerman

[permalink] [raw]

Subject: Re: [PATCH] powerpc/time: set ->min_delta_ticks and ->max_delta_ticks

Nicolai Stange <[email protected]> writes:

> In preparation for making the clockevents core NTP correction aware,
> all clockevent device drivers must set ->min_delta_ticks and
> ->max_delta_ticks rather than ->min_delta_ns and ->max_delta_ns: a
> clockevent device's rate is going to change dynamically and thus, the
> ratio of ns to ticks ceases to stay invariant.
>
> Make the powerpc arch's clockevent driver initialize these fields properly.
>
> This patch alone doesn't introduce any change in functionality as the
> clockevents core still looks exclusively at the (untouched) ->min_delta_ns
> and ->max_delta_ns. As soon as this has changed, a followup patch will
> purge the initialization of ->min_delta_ns and ->max_delta_ns from this
> driver.
>
> Signed-off-by: Nicolai Stange <[email protected]>
> ---
>
> Notes:
> This prerequisite patch is part of a larger effort to feed NTP
> corrections into the clockevent devices' frequencies and thus
> avoiding their notion of time to diverge from the system's
> one. If you're interested, the current state of the whole series
> can be found at [1].
>
> If you haven't got any objections and these prerequisites get
> merged by 4.12 everywhere, I'll proceed with the remainder of
> this series in 4.13.
>
> Applicable to next-20170324 as well as to John' Stultz tree [2].
>
> [1]
> git://nicst.de/linux.git cev-freq-adj.v10.fortglx-4.12-time
> https://nicst.de/git/?p=linux.git;a=shortlog;h=refs/heads/cev-freq-adj.v10.fortglx-4.12-time
>
> [2]
> https://git.linaro.org/people/john.stultz/linux.git fortglx/4.12/time
>
> arch/powerpc/kernel/time.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/powerpc/kernel/time.c b/arch/powerpc/kernel/time.c
> index 07b90725855e..2b33cfaac7b8 100644
> --- a/arch/powerpc/kernel/time.c
> +++ b/arch/powerpc/kernel/time.c
> @@ -995,8 +995,10 @@ static void __init init_decrementer_clockevent(void)
>
> decrementer_clockevent.max_delta_ns =
> clockevent_delta2ns(decrementer_max, &decrementer_clockevent);
> + decrementer_clockevent.max_delta_ticks = decrementer_max;
> decrementer_clockevent.min_delta_ns =
> clockevent_delta2ns(2, &decrementer_clockevent);
> + decrementer_clockevent.min_delta_ticks = 2;

Seems to do what it says on the tin.

Acked-by: Michael Ellerman <[email protected]> (powerpc)

cheers

2017-04-01 19:18:58

by David Miller

[permalink] [raw]

Subject: Re: [PATCH] sparc/time: set ->min_delta_ticks and ->max_delta_ticks

From: Nicolai Stange <[email protected]>
Date: Thu, 30 Mar 2017 21:56:47 +0200

> In preparation for making the clockevents core NTP correction aware,
> all clockevent device drivers must set ->min_delta_ticks and
> ->max_delta_ticks rather than ->min_delta_ns and ->max_delta_ns: a
> clockevent device's rate is going to change dynamically and thus, the
> ratio of ns to ticks ceases to stay invariant.
>
> Make the sparc arch's clockevent drivers initialize these fields properly.
>
> This patch alone doesn't introduce any change in functionality as the
> clockevents core still looks exclusively at the (untouched) ->min_delta_ns
> and ->max_delta_ns. As soon as this has changed, a followup patch will
> purge the initialization of ->min_delta_ns and ->max_delta_ns from these
> drivers.
>
> Signed-off-by: Nicolai Stange <[email protected]>

Acked-by: David S. Miller <[email protected]>

2017-04-02 23:42:12

by Rusty Russell

[permalink] [raw]

Subject: Re: [PATCH] x86/lguest/timer: set ->min_delta_ticks and ->max_delta_ticks

Nicolai Stange <[email protected]> writes:
> In preparation for making the clockevents core NTP correction aware,
> all clockevent device drivers must set ->min_delta_ticks and
> ->max_delta_ticks rather than ->min_delta_ns and ->max_delta_ns: a
> clockevent device's rate is going to change dynamically and thus, the
> ratio of ns to ticks ceases to stay invariant.
>
> Make the x86 arch's lguest clockevent driver initialize these fields
> properly.
>
> This patch alone doesn't introduce any change in functionality as the
> clockevents core still looks exclusively at the (untouched) ->min_delta_ns
> and ->max_delta_ns. As soon as this has changed, a followup patch will
> purge the initialization of ->min_delta_ns and ->max_delta_ns from this
> driver.

Acked-by: Rusty Russell <[email protected]>

>
> Signed-off-by: Nicolai Stange <[email protected]>
> ---
>
> Notes:
> This prerequisite patch is part of a larger effort to feed NTP
> corrections into the clockevent devices' frequencies and thus
> avoiding their notion of time to diverge from the system's
> one. If you're interested, the current state of the whole series
> can be found at [1].
>
> If you haven't got any objections and these prerequisites get
> merged by 4.12 everywhere, I'll proceed with the remainder of
> this series in 4.13.
>
> Applicable to next-20170324 as well as to John' Stultz tree [2].
>
> [1]
> git://nicst.de/linux.git cev-freq-adj.v10.fortglx-4.12-time
> https://nicst.de/git/?p=linux.git;a=shortlog;h=refs/heads/cev-freq-adj.v10.fortglx-4.12-time
>
> [2]
> https://git.linaro.org/people/john.stultz/linux.git fortglx/4.12/time
>
> arch/x86/lguest/boot.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/x86/lguest/boot.c b/arch/x86/lguest/boot.c
> index d3289d7e78fa..3e4bf887a246 100644
> --- a/arch/x86/lguest/boot.c
> +++ b/arch/x86/lguest/boot.c
> @@ -994,7 +994,9 @@ static struct clock_event_device lguest_clockevent = {
> .mult = 1,
> .shift = 0,
> .min_delta_ns = LG_CLOCK_MIN_DELTA,
> + .min_delta_ticks = LG_CLOCK_MIN_DELTA,
> .max_delta_ns = LG_CLOCK_MAX_DELTA,
> + .max_delta_ticks = LG_CLOCK_MAX_DELTA,
> };
>
> /*
> --
> 2.12.0

2017-04-03 06:42:39

by Hans-Christian Noren Egtvedt

[permalink] [raw]

Subject: Re: [PATCH] avr32/time: set ->min_delta_ticks and ->max_delta_ticks

Around Thu 30 Mar 2017 21:39:33 +0200 or thereabout, Nicolai Stange wrote:
> In preparation for making the clockevents core NTP correction aware,
> all clockevent device drivers must set ->min_delta_ticks and
> ->max_delta_ticks rather than ->min_delta_ns and ->max_delta_ns: a
> clockevent device's rate is going to change dynamically and thus, the
> ratio of ns to ticks ceases to stay invariant.
>
> Make the avr32 arch's clockevent driver initialize these fields properly.
>
> This patch alone doesn't introduce any change in functionality as the
> clockevents core still looks exclusively at the (untouched) ->min_delta_ns
> and ->max_delta_ns. As soon as this has changed, a followup patch will
> purge the initialization of ->min_delta_ns and ->max_delta_ns from this
> driver.
>
> Signed-off-by: Nicolai Stange <[email protected]>

-1

Please do not spend time on AVR32 architecture. It will be removed in the
next merge window.

<snipp diff>

--
Best regards,
Hans-Christian Noren Egtvedt

2017-04-03 15:49:23

by Richard Kuo

[permalink] [raw]

Subject: Re: [PATCH] hexagon/time: set ->min_delta_ticks and ->max_delta_ticks

On Thu, Mar 30, 2017 at 09:43:32PM +0200, Nicolai Stange wrote:
> In preparation for making the clockevents core NTP correction aware,
> all clockevent device drivers must set ->min_delta_ticks and
> ->max_delta_ticks rather than ->min_delta_ns and ->max_delta_ns: a
> clockevent device's rate is going to change dynamically and thus, the
> ratio of ns to ticks ceases to stay invariant.
>
> Make the hexagon arch's clockevent driver initialize these fields
> properly.
>
> This patch alone doesn't introduce any change in functionality as the
> clockevents core still looks exclusively at the (untouched) ->min_delta_ns
> and ->max_delta_ns. As soon as this has changed, a followup patch will
> purge the initialization of ->min_delta_ns and ->max_delta_ns from this
> driver.
>
> Signed-off-by: Nicolai Stange <[email protected]>
> ---
>
> Notes:
> This prerequisite patch is part of a larger effort to feed NTP
> corrections into the clockevent devices' frequencies and thus
> avoiding their notion of time to diverge from the system's
> one. If you're interested, the current state of the whole series
> can be found at [1].
>
> If you haven't got any objections and these prerequisites get
> merged by 4.12 everywhere, I'll proceed with the remainder of
> this series in 4.13.
>
> Applicable to next-20170324 as well as to John' Stultz tree [2].
>
> [1]
> git://nicst.de/linux.git cev-freq-adj.v10.fortglx-4.12-time
> https://nicst.de/git/?p=linux.git;a=shortlog;h=refs/heads/cev-freq-adj.v10.fortglx-4.12-time
>
> [2]
> https://git.linaro.org/people/john.stultz/linux.git fortglx/4.12/time
>
> arch/hexagon/kernel/time.c | 2 ++
> 1 file changed, 2 insertions(+)

Acked-by: Richard Kuo <[email protected]>

--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

2017-04-06 09:12:02

by Juergen Gross

[permalink] [raw]

Subject: Re: [PATCH] x86/xen/time: set ->min_delta_ticks and ->max_delta_ticks

On 30/03/17 22:06, Nicolai Stange wrote:
> In preparation for making the clockevents core NTP correction aware,
> all clockevent device drivers must set ->min_delta_ticks and
> ->max_delta_ticks rather than ->min_delta_ns and ->max_delta_ns: a
> clockevent device's rate is going to change dynamically and thus, the
> ratio of ns to ticks ceases to stay invariant.
>
> Make the x86 arch's xen clockevent driver initialize these fields properly.
>
> This patch alone doesn't introduce any change in functionality as the
> clockevents core still looks exclusively at the (untouched) ->min_delta_ns
> and ->max_delta_ns. As soon as this has changed, a followup patch will
> purge the initialization of ->min_delta_ns and ->max_delta_ns from this
> driver.
>
> Signed-off-by: Nicolai Stange <[email protected]>

Shall I carry this patch through the Xen tree or will it be processed
via the tip tree? I'm fine with both variants.

Juergen

> ---
>
> Notes:
> This prerequisite patch is part of a larger effort to feed NTP
> corrections into the clockevent devices' frequencies and thus
> avoiding their notion of time to diverge from the system's
> one. If you're interested, the current state of the whole series
> can be found at [1].
>
> If you haven't got any objections and these prerequisites get
> merged by 4.12 everywhere, I'll proceed with the remainder of
> this series in 4.13.
>
> Applicable to next-20170324 as well as to John' Stultz tree [2].
>
> [1]
> git://nicst.de/linux.git cev-freq-adj.v10.fortglx-4.12-time
> https://nicst.de/git/?p=linux.git;a=shortlog;h=refs/heads/cev-freq-adj.v10.fortglx-4.12-time
>
> [2]
> https://git.linaro.org/people/john.stultz/linux.git fortglx/4.12/time
>
> arch/x86/xen/time.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c
> index 1e69956d7852..7a3089285c59 100644
> --- a/arch/x86/xen/time.c
> +++ b/arch/x86/xen/time.c
> @@ -209,7 +209,9 @@ static const struct clock_event_device xen_timerop_clockevent = {
> .features = CLOCK_EVT_FEAT_ONESHOT,
>
> .max_delta_ns = 0xffffffff,
> + .max_delta_ticks = 0xffffffff,
> .min_delta_ns = TIMER_SLOP,
> + .min_delta_ticks = TIMER_SLOP,
>
> .mult = 1,
> .shift = 0,
> @@ -268,7 +270,9 @@ static const struct clock_event_device xen_vcpuop_clockevent = {
> .features = CLOCK_EVT_FEAT_ONESHOT,
>
> .max_delta_ns = 0xffffffff,
> + .max_delta_ticks = 0xffffffff,
> .min_delta_ns = TIMER_SLOP,
> + .min_delta_ticks = TIMER_SLOP,
>
> .mult = 1,
> .shift = 0,
>

2017-04-07 13:14:41

by Daniel Lezcano

[permalink] [raw]

Subject: Re: [PATCH] microblaze/timer: set ->min_delta_ticks and ->max_delta_ticks

On Thu, Mar 30, 2017 at 09:45:28PM +0200, Nicolai Stange wrote:
> In preparation for making the clockevents core NTP correction aware,
> all clockevent device drivers must set ->min_delta_ticks and
> ->max_delta_ticks rather than ->min_delta_ns and ->max_delta_ns: a
> clockevent device's rate is going to change dynamically and thus, the
> ratio of ns to ticks ceases to stay invariant.
>
> Make the microblaze arch's clockevent driver initialize these fields
> properly.
>
> This patch alone doesn't introduce any change in functionality as the
> clockevents core still looks exclusively at the (untouched) ->min_delta_ns
> and ->max_delta_ns. As soon as this has changed, a followup patch will
> purge the initialization of ->min_delta_ns and ->max_delta_ns from this
> driver.
>
> Signed-off-by: Nicolai Stange <[email protected]>
> ---
>
> Notes:
> This prerequisite patch is part of a larger effort to feed NTP
> corrections into the clockevent devices' frequencies and thus
> avoiding their notion of time to diverge from the system's
> one. If you're interested, the current state of the whole series
> can be found at [1].
>
> If you haven't got any objections and these prerequisites get
> merged by 4.12 everywhere, I'll proceed with the remainder of
> this series in 4.13.
>
> Applicable to next-20170324 as well as to John' Stultz tree [2].
>
> [1]
> git://nicst.de/linux.git cev-freq-adj.v10.fortglx-4.12-time
> https://nicst.de/git/?p=linux.git;a=shortlog;h=refs/heads/cev-freq-adj.v10.fortglx-4.12-time
>
> [2]
> https://git.linaro.org/people/john.stultz/linux.git fortglx/4.12/time
>
> arch/microblaze/kernel/timer.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/microblaze/kernel/timer.c b/arch/microblaze/kernel/timer.c
> index 999066192715..545ccd46edb3 100644
> --- a/arch/microblaze/kernel/timer.c
> +++ b/arch/microblaze/kernel/timer.c
> @@ -178,8 +178,10 @@ static __init int xilinx_clockevent_init(void)
> clockevent_xilinx_timer.shift);
> clockevent_xilinx_timer.max_delta_ns =
> clockevent_delta2ns((u32)~0, &clockevent_xilinx_timer);
> + clockevent_xilinx_timer.max_delta_ticks = (u32)~0;

Can you take the opportunity to fix the type (unsigned long) ?

> clockevent_xilinx_timer.min_delta_ns =
> clockevent_delta2ns(1, &clockevent_xilinx_timer);
> + clockevent_xilinx_timer.min_delta_ticks = 1;
> clockevent_xilinx_timer.cpumask = cpumask_of(0);
> clockevents_register_device(&clockevent_xilinx_timer);
>
> --
> 2.12.0
>

--

<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

2017-04-07 13:20:22

by Daniel Lezcano

[permalink] [raw]

Subject: Re: [PATCH] clockevents/drivers/dw_apb: set ->min_delta_ticks and ->max_delta_ticks

On Thu, Mar 30, 2017 at 10:07:49PM +0200, Nicolai Stange wrote:
> In preparation for making the clockevents core NTP correction aware,
> all clockevent device drivers must set ->min_delta_ticks and
> ->max_delta_ticks rather than ->min_delta_ns and ->max_delta_ns: a
> clockevent device's rate is going to change dynamically and thus, the
> ratio of ns to ticks ceases to stay invariant.
>
> Make the dw_apb clockevent driver initialize these fields properly.
>
> This patch alone doesn't introduce any change in functionality as the
> clockevents core still looks exclusively at the (untouched) ->min_delta_ns
> and ->max_delta_ns. As soon as this has changed, a followup patch will
> purge the initialization of ->min_delta_ns and ->max_delta_ns from this
> driver.
>
> Signed-off-by: Nicolai Stange <[email protected]>

Acked-by: Daniel Lezcano <[email protected]>

--

<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

2017-04-07 13:21:10

by Daniel Lezcano

[permalink] [raw]

Subject: Re: [PATCH] clockevents/drivers/metag: set ->min_delta_ticks and ->max_delta_ticks

On Thu, Mar 30, 2017 at 10:08:20PM +0200, Nicolai Stange wrote:
> In preparation for making the clockevents core NTP correction aware,
> all clockevent device drivers must set ->min_delta_ticks and
> ->max_delta_ticks rather than ->min_delta_ns and ->max_delta_ns: a
> clockevent device's rate is going to change dynamically and thus, the
> ratio of ns to ticks ceases to stay invariant.
>
> Make the metag_generic clockevent driver initialize these fields properly.
>
> This patch alone doesn't introduce any change in functionality as the
> clockevents core still looks exclusively at the (untouched) ->min_delta_ns
> and ->max_delta_ns. As soon as this has changed, a followup patch will
> purge the initialization of ->min_delta_ns and ->max_delta_ns from this
> driver.
>
> Signed-off-by: Nicolai Stange <[email protected]>
> ---

Acked-by: Daniel Lezcano <[email protected]>

--

<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

2017-04-07 13:21:50

by Daniel Lezcano

[permalink] [raw]

Subject: Re: [PATCH] x86/numachip timer: set ->min_delta_ticks and ->max_delta_ticks

On Thu, Mar 30, 2017 at 10:08:49PM +0200, Nicolai Stange wrote:
> In preparation for making the clockevents core NTP correction aware,
> all clockevent device drivers must set ->min_delta_ticks and
> ->max_delta_ticks rather than ->min_delta_ns and ->max_delta_ns: a
> clockevent device's rate is going to change dynamically and thus, the
> ratio of ns to ticks ceases to stay invariant.
>
> Make the numachip clockevent driver initialize these fields properly.
>
> This patch alone doesn't introduce any change in functionality as the
> clockevents core still looks exclusively at the (untouched) ->min_delta_ns
> and ->max_delta_ns. As soon as this has changed, a followup patch will
> purge the initialization of ->min_delta_ns and ->max_delta_ns from this
> driver.
>
> Signed-off-by: Nicolai Stange <[email protected]>
> ---

Acked-by: Daniel Lezcano <[email protected]>

--

<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

2017-04-07 13:22:31

by Daniel Lezcano

[permalink] [raw]

Subject: Re: [PATCH] clockevents/drivers/sh_cmt: set ->min_delta_ticks and ->max_delta_ticks

On Thu, Mar 30, 2017 at 10:09:12PM +0200, Nicolai Stange wrote:
> In preparation for making the clockevents core NTP correction aware,
> all clockevent device drivers must set ->min_delta_ticks and
> ->max_delta_ticks rather than ->min_delta_ns and ->max_delta_ns: a
> clockevent device's rate is going to change dynamically and thus, the
> ratio of ns to ticks ceases to stay invariant.
>
> Make the sh_cmt clockevent driver initialize these fields properly.
>
> This patch alone doesn't introduce any change in functionality as the
> clockevents core still looks exclusively at the (untouched) ->min_delta_ns
> and ->max_delta_ns. As soon as this has changed, a followup patch will
> purge the initialization of ->min_delta_ns and ->max_delta_ns from this
> driver.
>
> Signed-off-by: Nicolai Stange <[email protected]>
> ---

Acked-by: Daniel Lezcano <[email protected]>

--

<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

2017-04-07 13:23:29

by Daniel Lezcano

[permalink] [raw]

Subject: Re: [PATCH] clockevents/drivers/atlas7: set ->min_delta_ticks and ->max_delta_ticks

On Thu, Mar 30, 2017 at 10:10:21PM +0200, Nicolai Stange wrote:
> In preparation for making the clockevents core NTP correction aware,
> all clockevent device drivers must set ->min_delta_ticks and
> ->max_delta_ticks rather than ->min_delta_ns and ->max_delta_ns: a
> clockevent device's rate is going to change dynamically and thus, the
> ratio of ns to ticks ceases to stay invariant.
>
> Make the timer-atlas7 clockevent driver initialize these fields properly.
>
> This patch alone doesn't introduce any change in functionality as the
> clockevents core still looks exclusively at the (untouched) ->min_delta_ns
> and ->max_delta_ns. As soon as this has changed, a followup patch will
> purge the initialization of ->min_delta_ns and ->max_delta_ns from this
> driver.
>
> Signed-off-by: Nicolai Stange <[email protected]>
> ---

Acked-by: Daniel Lezcano <[email protected]>

--

<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

2017-04-11 05:09:21

by Juergen Gross

[permalink] [raw]

Subject: Re: [PATCH] x86/xen/time: set ->min_delta_ticks and ->max_delta_ticks

2017-04-12 20:10:45

by Ralf Baechle

[permalink] [raw]

Subject: Re: [PATCH] MIPS: clockevent drivers: set ->min_delta_ticks and ->max_delta_ticks

On Thu, Mar 30, 2017 at 09:47:32PM +0200, Nicolai Stange wrote:

> In preparation for making the clockevents core NTP correction aware,
> all clockevent device drivers must set ->min_delta_ticks and
> ->max_delta_ticks rather than ->min_delta_ns and ->max_delta_ns: a
> clockevent device's rate is going to change dynamically and thus, the
> ratio of ns to ticks ceases to stay invariant.
>
> Make the MIPS arch's clockevent drivers initialize these fields properly.
>
> This patch alone doesn't introduce any change in functionality as the
> clockevents core still looks exclusively at the (untouched) ->min_delta_ns
> and ->max_delta_ns. As soon as this has changed, a followup patch will
> purge the initialization of ->min_delta_ns and ->max_delta_ns from these
> drivers.
>
> Signed-off-by: Nicolai Stange <[email protected]>

Acked-by: Ralf Baechle <[email protected]>

Feel free to push this to Linus.

Ralf

2017-04-16 02:47:18

by Nicolai Stange

[permalink] [raw]

Subject: Re: [PATCH] microblaze/timer: set ->min_delta_ticks and ->max_delta_ticks

Hello Daniel,

On Fri, Apr 07 2017, Daniel Lezcano wrote:

> On Thu, Mar 30, 2017 at 09:45:28PM +0200, Nicolai Stange wrote:
>> diff --git a/arch/microblaze/kernel/timer.c b/arch/microblaze/kernel/timer.c
>> index 999066192715..545ccd46edb3 100644
>> --- a/arch/microblaze/kernel/timer.c
>> +++ b/arch/microblaze/kernel/timer.c
>> @@ -178,8 +178,10 @@ static __init int xilinx_clockevent_init(void)
>> clockevent_xilinx_timer.shift);
>> clockevent_xilinx_timer.max_delta_ns =
>> clockevent_delta2ns((u32)~0, &clockevent_xilinx_timer);
>> + clockevent_xilinx_timer.max_delta_ticks = (u32)~0;
>
> Can you take the opportunity to fix the type (unsigned long) ?

Hmm, I personally think that it'd be better to leave the u32 there as it
corresponds to the hardware's counter width?

clockevent_delta2ns()' latch argument has been of type unsigned long
from the beginning and this might indicate that at least this
driver's original author followed this line of reasoning...

OTOH, I think that u32 is equivalent to unsigned long on microblaze, so
it doesn't matter much.

Does the above convince you or do you still want the

- clockevent_xilinx_timer.max_delta_ticks = (u32)~0;
+ clockevent_xilinx_timer.max_delta_ticks = ~0UL;

change?

Thanks,

Nicolai

2017-04-16 09:46:52

by Daniel Lezcano

[permalink] [raw]

Subject: Re: [PATCH] microblaze/timer: set ->min_delta_ticks and ->max_delta_ticks

On Sun, Apr 16, 2017 at 04:47:11AM +0200, Nicolai Stange wrote:
> Hello Daniel,
>
> On Fri, Apr 07 2017, Daniel Lezcano wrote:
>
> > On Thu, Mar 30, 2017 at 09:45:28PM +0200, Nicolai Stange wrote:
> >> diff --git a/arch/microblaze/kernel/timer.c b/arch/microblaze/kernel/timer.c
> >> index 999066192715..545ccd46edb3 100644
> >> --- a/arch/microblaze/kernel/timer.c
> >> +++ b/arch/microblaze/kernel/timer.c
> >> @@ -178,8 +178,10 @@ static __init int xilinx_clockevent_init(void)
> >> clockevent_xilinx_timer.shift);
> >> clockevent_xilinx_timer.max_delta_ns =
> >> clockevent_delta2ns((u32)~0, &clockevent_xilinx_timer);
> >> + clockevent_xilinx_timer.max_delta_ticks = (u32)~0;
> >
> > Can you take the opportunity to fix the type (unsigned long) ?
>
> Hmm, I personally think that it'd be better to leave the u32 there as it
> corresponds to the hardware's counter width?
>
> clockevent_delta2ns()' latch argument has been of type unsigned long
> from the beginning and this might indicate that at least this
> driver's original author followed this line of reasoning...
>
> OTOH, I think that u32 is equivalent to unsigned long on microblaze, so
> it doesn't matter much.
>
> Does the above convince you or do you still want the

Yeah, I was nitpicking.

Acked-by: Daniel Lezcano <[email protected]>

--

<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog