Hi John,
(CC'ing Morimoto-san)
On Tuesday 06 Sep 2016 15:17:58 John Stultz wrote:
> On Tue, Aug 30, 2016 at 2:23 AM, Laurent Pinchart wrote:
> > Hi John,
> >
> > Thank you for the patches.
>
> Thanks so much for the review! I'm reworking the patchset now and will
> be sending out an updated set soon!
>
> >> This patchset, along with the i2s driver and dts changes allows
> >> HDMI audio to work on the HiKey board.
> >
> > Where are the dts changes ?
>
> Here's what I'm using to get it working:
> https://git.linaro.org/people/john.stultz/android-dev.git/commitdiff/1024cb4
> 85b6f00a7e355ce60425f04a584481148
Thank you.
We need to standardize DT bindings for HDMI sound output. Morimoto-san, could
you have a look at the DT bindings proposal for HDMI sound output with the
ADV7511, and comment on whether it matches the approach you've taken for HDMI
sound output on R-Car Gen3 ?
> But again, that's dependent on the k3dma driver (queued), the hi6210
> i2s driver (still being reworked), and adv7511 audio (this patchset).
--
Regards,
Laurent Pinchart
Hi Laurent, John,
> > Here's what I'm using to get it working:
> > https://git.linaro.org/people/john.stultz/android-dev.git/commitdiff/1024cb4
> > 85b6f00a7e355ce60425f04a584481148
>
> Thank you.
>
> We need to standardize DT bindings for HDMI sound output. Morimoto-san, could
> you have a look at the DT bindings proposal for HDMI sound output with the
> ADV7511, and comment on whether it matches the approach you've taken for HDMI
> sound output on R-Car Gen3 ?
Above patch is using normal simple-card style for HDMI sound, but as Laurent
said we want to use same DT style for HDMI video and sound (= OF graph style).
Fortunately, I posted patch-set for OF graph support on sound card yesterday.
Can you check this ?
http://www.spinics.net/lists/devicetree/msg146131.html
The points are
- sound can use OF graph style DT
- sound-card DT is no longer needed
- it needs type = "sound" property
patch-set [0/23] is this
http://www.spinics.net/lists/devicetree/msg146113.html
On Tue, Oct 18, 2016 at 5:26 PM, Kuninori Morimoto
<[email protected]> wrote:
>
>> > Here's what I'm using to get it working:
>> > https://git.linaro.org/people/john.stultz/android-dev.git/commitdiff/1024cb4
>> > 85b6f00a7e355ce60425f04a584481148
>>
>> Thank you.
>>
>> We need to standardize DT bindings for HDMI sound output. Morimoto-san, could
>> you have a look at the DT bindings proposal for HDMI sound output with the
>> ADV7511, and comment on whether it matches the approach you've taken for HDMI
>> sound output on R-Car Gen3 ?
>
> Above patch is using normal simple-card style for HDMI sound, but as Laurent
> said we want to use same DT style for HDMI video and sound (= OF graph style).
> Fortunately, I posted patch-set for OF graph support on sound card yesterday.
> Can you check this ?
> http://www.spinics.net/lists/devicetree/msg146131.html
> The points are
> - sound can use OF graph style DT
> - sound-card DT is no longer needed
> - it needs type = "sound" property
>
> patch-set [0/23] is this
> http://www.spinics.net/lists/devicetree/msg146113.html
Thanks for the pointers! If I understand this correctly, the OF graph
simple-card method would replace my current simple-card dts usage for
hikey? Other then just having another out-of-tree patchset to track,
I don't have any objection to trying to use the OF graph simple-card
method in the hikey dts (though I suspect I'll have to pester you for
help when I give it a shot).
Laurent: So this seems to be mostly just a "which implementation do we
use" question for the hikey dts, and it seems like the adv7511 audio
driver I'm submitting here has any ties to either the graph or normal
simple card method. Is that correct? Are there any changes to the
adv7511 audio support patch you'd like to see or should I just
resubmit it?
thanks
-john
Hi John
> > Above patch is using normal simple-card style for HDMI sound, but as Laurent
> > said we want to use same DT style for HDMI video and sound (= OF graph style).
> > Fortunately, I posted patch-set for OF graph support on sound card yesterday.
> > Can you check this ?
> > http://www.spinics.net/lists/devicetree/msg146131.html
> > The points are
> > - sound can use OF graph style DT
> > - sound-card DT is no longer needed
> > - it needs type = "sound" property
> >
> > patch-set [0/23] is this
> > http://www.spinics.net/lists/devicetree/msg146113.html
>
> Thanks for the pointers! If I understand this correctly, the OF graph
> simple-card method would replace my current simple-card dts usage for
> hikey? Other then just having another out-of-tree patchset to track,
> I don't have any objection to trying to use the OF graph simple-card
> method in the hikey dts (though I suspect I'll have to pester you for
> help when I give it a shot).
I posted v2 patchset OF graph simple-card which doesn't have "type" property.
Anyway, if you use OF graph simple-card, your "CPU" side driver need to
call asoc_simple_card_try_to_probe_graph_card() to probing it.
And this is not 100% mandatory, but your CPU and/or Codec driver
want to adjust OF graph style for parsing. The position is like this
simple-card :: dai-link <-> OF graph simple-card :: port/endpoint