2024-01-11 06:43:55

by XueBing Chen

Subject: [PATCH] drm: Clean up errors in drm_dp_mst_topology.h

Fix the following errors reported by checkpatch:

ERROR: space prohibited before open square bracket '['

Signed-off-by: chenxuebing <[email protected]>
---
drivers/gpu/drm/display/drm_dp_mst_topology.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu/drm/display/drm_dp_mst_topology.c
index bd6c24d4213c..a4a24ec11b80 100644
--- a/drivers/gpu/drm/display/drm_dp_mst_topology.c
+++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c
@@ -100,7 +100,7 @@ static bool drm_dp_mst_port_downstream_of_branch(struct drm_dp_mst_port *port,

#define DBG_PREFIX "[dp_mst]"

-#define DP_STR(x) [DP_ ## x] = #x
+#define DP_STR(x)[DP_ ## x] = #x

static const char *drm_dp_mst_req_type_str(u8 req_type)
{
@@ -131,7 +131,7 @@ static const char *drm_dp_mst_req_type_str(u8 req_type)
}

#undef DP_STR
-#define DP_STR(x) [DP_NAK_ ## x] = #x
+#define DP_STR(x)[DP_NAK_ ## x] = #x

static const char *drm_dp_mst_nak_reason_str(u8 nak_reason)
{
@@ -156,7 +156,7 @@ static const char *drm_dp_mst_nak_reason_str(u8 nak_reason)
}

#undef DP_STR
-#define DP_STR(x) [DRM_DP_SIDEBAND_TX_ ## x] = #x
+#define DP_STR(x)[DRM_DP_SIDEBAND_TX_ ## x] = #x

static const char *drm_dp_mst_sideband_tx_state_str(int state)
{
--
2.17.1

2024-01-11 09:59:53

by Jani Nikula

Subject: Re: [PATCH] drm: Clean up errors in drm_dp_mst_topology.h

On Thu, 11 Jan 2024, chenxuebing <[email protected]> wrote:
> Fix the following errors reported by checkpatch:
>
> ERROR: space prohibited before open square bracket '['

Same here, checkpatch just isn't clever enough to realize it's within a
macro.

BR,
Jani.

>
> Signed-off-by: chenxuebing <[email protected]>
> ---
> drivers/gpu/drm/display/drm_dp_mst_topology.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu/drm/display/drm_dp_mst_topology.c
> index bd6c24d4213c..a4a24ec11b80 100644
> --- a/drivers/gpu/drm/display/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c
> @@ -100,7 +100,7 @@ static bool drm_dp_mst_port_downstream_of_branch(struct drm_dp_mst_port *port,
>
> #define DBG_PREFIX "[dp_mst]"
>
> -#define DP_STR(x) [DP_ ## x] = #x
> +#define DP_STR(x)[DP_ ## x] = #x
>
> static const char *drm_dp_mst_req_type_str(u8 req_type)
> {
> @@ -131,7 +131,7 @@ static const char *drm_dp_mst_req_type_str(u8 req_type)
> }
>
> #undef DP_STR
> -#define DP_STR(x) [DP_NAK_ ## x] = #x
> +#define DP_STR(x)[DP_NAK_ ## x] = #x
>
> static const char *drm_dp_mst_nak_reason_str(u8 nak_reason)
> {
> @@ -156,7 +156,7 @@ static const char *drm_dp_mst_nak_reason_str(u8 nak_reason)
> }
>
> #undef DP_STR
> -#define DP_STR(x) [DRM_DP_SIDEBAND_TX_ ## x] = #x
> +#define DP_STR(x)[DRM_DP_SIDEBAND_TX_ ## x] = #x
>
> static const char *drm_dp_mst_sideband_tx_state_str(int state)
> {

--
Jani Nikula, Intel