2022-12-17 17:30:50

by Florian Weimer

Subject: [PATCH] kmod: configure.ac: In _Noreturn check, include <stdlib.h> for exit

Otherwise, an implicit functiona declaration is used, causing
a C99 compatibility issue.

Signed-off-by: Florian Weimer <[email protected]>

---
configure.ac | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 6989e93..12e0518 100644
--- a/configure.ac
+++ b/configure.ac
@@ -68,7 +68,8 @@ AC_COMPILE_IFELSE(

AC_MSG_CHECKING([whether _Noreturn is supported])
AC_COMPILE_IFELSE(
- [AC_LANG_SOURCE([[_Noreturn int foo(void) { exit(0); }]])],
+ [AC_LANG_SOURCE([[#include <stdlib.h>
+ _Noreturn int foo(void) { exit(0); }]])],
[AC_DEFINE([HAVE_NORETURN], [1], [Define if _Noreturn is available])
AC_MSG_RESULT([yes])],
[AC_MSG_RESULT([no])])

base-commit: 6c5f2f13689e6a4668f87171752d7818bed4b602

2022-12-26 18:17:57

by Lucas De Marchi

Subject: Re: [PATCH] kmod: configure.ac: In _Noreturn check, include <stdlib.h> for exit

On Sat, Dec 17, 2022 at 05:52:34PM +0100, Florian Weimer wrote:
>Otherwise, an implicit functiona declaration is used, causing
>a C99 compatibility issue.
>
>Signed-off-by: Florian Weimer <[email protected]>

applied, thanks

Lucas De Marchi

>
>---
> configure.ac | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/configure.ac b/configure.ac
>index 6989e93..12e0518 100644
>--- a/configure.ac
>+++ b/configure.ac
>@@ -68,7 +68,8 @@ AC_COMPILE_IFELSE(
>
> AC_MSG_CHECKING([whether _Noreturn is supported])
> AC_COMPILE_IFELSE(
>- [AC_LANG_SOURCE([[_Noreturn int foo(void) { exit(0); }]])],
>+ [AC_LANG_SOURCE([[#include <stdlib.h>
>+ _Noreturn int foo(void) { exit(0); }]])],
> [AC_DEFINE([HAVE_NORETURN], [1], [Define if _Noreturn is available])
> AC_MSG_RESULT([yes])],
> [AC_MSG_RESULT([no])])
>
>base-commit: 6c5f2f13689e6a4668f87171752d7818bed4b602
>