2017-09-05 07:10:48

by Rodolfo Giometti

[permalink] [raw]
Subject: Re: Support for BQ28Z610 Battery Monitor IC

On 04/09/2017 15:53, [email protected] wrote:
> Dear Rodolfo Giometti,
>
> As discussed please find attached patch.
> Please let me know if you need more details.

It looks OK to me... however:

- rewrite the patch's title as "power bq27xxx_battery: add support for BQ28Z610
battery monitor IC"

- align the "=" characters as follow:

+ [BQ28Z610] = {
+ [BQ27XXX_REG_CTRL] = 0x00,
+ [BQ27XXX_REG_TEMP] = 0x06,
+ [BQ27XXX_REG_INT_TEMP] = INVALID_REG_ADDR,
+ [BQ27XXX_REG_VOLT] = 0x08,
...

Then send the patch to the mail list or maintainers ad described into the
MAINTAINERS file and adding me in Cc.

Good job! :-)

Ciao,

Rodolfo

--

HCE Engineering e-mail: [email protected]
GNU/Linux Solutions [email protected]
Linux Device Driver [email protected]
Embedded Systems phone: +39 349 2432127
UNIX programming skype: rodolfo.giometti
Cosino Project - the quick prototyping embedded system - http://www.cosino.it
Freelance ICT Italia - Consulente ICT Italia - http://www.consulenti-ict.it