2023-07-26 19:06:58

by Takashi Iwai

Subject: [PATCH] tpm/tpm_tis: Disable interrupts for TUXEDO InfinityBook S 15/17 Gen7

TUXEDO InfinityBook S 15/17 Gen7 suffers from an IRQ problem on
tpm_tis like a few other laptops. Add an entry for the workaround.

Cc: [email protected]
Fixes: e644b2f498d2 ("tpm, tpm_tis: Enable interrupt test")
Link: https://bugzilla.suse.com/show_bug.cgi?id=1213645
Signed-off-by: Takashi Iwai <[email protected]>
---
drivers/char/tpm/tpm_tis.c | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
index cc42cf3de960..a98773ac2e55 100644
--- a/drivers/char/tpm/tpm_tis.c
+++ b/drivers/char/tpm/tpm_tis.c
@@ -162,6 +162,14 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = {
DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad L590"),
},
},
+ {
+ .callback = tpm_tis_disable_irq,
+ .ident = "TUXEDO InfinityBook S 15/17 Gen7",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "TUXEDO InfinityBook S 15/17 Gen7"),
+ },
+ },
{
.callback = tpm_tis_disable_irq,
.ident = "UPX-TGL",
--
2.35.3

2023-07-28 19:38:34

by Jarkko Sakkinen

Subject: Re: [PATCH] tpm/tpm_tis: Disable interrupts for TUXEDO InfinityBook S 15/17 Gen7

On Wed Jul 26, 2023 at 6:00 PM UTC, Takashi Iwai wrote:
> TUXEDO InfinityBook S 15/17 Gen7 suffers from an IRQ problem on
> tpm_tis like a few other laptops. Add an entry for the workaround.
>
> Cc: [email protected]
> Fixes: e644b2f498d2 ("tpm, tpm_tis: Enable interrupt test")
> Link: https://bugzilla.suse.com/show_bug.cgi?id=1213645
> Signed-off-by: Takashi Iwai <[email protected]>
> ---
> drivers/char/tpm/tpm_tis.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
> index cc42cf3de960..a98773ac2e55 100644
> --- a/drivers/char/tpm/tpm_tis.c
> +++ b/drivers/char/tpm/tpm_tis.c
> @@ -162,6 +162,14 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = {
> DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad L590"),
> },
> },
> + {
> + .callback = tpm_tis_disable_irq,
> + .ident = "TUXEDO InfinityBook S 15/17 Gen7",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "TUXEDO InfinityBook S 15/17 Gen7"),
> + },
> + },
> {
> .callback = tpm_tis_disable_irq,
> .ident = "UPX-TGL",
> --
> 2.35.3

Hi does this occur with the latest linux-next and/or v6.5-rc3?

BR, Jarkko

2023-07-29 07:53:36

by Takashi Iwai

Subject: Re: [PATCH] tpm/tpm_tis: Disable interrupts for TUXEDO InfinityBook S 15/17 Gen7

On Fri, 28 Jul 2023 21:24:30 +0200,
Jarkko Sakkinen wrote:
>
> On Wed Jul 26, 2023 at 6:00 PM UTC, Takashi Iwai wrote:
> > TUXEDO InfinityBook S 15/17 Gen7 suffers from an IRQ problem on
> > tpm_tis like a few other laptops. Add an entry for the workaround.
> >
> > Cc: [email protected]
> > Fixes: e644b2f498d2 ("tpm, tpm_tis: Enable interrupt test")
> > Link: https://bugzilla.suse.com/show_bug.cgi?id=1213645
> > Signed-off-by: Takashi Iwai <[email protected]>
> > ---
> > drivers/char/tpm/tpm_tis.c | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
> > index cc42cf3de960..a98773ac2e55 100644
> > --- a/drivers/char/tpm/tpm_tis.c
> > +++ b/drivers/char/tpm/tpm_tis.c
> > @@ -162,6 +162,14 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = {
> > DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad L590"),
> > },
> > },
> > + {
> > + .callback = tpm_tis_disable_irq,
> > + .ident = "TUXEDO InfinityBook S 15/17 Gen7",
> > + .matches = {
> > + DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"),
> > + DMI_MATCH(DMI_PRODUCT_NAME, "TUXEDO InfinityBook S 15/17 Gen7"),
> > + },
> > + },
> > {
> > .callback = tpm_tis_disable_irq,
> > .ident = "UPX-TGL",
> > --
> > 2.35.3
>
> Hi does this occur with the latest linux-next and/or v6.5-rc3?

Not tested yet, but do you have any relevant fix except for the commit
481c2d14627d ("tpm,tpm_tis: Disable interrupts after 1000 unhandled
IRQs")? That commit was already tested, at least.


thanks,

Takashi

2023-07-29 10:28:02

by Takashi Iwai

Subject: Re: [PATCH] tpm/tpm_tis: Disable interrupts for TUXEDO InfinityBook S 15/17 Gen7

On Sat, 29 Jul 2023 09:06:26 +0200,
Takashi Iwai wrote:
>
> On Fri, 28 Jul 2023 21:24:30 +0200,
> Jarkko Sakkinen wrote:
> >
> > On Wed Jul 26, 2023 at 6:00 PM UTC, Takashi Iwai wrote:
> > > TUXEDO InfinityBook S 15/17 Gen7 suffers from an IRQ problem on
> > > tpm_tis like a few other laptops. Add an entry for the workaround.
> > >
> > > Cc: [email protected]
> > > Fixes: e644b2f498d2 ("tpm, tpm_tis: Enable interrupt test")
> > > Link: https://bugzilla.suse.com/show_bug.cgi?id=1213645
> > > Signed-off-by: Takashi Iwai <[email protected]>
> > > ---
> > > drivers/char/tpm/tpm_tis.c | 8 ++++++++
> > > 1 file changed, 8 insertions(+)
> > >
> > > diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
> > > index cc42cf3de960..a98773ac2e55 100644
> > > --- a/drivers/char/tpm/tpm_tis.c
> > > +++ b/drivers/char/tpm/tpm_tis.c
> > > @@ -162,6 +162,14 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = {
> > > DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad L590"),
> > > },
> > > },
> > > + {
> > > + .callback = tpm_tis_disable_irq,
> > > + .ident = "TUXEDO InfinityBook S 15/17 Gen7",
> > > + .matches = {
> > > + DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"),
> > > + DMI_MATCH(DMI_PRODUCT_NAME, "TUXEDO InfinityBook S 15/17 Gen7"),
> > > + },
> > > + },
> > > {
> > > .callback = tpm_tis_disable_irq,
> > > .ident = "UPX-TGL",
> > > --
> > > 2.35.3
> >
> > Hi does this occur with the latest linux-next and/or v6.5-rc3?
>
> Not tested yet, but do you have any relevant fix except for the commit
> 481c2d14627d ("tpm,tpm_tis: Disable interrupts after 1000 unhandled
> IRQs")? That commit was already tested, at least.

And now it's confirmed that the problem persists with 6.5-rc3.


thanks,

Takashi

2023-07-31 11:56:08

by Jarkko Sakkinen

Subject: Re: [PATCH] tpm/tpm_tis: Disable interrupts for TUXEDO InfinityBook S 15/17 Gen7

On Sat Jul 29, 2023 at 7:06 AM UTC, Takashi Iwai wrote:
> On Fri, 28 Jul 2023 21:24:30 +0200,
> Jarkko Sakkinen wrote:
> >
> > On Wed Jul 26, 2023 at 6:00 PM UTC, Takashi Iwai wrote:
> > > TUXEDO InfinityBook S 15/17 Gen7 suffers from an IRQ problem on
> > > tpm_tis like a few other laptops. Add an entry for the workaround.
> > >
> > > Cc: [email protected]
> > > Fixes: e644b2f498d2 ("tpm, tpm_tis: Enable interrupt test")
> > > Link: https://bugzilla.suse.com/show_bug.cgi?id=1213645
> > > Signed-off-by: Takashi Iwai <[email protected]>
> > > ---
> > > drivers/char/tpm/tpm_tis.c | 8 ++++++++
> > > 1 file changed, 8 insertions(+)
> > >
> > > diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
> > > index cc42cf3de960..a98773ac2e55 100644
> > > --- a/drivers/char/tpm/tpm_tis.c
> > > +++ b/drivers/char/tpm/tpm_tis.c
> > > @@ -162,6 +162,14 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = {
> > > DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad L590"),
> > > },
> > > },
> > > + {
> > > + .callback = tpm_tis_disable_irq,
> > > + .ident = "TUXEDO InfinityBook S 15/17 Gen7",
> > > + .matches = {
> > > + DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"),
> > > + DMI_MATCH(DMI_PRODUCT_NAME, "TUXEDO InfinityBook S 15/17 Gen7"),
> > > + },
> > > + },
> > > {
> > > .callback = tpm_tis_disable_irq,
> > > .ident = "UPX-TGL",
> > > --
> > > 2.35.3
> >
> > Hi does this occur with the latest linux-next and/or v6.5-rc3?
>
> Not tested yet, but do you have any relevant fix except for the commit
> 481c2d14627d ("tpm,tpm_tis: Disable interrupts after 1000 unhandled
> IRQs")? That commit was already tested, at least.

OK, I will pick this, thank you.

Reviewed-by: Jarkko Sakkinen <[email protected]>

BR, Jarkko