2018-02-27 11:54:43

by Bassem BOUBAKER

Subject: [PATCH] cdc_ether: flag the Cinterion PLS8 modem by gemalto as WWAN

The Cinterion PL8 is an LTE modem with 2 possible WWAN interfaces.

The modem is controlled via AT commands through the exposed TTYs.

AT^SWWAN write command can be used to activate or deactivate a WWAN
connection for a PDP context defined with AT+CGDCONT. UE supports
two WWAN adapter. Both WWAN adapters can be activated a the same time

Signed-off-by: Bassem Boubaker <[email protected]>
---
drivers/net/usb/cdc_ether.c | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c
index 05dca3e..65621fe 100644
--- a/drivers/net/usb/cdc_ether.c
+++ b/drivers/net/usb/cdc_ether.c
@@ -562,6 +562,7 @@ static const struct driver_info wwan_info = {
#define MICROSOFT_VENDOR_ID 0x045e
#define UBLOX_VENDOR_ID 0x1546
#define TPLINK_VENDOR_ID 0x2357
+#define GEMALTO_VENDOR_ID 0x1e2d

static const struct usb_device_id products[] = {
/* BLACKLIST !!
@@ -896,6 +897,12 @@ static const struct usb_device_id products[] = {
USB_CDC_PROTO_NONE),
.driver_info = (unsigned long)&wwan_info,
}, {
+ /* Cinterion PLS8 modem by GEMALTO */
+ USB_DEVICE_AND_INTERFACE_INFO(GEMALTO_VENDOR_ID, 0x0061, USB_CLASS_COMM,
+ USB_CDC_SUBCLASS_ETHERNET,
+ USB_CDC_PROTO_NONE),
+ .driver_info = (unsigned long)&wwan_info,
+}, {
USB_INTERFACE_INFO(USB_CLASS_COMM, USB_CDC_SUBCLASS_ETHERNET,
USB_CDC_PROTO_NONE),
.driver_info = (unsigned long) &cdc_info,
--
2.7.4

2018-02-27 12:32:21

by Bjørn Mork

Subject: Re: [PATCH] cdc_ether: flag the Cinterion PLS8 modem by gemalto as WWAN

Bassem Boubaker <[email protected]> writes:

> +#define GEMALTO_VENDOR_ID 0x1e2d

This is defined as CINTERION_VENDOR_ID in drivers/usb/serial/option.c.

I have no idea which defintion is most correct, but I believe the macros
should be kept identical whatever you decide. Anything else is just
unnecessarily confusing.

IMHO the company name tracking macros have grown beyond useful a long
time ago. They just make it harder to grep for the IDs without adding
any useful information whatsoever. And because you have cases like this
where the same number end up having different names, they sometimes hide
information which a plain number would have revealed.



Bjørn

2018-02-27 12:45:01

by Oliver Neukum

Subject: Re: [PATCH] cdc_ether: flag the Cinterion PLS8 modem by gemalto as WWAN

Am Dienstag, den 27.02.2018, 13:29 +0100 schrieb Bjørn Mork :
> Bassem Boubaker <[email protected]> writes:
>
> >
> > +#define GEMALTO_VENDOR_ID 0x1e2d
>
> This is defined as CINTERION_VENDOR_ID in drivers/usb/serial/option.c.
>
> I have no idea which defintion is most correct, but I believe the macros
> should be kept identical whatever you decide. Anything else is just
> unnecessarily confusing.
>
> IMHO the company name tracking macros have grown beyond useful a long
> time ago. They just make it harder to grep for the IDs without adding
> any useful information whatsoever. And because you have cases like this
> where the same number end up having different names, they sometimes hide
> information which a plain number would have revealed.

Hi,

I concur. Could you redo the patch and just use a plain number?

Regards
Oliver

2018-02-27 13:06:59

by Bassem BOUBAKER

Subject: [PATCH] cdc_ether: flag the Cinterion PLS8 modem by gemalto as WWAN

The Cinterion PL8 is an LTE modem with 2 possible WWAN interfaces.

The modem is controlled via AT commands through the exposed TTYs.

AT^SWWAN write command can be used to activate or deactivate a WWAN
connection for a PDP context defined with AT+CGDCONT. UE supports
two WWAN adapter. Both WWAN adapters can be activated a the same time

Signed-off-by: Bassem Boubaker <[email protected]>
---
drivers/net/usb/cdc_ether.c | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c
index 05dca3e..fff4b13 100644
--- a/drivers/net/usb/cdc_ether.c
+++ b/drivers/net/usb/cdc_ether.c
@@ -896,6 +896,12 @@ static const struct usb_device_id products[] = {
USB_CDC_PROTO_NONE),
.driver_info = (unsigned long)&wwan_info,
}, {
+ /* Cinterion PLS8 modem by GEMALTO */
+ USB_DEVICE_AND_INTERFACE_INFO(0x1e2d, 0x0061, USB_CLASS_COMM,
+ USB_CDC_SUBCLASS_ETHERNET,
+ USB_CDC_PROTO_NONE),
+ .driver_info = (unsigned long)&wwan_info,
+}, {
USB_INTERFACE_INFO(USB_CLASS_COMM, USB_CDC_SUBCLASS_ETHERNET,
USB_CDC_PROTO_NONE),
.driver_info = (unsigned long) &cdc_info,
--
2.7.4

2018-02-27 13:18:19

by Oliver Neukum

Subject: Re: [PATCH] cdc_ether: flag the Cinterion PLS8 modem by gemalto as WWAN

Am Dienstag, den 27.02.2018, 14:04 +0100 schrieb Bassem Boubaker:
>     The Cinterion PL8 is an LTE modem with 2 possible WWAN interfaces.
>
>     The modem is  controlled via AT commands through the exposed TTYs.
>
>     AT^SWWAN write command can be used to activate or deactivate a WWAN
>     connection for a PDP context defined with AT+CGDCONT. UE supports
>     two WWAN adapter. Both WWAN adapters can be activated a the same time
>
> Signed-off-by: Bassem Boubaker <[email protected]>
Acked-by: Oliver Neukum <[email protected]>

2018-02-27 19:45:55

by David Miller

Subject: Re: [PATCH] cdc_ether: flag the Cinterion PLS8 modem by gemalto as WWAN

From: Bassem Boubaker <[email protected]>
Date: Tue, 27 Feb 2018 14:04:44 +0100

> The Cinterion PL8 is an LTE modem with 2 possible WWAN interfaces.
>
> The modem is controlled via AT commands through the exposed TTYs.
>
> AT^SWWAN write command can be used to activate or deactivate a WWAN
> connection for a PDP context defined with AT+CGDCONT. UE supports
> two WWAN adapter. Both WWAN adapters can be activated a the same time
>
> Signed-off-by: Bassem Boubaker <[email protected]>

Applied, thanks.