2022-11-16 14:29:32

by Anastasia Belova

Subject: [PATCH] cifs: add check for returning value of SMB2_set_info_init

If the returning value of SMB2_set_info_init is an error-value,
exit the function.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 0967e5457954 ("cifs: use a compound for setting an xattr")

Signed-off-by: Anastasia Belova <[email protected]>
---
fs/cifs/smb2ops.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c
index 880cd494afea..c77e49b3fcc6 100644
--- a/fs/cifs/smb2ops.c
+++ b/fs/cifs/smb2ops.c
@@ -1116,6 +1116,8 @@ smb2_set_ea(const unsigned int xid, struct cifs_tcon *tcon,
COMPOUND_FID, current->tgid,
FILE_FULL_EA_INFORMATION,
SMB2_O_INFO_FILE, 0, data, size);
+ if (rc)
+ goto sea_exit;
smb2_set_next_command(tcon, &rqst[1]);
smb2_set_related(&rqst[1]);

--
2.30.2

2022-11-16 20:05:24

by Steve French

Subject: Re: [PATCH] cifs: add check for returning value of SMB2_set_info_init

merged into cifs-2.6.git for-next

On Wed, Nov 16, 2022 at 8:26 AM Anastasia Belova <[email protected]> wrote:
>
> If the returning value of SMB2_set_info_init is an error-value,
> exit the function.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 0967e5457954 ("cifs: use a compound for setting an xattr")
>
> Signed-off-by: Anastasia Belova <[email protected]>
> ---
> fs/cifs/smb2ops.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c
> index 880cd494afea..c77e49b3fcc6 100644
> --- a/fs/cifs/smb2ops.c
> +++ b/fs/cifs/smb2ops.c
> @@ -1116,6 +1116,8 @@ smb2_set_ea(const unsigned int xid, struct cifs_tcon *tcon,
> COMPOUND_FID, current->tgid,
> FILE_FULL_EA_INFORMATION,
> SMB2_O_INFO_FILE, 0, data, size);
> + if (rc)
> + goto sea_exit;
> smb2_set_next_command(tcon, &rqst[1]);
> smb2_set_related(&rqst[1]);
>
> --
> 2.30.2
>


--
Thanks,

Steve

2022-11-18 15:55:08

by Paulo Alcantara

Subject: Re: [PATCH] cifs: add check for returning value of SMB2_set_info_init

Anastasia Belova <[email protected]> writes:

> If the returning value of SMB2_set_info_init is an error-value,
> exit the function.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 0967e5457954 ("cifs: use a compound for setting an xattr")
>
> Signed-off-by: Anastasia Belova <[email protected]>
> ---
> fs/cifs/smb2ops.c | 2 ++
> 1 file changed, 2 insertions(+)

Reviewed-by: Paulo Alcantara (SUSE) <[email protected]>