2023-09-23 05:43:18

by roynatech

[permalink] [raw]
Subject: [PATCH] mac80211: fix station hash table max_size config dependency

From: roynatech2544 <[email protected]>

Commit ebd82b3 ("mac80211: make station hash table max_size configurable") introduced config
MAC80211_STA_HASH_MAX_SIZE, which is defined unconditionally even if MAC80211 is not set.
It doesn't look like it is dependent of MAC80211_DEBUG_MENU either, as its only user is sta_info.c
which is compiled unconditionally when MAC80211 != n. And without this config set somewhere, compile
would error out.

Make it depend on MAC80211 to correctly hide the config when MAC80211=n

Fixes: ebd82b3 ("mac80211: make station hash table max_size configurable")
Signed-off-by: roynatech2544 <[email protected]>

diff --git a/net/mac80211/Kconfig b/net/mac80211/Kconfig
index 51ec8256b..b9dc520b6 100644
--- a/net/mac80211/Kconfig
+++ b/net/mac80211/Kconfig
@@ -296,7 +296,8 @@ config MAC80211_DEBUG_COUNTERS
If unsure, say N.

config MAC80211_STA_HASH_MAX_SIZE
- int "Station hash table maximum size" if MAC80211_DEBUG_MENU
+ int "Station hash table maximum size"
+ depends on MAC80211
default 0
help
Setting this option to a low value (e.g. 4) allows testing the
--
2.34.1


2023-09-26 10:52:36

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] mac80211: fix station hash table max_size config dependency

[email protected] writes:

> From: roynatech2544 <[email protected]>
>
> Commit ebd82b3 ("mac80211: make station hash table max_size configurable") introduced config
> MAC80211_STA_HASH_MAX_SIZE, which is defined unconditionally even if MAC80211 is not set.
> It doesn't look like it is dependent of MAC80211_DEBUG_MENU either, as its only user is sta_info.c
> which is compiled unconditionally when MAC80211 != n. And without this config set somewhere, compile
> would error out.
>
> Make it depend on MAC80211 to correctly hide the config when MAC80211=n
>
> Fixes: ebd82b3 ("mac80211: make station hash table max_size configurable")

The commit id in fixes tag is too short, more info in the wiki link
below.

> Signed-off-by: roynatech2544 <[email protected]>

Please use your full legal name, no pseudonyms please. See wiki.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches