2021-08-24 07:23:12

by CGEL

Subject: [PATCH linux-next] x86:uv: fix boolreturn.cocci warnings

From: Jing Yangyang <[email protected]>

./arch/x86/include/asm/uv/uv.h:36:53-54:WARNING:return of 0/1 in
function 'is_early_uv_system' with return type bool

Return statements in functions returning bool should use true/false
instead of 1/0.

Generated by: scripts/coccinelle/misc/boolreturn.cocci

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Jing Yangyang <[email protected]>
---
arch/x86/include/asm/uv/uv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/include/asm/uv/uv.h b/arch/x86/include/asm/uv/uv.h
index 648eb23..9395925 100644
--- a/arch/x86/include/asm/uv/uv.h
+++ b/arch/x86/include/asm/uv/uv.h
@@ -33,7 +33,7 @@ static inline bool is_early_uv_system(void)
#else /* !X86_UV */

static inline enum uv_system_type get_uv_system_type(void) { return UV_NONE; }
-static inline bool is_early_uv_system(void) { return 0; }
+static inline bool is_early_uv_system(void) { return false; }
static inline int is_uv_system(void) { return 0; }
static inline int is_uv_hubbed(int uv) { return 0; }
static inline void uv_cpu_init(void) { }
--
1.8.3.1

2021-08-24 15:49:01

by Steve Wahl

Subject: Re: [PATCH linux-next] x86:uv: fix boolreturn.cocci warnings

Reviewed-by: Steve Wahl <[email protected]>

On Tue, Aug 24, 2021 at 12:21:24AM -0700, CGEL wrote:
> From: Jing Yangyang <[email protected]>
>
> ./arch/x86/include/asm/uv/uv.h:36:53-54:WARNING:return of 0/1 in
> function 'is_early_uv_system' with return type bool
>
> Return statements in functions returning bool should use true/false
> instead of 1/0.
>
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Jing Yangyang <[email protected]>
> ---
> arch/x86/include/asm/uv/uv.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/include/asm/uv/uv.h b/arch/x86/include/asm/uv/uv.h
> index 648eb23..9395925 100644
> --- a/arch/x86/include/asm/uv/uv.h
> +++ b/arch/x86/include/asm/uv/uv.h
> @@ -33,7 +33,7 @@ static inline bool is_early_uv_system(void)
> #else /* !X86_UV */
>
> static inline enum uv_system_type get_uv_system_type(void) { return UV_NONE; }
> -static inline bool is_early_uv_system(void) { return 0; }
> +static inline bool is_early_uv_system(void) { return false; }
> static inline int is_uv_system(void) { return 0; }
> static inline int is_uv_hubbed(int uv) { return 0; }
> static inline void uv_cpu_init(void) { }
> --
> 1.8.3.1
>
>

--
Steve Wahl, Hewlett Packard Enterprise

2021-08-26 22:45:04

by Thomas Gleixner

Subject: Re: [PATCH linux-next] x86:uv: fix boolreturn.cocci warnings

On Tue, Aug 24 2021 at 00:21, CGEL wrote:

This mail originates from: CGEL <[email protected]>

which is not related to:

> From: Jing Yangyang <[email protected]>

Please ensure that the chain of origin is intact. See Documentation/process/*

Thanks

tglx