2020-11-13 12:07:07

by kernel test robot

[permalink] [raw]
Subject: ERROR: modpost: "mac_pton" undefined!

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 585e5b17b92dead8a3aca4e3c9876fbca5f7e0ba
commit: 0c86d774883fa17e7c81b0c8838b88d06c2c911e vdpasim: allow to assign a MAC address
date: 2 weeks ago
config: openrisc-randconfig-r035-20201113 (attached as .config)
compiler: or1k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0c86d774883fa17e7c81b0c8838b88d06c2c911e
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 0c86d774883fa17e7c81b0c8838b88d06c2c911e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=openrisc

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>

All errors (new ones prefixed by >>, old ones prefixed by <<):

>> ERROR: modpost: "mac_pton" [drivers/vdpa/vdpa_sim/vdpa_sim.ko] undefined!

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]


Attachments:
(No filename) (1.34 kB)
.config.gz (27.58 kB)
Download all attachments

2020-11-13 12:41:36

by Laurent Vivier

[permalink] [raw]
Subject: Re: ERROR: modpost: "mac_pton" undefined!

On 13/11/2020 12:58, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 585e5b17b92dead8a3aca4e3c9876fbca5f7e0ba
> commit: 0c86d774883fa17e7c81b0c8838b88d06c2c911e vdpasim: allow to assign a MAC address
> date: 2 weeks ago
> config: openrisc-randconfig-r035-20201113 (attached as .config)
> compiler: or1k-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0c86d774883fa17e7c81b0c8838b88d06c2c911e
> git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> git fetch --no-tags linus master
> git checkout 0c86d774883fa17e7c81b0c8838b88d06c2c911e
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=openrisc
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <[email protected]>
>
> All errors (new ones prefixed by >>, old ones prefixed by <<):
>
>>> ERROR: modpost: "mac_pton" [drivers/vdpa/vdpa_sim/vdpa_sim.ko] undefined!
>

I think something like this might fix the problem.


diff --git a/drivers/vdpa/Kconfig b/drivers/vdpa/Kconfig
index d7d32b656102..d2de1cefd5cb 100644
--- a/drivers/vdpa/Kconfig
+++ b/drivers/vdpa/Kconfig
@@ -13,6 +13,7 @@ config VDPA_SIM
depends on RUNTIME_TESTING_MENU && HAS_DMA
select DMA_OPS
select VHOST_RING
+ select NET
default n
help
vDPA networking device simulator which loop TX traffic back

I'm going to test with .config and post a patch.

thanks,
Laurent

2020-11-13 13:16:55

by Andy Shevchenko

[permalink] [raw]
Subject: Re: ERROR: modpost: "mac_pton" undefined!

On Fri, Nov 13, 2020 at 2:42 PM Laurent Vivier <[email protected]> wrote:

...

> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <[email protected]>
> >
> > All errors (new ones prefixed by >>, old ones prefixed by <<):
> >
> >>> ERROR: modpost: "mac_pton" [drivers/vdpa/vdpa_sim/vdpa_sim.ko] undefined!
>
> I think something like this might fix the problem.

...

> + select NET
> default n

You may also drop 'default n' :-)

But what I want to say is that API is under NET_UTILS, I dunno if the
driver requires full NET to be selected. And IIRC NET_UTILS is
selected by NET.

> help
> vDPA networking device simulator which loop TX traffic back
>
> I'm going to test with .config and post a patch.


--
With Best Regards,
Andy Shevchenko

2020-11-13 13:21:56

by Laurent Vivier

[permalink] [raw]
Subject: Re: ERROR: modpost: "mac_pton" undefined!

On 13/11/2020 14:12, Andy Shevchenko wrote:
> On Fri, Nov 13, 2020 at 2:42 PM Laurent Vivier <[email protected]> wrote:
>
> ...
>
>>> If you fix the issue, kindly add following tag as appropriate
>>> Reported-by: kernel test robot <[email protected]>
>>>
>>> All errors (new ones prefixed by >>, old ones prefixed by <<):
>>>
>>>>> ERROR: modpost: "mac_pton" [drivers/vdpa/vdpa_sim/vdpa_sim.ko] undefined!
>>
>> I think something like this might fix the problem.
>
> ...
>
>> + select NET
>> default n
>
> You may also drop 'default n' :-)
>
> But what I want to say is that API is under NET_UTILS, I dunno if the
> driver requires full NET to be selected. And IIRC NET_UTILS is
> selected by NET.

I think GENERIC_NET_UTILS might be enough.

The problem I have for the moment is to find or1k-linux-gcc for my Fedora 33...

Thanks,
Laurent

2020-11-13 14:35:40

by Andy Shevchenko

[permalink] [raw]
Subject: Re: ERROR: modpost: "mac_pton" undefined!

On Fri, Nov 13, 2020 at 3:19 PM Laurent Vivier <[email protected]> wrote:
> On 13/11/2020 14:12, Andy Shevchenko wrote:
> > On Fri, Nov 13, 2020 at 2:42 PM Laurent Vivier <[email protected]> wrote:

...

> > But what I want to say is that API is under NET_UTILS, I dunno if the
> > driver requires full NET to be selected. And IIRC NET_UTILS is
> > selected by NET.
>
> I think GENERIC_NET_UTILS might be enough.

Good!

> The problem I have for the moment is to find or1k-linux-gcc for my Fedora 33...

Usually for a compilation test for the kernel is enough to have
precompiled compilers from kernel.org [1].

[1]: https://mirrors.edge.kernel.org/pub/tools/crosstool/

--
With Best Regards,
Andy Shevchenko

2020-11-13 15:20:29

by Michael S. Tsirkin

[permalink] [raw]
Subject: Re: ERROR: modpost: "mac_pton" undefined!

On Fri, Nov 13, 2020 at 01:38:40PM +0100, Laurent Vivier wrote:
> On 13/11/2020 12:58, kernel test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head: 585e5b17b92dead8a3aca4e3c9876fbca5f7e0ba
> > commit: 0c86d774883fa17e7c81b0c8838b88d06c2c911e vdpasim: allow to assign a MAC address
> > date: 2 weeks ago
> > config: openrisc-randconfig-r035-20201113 (attached as .config)
> > compiler: or1k-linux-gcc (GCC) 9.3.0
> > reproduce (this is a W=1 build):
> > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0c86d774883fa17e7c81b0c8838b88d06c2c911e
> > git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> > git fetch --no-tags linus master
> > git checkout 0c86d774883fa17e7c81b0c8838b88d06c2c911e
> > # save the attached .config to linux build tree
> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=openrisc
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <[email protected]>
> >
> > All errors (new ones prefixed by >>, old ones prefixed by <<):
> >
> >>> ERROR: modpost: "mac_pton" [drivers/vdpa/vdpa_sim/vdpa_sim.ko] undefined!
> >
>
> I think something like this might fix the problem.
>
>
> diff --git a/drivers/vdpa/Kconfig b/drivers/vdpa/Kconfig
> index d7d32b656102..d2de1cefd5cb 100644
> --- a/drivers/vdpa/Kconfig
> +++ b/drivers/vdpa/Kconfig
> @@ -13,6 +13,7 @@ config VDPA_SIM
> depends on RUNTIME_TESTING_MENU && HAS_DMA
> select DMA_OPS
> select VHOST_RING
> + select NET
> default n
> help
> vDPA networking device simulator which loop TX traffic back


NET isn't usually selected, maybe depends on NET

> I'm going to test with .config and post a patch.
>
> thanks,
> Laurent

2020-11-13 15:22:01

by Michael S. Tsirkin

[permalink] [raw]
Subject: Re: ERROR: modpost: "mac_pton" undefined!

On Fri, Nov 13, 2020 at 02:19:31PM +0100, Laurent Vivier wrote:
> On 13/11/2020 14:12, Andy Shevchenko wrote:
> > On Fri, Nov 13, 2020 at 2:42 PM Laurent Vivier <[email protected]> wrote:
> >
> > ...
> >
> >>> If you fix the issue, kindly add following tag as appropriate
> >>> Reported-by: kernel test robot <[email protected]>
> >>>
> >>> All errors (new ones prefixed by >>, old ones prefixed by <<):
> >>>
> >>>>> ERROR: modpost: "mac_pton" [drivers/vdpa/vdpa_sim/vdpa_sim.ko] undefined!
> >>
> >> I think something like this might fix the problem.
> >
> > ...
> >
> >> + select NET
> >> default n
> >
> > You may also drop 'default n' :-)
> >
> > But what I want to say is that API is under NET_UTILS, I dunno if the
> > driver requires full NET to be selected. And IIRC NET_UTILS is
> > selected by NET.
>
> I think GENERIC_NET_UTILS might be enough.

Yes that is ok to select.
But really vdpa sim is a fake ethernet device, nothing
much is lost if it depends on NET too.

> The problem I have for the moment is to find or1k-linux-gcc for my Fedora 33...
>
> Thanks,
> Laurent