2016-11-16 20:09:59

by Nikolaus Rath

[permalink] [raw]
Subject: commit 0b5da8d: fuse: add support for SEEK_HOLE and SEEK_DATA in lseek

Hi Ravishankar,

In commit 0b5da8d you added support for a new FUSE_LSEEK
operation. However, as far as I can tell the corresponding userspace
code never landed in libfuse.

Do you have a corresponding patch for libfuse?


Looking at the commit message, I assume this functionality was added
specifically for glusterfs which presumably does not use libfuse. But
even in that case it would be nice if you could Cc
[email protected] so that someone else can add support
for this. This is important because AFAIR the libfuse documentation is
the only thing that comes close to an official documentation of the FUSE
API.


Best,
-Nikolaus

--
GPG encrypted emails preferred. Key id: 0xD113FCAC3C4E599F
Fingerprint: ED31 791B 2C5C 1613 AF38 8B8A D113 FCAC 3C4E 599F

»Time flies like an arrow, fruit flies like a Banana.«


2016-11-17 01:34:34

by Ravishankar N

[permalink] [raw]
Subject: Re: commit 0b5da8d: fuse: add support for SEEK_HOLE and SEEK_DATA in lseek

Hi Nikolaus,

On 11/17/2016 01:39 AM, Nikolaus Rath wrote:
> Hi Ravishankar,
>
> In commit 0b5da8d you added support for a new FUSE_LSEEK
> operation. However, as far as I can tell the corresponding userspace
> code never landed in libfuse.
>
> Do you have a corresponding patch for libfuse?
No, unfortunately. I only used gluster to test what I wrote.
>
> Looking at the commit message, I assume this functionality was added
> specifically for glusterfs which presumably does not use libfuse.

You're right, gluster has its own code [1].
> But
> even in that case it would be nice if you could Cc
> [email protected]
The discussion[2] actually did start on fuse-devel.
> so that someone else can add support
That would be great.
> for this. This is important because AFAIR the libfuse documentation is
> the only thing that comes close to an official documentation of the FUSE
> API.
>

Best regards,
Ravi


[1]
https://github.com/gluster/glusterfs/blob/master/xlators/mount/fuse/src/fuse-bridge.c
[2] https://sourceforge.net/p/fuse/mailman/message/34227449/
> Best,
> -Nikolaus
>