2024-02-01 09:46:17

by Ivan Orlov

Subject: [PATCH] ALSA: core: Fix dependencies for SND_CORE_TEST

Add the CONFIG_SND_PCM dependency for CONFIG_SND_CORE_TEST config entry
as the test uses symbols from 'pcm_misc.c'.

Signed-off-by: Ivan Orlov <[email protected]>
---
sound/core/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/sound/core/Kconfig b/sound/core/Kconfig
index 664c6ee2b5a1..9a44f259ccca 100644
--- a/sound/core/Kconfig
+++ b/sound/core/Kconfig
@@ -42,6 +42,7 @@ config SND_UMP_LEGACY_RAWMIDI
config SND_CORE_TEST
tristate "Sound core KUnit test"
depends on KUNIT
+ depends on SND_PCM
default KUNIT_ALL_TESTS
help
This options enables the sound core functions KUnit test.
--
2.34.1

2024-02-01 13:23:17

by Takashi Iwai

Subject: Re: [PATCH] ALSA: core: Fix dependencies for SND_CORE_TEST

On Thu, 01 Feb 2024 10:46:04 +0100,
Ivan Orlov wrote:
>
> Add the CONFIG_SND_PCM dependency for CONFIG_SND_CORE_TEST config entry
> as the test uses symbols from 'pcm_misc.c'.
>
> Signed-off-by: Ivan Orlov <[email protected]>

It should rather select instead of depends-on. User can't enable
CONFIG_SND_PCM explicitly, but it's selected by the top-level
drivers.

Also, please add Fixes tag. It's a clear regression fix.


thanks,

Takashi

2024-02-01 21:58:09

by Ivan Orlov

Subject: Re: [PATCH] ALSA: core: Fix dependencies for SND_CORE_TEST

On 2/1/24 13:05, Takashi Iwai wrote:
>
> It should rather select instead of depends-on. User can't enable
> CONFIG_SND_PCM explicitly, but it's selected by the top-level
> drivers.
>
> Also, please add Fixes tag. It's a clear regression fix.
>

Alright, I'll send the V2 with suggested changes.

Thank you for the review!
--
Kind regards,
Ivan Orlov