2021-02-03 13:34:58

by Kostya Porotchkin

Subject: [PATCH 03/11] dts: mvebu: Add pin control definitions for SDIO interafce

From: Konstantin Porotchkin <[email protected]>

Add SDIO mode pin control configration for CP0 on A8K DB.

Signed-off-by: Konstantin Porotchkin <[email protected]>
---
arch/arm64/boot/dts/marvell/armada-70x0.dtsi | 6 ++++++
arch/arm64/boot/dts/marvell/armada-80x0.dtsi | 6 ++++++
2 files changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/marvell/armada-70x0.dtsi b/arch/arm64/boot/dts/marvell/armada-70x0.dtsi
index 293403a1a333..179218774ba9 100644
--- a/arch/arm64/boot/dts/marvell/armada-70x0.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-70x0.dtsi
@@ -47,6 +47,12 @@
cp0_pinctrl: pinctrl {
compatible = "marvell,armada-7k-pinctrl";

+ sdhci_pins: sdhi-pins {
+ marvell,pins = "mpp56", "mpp57", "mpp58",
+ "mpp59", "mpp60", "mpp61", "mpp62";
+ marvell,function = "sdio";
+ };
+
nand_pins: nand-pins {
marvell,pins =
"mpp15", "mpp16", "mpp17", "mpp18",
diff --git a/arch/arm64/boot/dts/marvell/armada-80x0.dtsi b/arch/arm64/boot/dts/marvell/armada-80x0.dtsi
index ee67c70bf02e..64100ae204da 100644
--- a/arch/arm64/boot/dts/marvell/armada-80x0.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-80x0.dtsi
@@ -70,6 +70,12 @@
&cp0_syscon0 {
cp0_pinctrl: pinctrl {
compatible = "marvell,armada-8k-cpm-pinctrl";
+
+ sdhci_pins: sdhi-pins {
+ marvell,pins = "mpp56", "mpp57", "mpp58",
+ "mpp59", "mpp60", "mpp61", "mpp62";
+ marvell,function = "sdio";
+ };
};
};

--
2.17.1

2021-02-03 14:08:00

by Baruch Siach

Subject: Re: [PATCH 03/11] dts: mvebu: Add pin control definitions for SDIO interafce

Hi Konstantin,

On Wed, Feb 03 2021, [email protected] wrote:
> From: Konstantin Porotchkin <[email protected]>
>
> Add SDIO mode pin control configration for CP0 on A8K DB.

This patch does not touch the A8K DB device-tree file.

baruch

>
> Signed-off-by: Konstantin Porotchkin <[email protected]>
> ---
> arch/arm64/boot/dts/marvell/armada-70x0.dtsi | 6 ++++++
> arch/arm64/boot/dts/marvell/armada-80x0.dtsi | 6 ++++++
> 2 files changed, 12 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-70x0.dtsi b/arch/arm64/boot/dts/marvell/armada-70x0.dtsi
> index 293403a1a333..179218774ba9 100644
> --- a/arch/arm64/boot/dts/marvell/armada-70x0.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-70x0.dtsi
> @@ -47,6 +47,12 @@
> cp0_pinctrl: pinctrl {
> compatible = "marvell,armada-7k-pinctrl";
>
> + sdhci_pins: sdhi-pins {
> + marvell,pins = "mpp56", "mpp57", "mpp58",
> + "mpp59", "mpp60", "mpp61", "mpp62";
> + marvell,function = "sdio";
> + };
> +
> nand_pins: nand-pins {
> marvell,pins =
> "mpp15", "mpp16", "mpp17", "mpp18",
> diff --git a/arch/arm64/boot/dts/marvell/armada-80x0.dtsi b/arch/arm64/boot/dts/marvell/armada-80x0.dtsi
> index ee67c70bf02e..64100ae204da 100644
> --- a/arch/arm64/boot/dts/marvell/armada-80x0.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-80x0.dtsi
> @@ -70,6 +70,12 @@
> &cp0_syscon0 {
> cp0_pinctrl: pinctrl {
> compatible = "marvell,armada-8k-cpm-pinctrl";
> +
> + sdhci_pins: sdhi-pins {
> + marvell,pins = "mpp56", "mpp57", "mpp58",
> + "mpp59", "mpp60", "mpp61", "mpp62";
> + marvell,function = "sdio";
> + };
> };
> };


--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- [email protected] - tel: +972.52.368.4656, http://www.tkos.co.il -

2021-02-03 14:30:57

by Russell King (Oracle)

Subject: Re: [PATCH 03/11] dts: mvebu: Add pin control definitions for SDIO interafce

On Wed, Feb 03, 2021 at 03:31:30PM +0200, [email protected] wrote:
> From: Konstantin Porotchkin <[email protected]>
>
> Add SDIO mode pin control configration for CP0 on A8K DB.
>
> Signed-off-by: Konstantin Porotchkin <[email protected]>
> ---
> arch/arm64/boot/dts/marvell/armada-70x0.dtsi | 6 ++++++
> arch/arm64/boot/dts/marvell/armada-80x0.dtsi | 6 ++++++
> 2 files changed, 12 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-70x0.dtsi b/arch/arm64/boot/dts/marvell/armada-70x0.dtsi
> index 293403a1a333..179218774ba9 100644
> --- a/arch/arm64/boot/dts/marvell/armada-70x0.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-70x0.dtsi
> @@ -47,6 +47,12 @@
> cp0_pinctrl: pinctrl {
> compatible = "marvell,armada-7k-pinctrl";
>
> + sdhci_pins: sdhi-pins {

sdhi-pins ?

> + marvell,pins = "mpp56", "mpp57", "mpp58",
> + "mpp59", "mpp60", "mpp61", "mpp62";
> + marvell,function = "sdio";
> + };
> +
> nand_pins: nand-pins {
> marvell,pins =
> "mpp15", "mpp16", "mpp17", "mpp18",
> diff --git a/arch/arm64/boot/dts/marvell/armada-80x0.dtsi b/arch/arm64/boot/dts/marvell/armada-80x0.dtsi
> index ee67c70bf02e..64100ae204da 100644
> --- a/arch/arm64/boot/dts/marvell/armada-80x0.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-80x0.dtsi
> @@ -70,6 +70,12 @@
> &cp0_syscon0 {
> cp0_pinctrl: pinctrl {
> compatible = "marvell,armada-8k-cpm-pinctrl";
> +
> + sdhci_pins: sdhi-pins {

sdhi-pins ?

> + marvell,pins = "mpp56", "mpp57", "mpp58",
> + "mpp59", "mpp60", "mpp61", "mpp62";
> + marvell,function = "sdio";
> + };
> };
> };
>
> --
> 2.17.1
>
>

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

2021-02-03 14:44:53

by Kostya Porotchkin

Subject: RE: [EXT] Re: [PATCH 03/11] dts: mvebu: Add pin control definitions for SDIO interafce

> -----Original Message-----
> From: Baruch Siach <[email protected]>
> Sent: Wednesday, February 3, 2021 16:01
> To: Kostya Porotchkin <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; Nadav Haklai <[email protected]>;
> [email protected]; Stefan Chulski <[email protected]>;
> [email protected]; Ben Peled <[email protected]>;
> [email protected]; [email protected]
> Subject: [EXT] Re: [PATCH 03/11] dts: mvebu: Add pin control definitions for
> SDIO interafce
>
> External Email
>
> ----------------------------------------------------------------------
> Hi Konstantin,
>
> On Wed, Feb 03 2021, [email protected] wrote:
> > From: Konstantin Porotchkin <[email protected]>
> >
> > Add SDIO mode pin control configration for CP0 on A8K DB.
>
> This patch does not touch the A8K DB device-tree file.
>
[KP] Right, it changes the SoC DTSI. I missed it when ported the patch.
Will fix in the next version

Kosta

> baruch
>
> >
> > Signed-off-by: Konstantin Porotchkin <[email protected]>
> > ---
> > arch/arm64/boot/dts/marvell/armada-70x0.dtsi | 6 ++++++
> > arch/arm64/boot/dts/marvell/armada-80x0.dtsi | 6 ++++++
> > 2 files changed, 12 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/marvell/armada-70x0.dtsi
> > b/arch/arm64/boot/dts/marvell/armada-70x0.dtsi
> > index 293403a1a333..179218774ba9 100644
> > --- a/arch/arm64/boot/dts/marvell/armada-70x0.dtsi
> > +++ b/arch/arm64/boot/dts/marvell/armada-70x0.dtsi
> > @@ -47,6 +47,12 @@
> > cp0_pinctrl: pinctrl {
> > compatible = "marvell,armada-7k-pinctrl";
> >
> > + sdhci_pins: sdhi-pins {
> > + marvell,pins = "mpp56", "mpp57", "mpp58",
> > + "mpp59", "mpp60", "mpp61", "mpp62";
> > + marvell,function = "sdio";
> > + };
> > +
> > nand_pins: nand-pins {
> > marvell,pins =
> > "mpp15", "mpp16", "mpp17", "mpp18", diff --git
> > a/arch/arm64/boot/dts/marvell/armada-80x0.dtsi
> > b/arch/arm64/boot/dts/marvell/armada-80x0.dtsi
> > index ee67c70bf02e..64100ae204da 100644
> > --- a/arch/arm64/boot/dts/marvell/armada-80x0.dtsi
> > +++ b/arch/arm64/boot/dts/marvell/armada-80x0.dtsi
> > @@ -70,6 +70,12 @@
> > &cp0_syscon0 {
> > cp0_pinctrl: pinctrl {
> > compatible = "marvell,armada-8k-cpm-pinctrl";
> > +
> > + sdhci_pins: sdhi-pins {
> > + marvell,pins = "mpp56", "mpp57", "mpp58",
> > + "mpp59", "mpp60", "mpp61", "mpp62";
> > + marvell,function = "sdio";
> > + };
> > };
> > };
>
>
> --
> ~. .~ Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
> - [email protected] - tel: +972.52.368.4656,
> https://urldefense.proofpoint.com/v2/url?u=http-
> 3A__http://www.tkos.co.il&d=DwIBAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=-
> N9sN4p5NSr0JGQoQ_2UCOgAqajG99W1EbSOww0WU8o&m=8Kz0ddezxxG41
> 9tiQOva_I9GUi6QZw9Pa6tRxYugqQw&s=Ky8dBlut-daLt2-
> 0j3BIwiBEBAVzKi8e9oJetRIzuPA&e= -

2021-02-03 14:46:11

by Kostya Porotchkin

Subject: RE: [EXT] Re: [PATCH 03/11] dts: mvebu: Add pin control definitions for SDIO interafce

Hu, Russel,

> -----Original Message-----
> From: Russell King - ARM Linux admin <[email protected]>
> Sent: Wednesday, February 3, 2021 16:28
> To: Kostya Porotchkin <[email protected]>
> Cc: [email protected]; [email protected]; linux-arm-
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]; [email protected]; Nadav Haklai
> <[email protected]>; Stefan Chulski <[email protected]>; Ben Peled
> <[email protected]>
> Subject: [EXT] Re: [PATCH 03/11] dts: mvebu: Add pin control definitions for
> SDIO interafce
>
> External Email
>
> ----------------------------------------------------------------------
> On Wed, Feb 03, 2021 at 03:31:30PM +0200, [email protected] wrote:
> > From: Konstantin Porotchkin <[email protected]>
> >
> > Add SDIO mode pin control configration for CP0 on A8K DB.
> >
> > Signed-off-by: Konstantin Porotchkin <[email protected]>
> > ---
> > arch/arm64/boot/dts/marvell/armada-70x0.dtsi | 6 ++++++
> > arch/arm64/boot/dts/marvell/armada-80x0.dtsi | 6 ++++++
> > 2 files changed, 12 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/marvell/armada-70x0.dtsi
> > b/arch/arm64/boot/dts/marvell/armada-70x0.dtsi
> > index 293403a1a333..179218774ba9 100644
> > --- a/arch/arm64/boot/dts/marvell/armada-70x0.dtsi
> > +++ b/arch/arm64/boot/dts/marvell/armada-70x0.dtsi
> > @@ -47,6 +47,12 @@
> > cp0_pinctrl: pinctrl {
> > compatible = "marvell,armada-7k-pinctrl";
> >
> > + sdhci_pins: sdhi-pins {
>
> sdhi-pins ?
>
[KP] You mean to replace the underline with dash?
Will do it in the next version, no problem.

> > + marvell,pins = "mpp56", "mpp57", "mpp58",
> > + "mpp59", "mpp60", "mpp61", "mpp62";
> > + marvell,function = "sdio";
> > + };
> > +
> > nand_pins: nand-pins {
> > marvell,pins =
> > "mpp15", "mpp16", "mpp17", "mpp18", diff --git
> > a/arch/arm64/boot/dts/marvell/armada-80x0.dtsi
> > b/arch/arm64/boot/dts/marvell/armada-80x0.dtsi
> > index ee67c70bf02e..64100ae204da 100644
> > --- a/arch/arm64/boot/dts/marvell/armada-80x0.dtsi
> > +++ b/arch/arm64/boot/dts/marvell/armada-80x0.dtsi
> > @@ -70,6 +70,12 @@
> > &cp0_syscon0 {
> > cp0_pinctrl: pinctrl {
> > compatible = "marvell,armada-8k-cpm-pinctrl";
> > +
> > + sdhci_pins: sdhi-pins {
>
> sdhi-pins ?
>
> > + marvell,pins = "mpp56", "mpp57", "mpp58",
> > + "mpp59", "mpp60", "mpp61", "mpp62";
> > + marvell,function = "sdio";
> > + };
> > };
> > };
> >
> > --
> > 2.17.1
> >
> >
>
> --
> RMK's Patch system: https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__http://www.armlinux.org.uk_developer_patches_&d=DwIBAg&c=nKjWec2b6R0
> mOyPaz7xtfQ&r=-
> N9sN4p5NSr0JGQoQ_2UCOgAqajG99W1EbSOww0WU8o&m=wUA0mnqioCngi
> HLZcn2iOBuiWLQtawWb1yfozx_80C4&s=_yolpLSRiJi4CnA-
> iEzpbF5r77VBdLcM6pouXxTdupk&e=
> FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

2021-02-03 15:56:48

by Andrew Lunn

Subject: Re: [EXT] Re: [PATCH 03/11] dts: mvebu: Add pin control definitions for SDIO interafce

> > > + sdhci_pins: sdhi-pins {
> >
> > sdhi-pins ?
> >
> [KP] You mean to replace the underline with dash?

I think he would like a c added in the correct place.

Andrew