Hans de Goede <[email protected]> writes:
> Hi,
>
> On 18-12-2019 07:56, Punit Agrawal wrote:
>> Serdev sub-system claims all serial devices that are not already
>> enumerated. As a result, no device node is created for serial port on
>> certain boards such as the Apollo Lake based UP2. This has the
>> unintended consequence of not being able to raise the login prompt via
>> serial connection.
>>
>> Introduce a blacklist to reject devices that should not be treated as
>> a serdev device. Add the Intel HS UART peripheral ids to the blacklist
>> to bring back serial port on SoCs carrying them.
>>
>> Cc: [email protected]
>> Signed-off-by: Punit Agrawal <[email protected]>
>> Cc: Rob Herring <[email protected]>
>> Cc: Greg Kroah-Hartman <[email protected]>
>> Cc: Johan Hovold <[email protected]>
>> Cc: Hans de Goede <[email protected]>
>
> Thank you for addressing this long standing issue.
I am surprised there hasn't been more people complaining! Maybe even on
x86 mainline isn't that widely used on development boards.
> The basic approach here looks good to me, once the minor
> comments from other reviewers are addressed you can add my:
>
> Acked-by: Hans de Goede <[email protected]>
Thanks!
[...]
Hi,
On 19-12-2019 01:37, Punit Agrawal wrote:
> Hans de Goede <[email protected]> writes:
>
>> Hi,
>>
>> On 18-12-2019 07:56, Punit Agrawal wrote:
>>> Serdev sub-system claims all serial devices that are not already
>>> enumerated. As a result, no device node is created for serial port on
>>> certain boards such as the Apollo Lake based UP2. This has the
>>> unintended consequence of not being able to raise the login prompt via
>>> serial connection.
>>>
>>> Introduce a blacklist to reject devices that should not be treated as
>>> a serdev device. Add the Intel HS UART peripheral ids to the blacklist
>>> to bring back serial port on SoCs carrying them.
>>>
>>> Cc: [email protected]
>>> Signed-off-by: Punit Agrawal <[email protected]>
>>> Cc: Rob Herring <[email protected]>
>>> Cc: Greg Kroah-Hartman <[email protected]>
>>> Cc: Johan Hovold <[email protected]>
>>> Cc: Hans de Goede <[email protected]>
>>
>> Thank you for addressing this long standing issue.
>
> I am surprised there hasn't been more people complaining! Maybe even on
> x86 mainline isn't that widely used on development boards.
I think it is also a case of there not being that manu x86 development
boards.
Regards,
Hans