2020-01-28 21:11:01

by Lubomir Rintel

Subject: [PATCH] gpio: pxa: Avoid a warning when gpio0 and gpio1 IRQS are not there

Not all platforms use those. Let's use
platform_get_irq_byname_optional() instead platform_get_irq_byname() so
that we avoid a useless warning:

[ 1.359455] pxa-gpio d4019000.gpio: IRQ gpio0 not found
[ 1.359583] pxa-gpio d4019000.gpio: IRQ gpio1 not found

Signed-off-by: Lubomir Rintel <[email protected]>
---
drivers/gpio/gpio-pxa.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c
index 9888b62f37afb..567742d962aef 100644
--- a/drivers/gpio/gpio-pxa.c
+++ b/drivers/gpio/gpio-pxa.c
@@ -652,8 +652,8 @@ static int pxa_gpio_probe(struct platform_device *pdev)
if (!pchip->irqdomain)
return -ENOMEM;

- irq0 = platform_get_irq_byname(pdev, "gpio0");
- irq1 = platform_get_irq_byname(pdev, "gpio1");
+ irq0 = platform_get_irq_byname_optional(pdev, "gpio0");
+ irq1 = platform_get_irq_byname_optional(pdev, "gpio1");
irq_mux = platform_get_irq_byname(pdev, "gpio_mux");
if ((irq0 > 0 && irq1 <= 0) || (irq0 <= 0 && irq1 > 0)
|| (irq_mux <= 0))
--
2.24.1

2020-02-04 10:15:06

by Bartosz Golaszewski

Subject: Re: [PATCH] gpio: pxa: Avoid a warning when gpio0 and gpio1 IRQS are not there

wt., 28 sty 2020 o 22:08 Lubomir Rintel <[email protected]> napisał(a):
>
> Not all platforms use those. Let's use
> platform_get_irq_byname_optional() instead platform_get_irq_byname() so
> that we avoid a useless warning:
>
> [ 1.359455] pxa-gpio d4019000.gpio: IRQ gpio0 not found
> [ 1.359583] pxa-gpio d4019000.gpio: IRQ gpio1 not found
>
> Signed-off-by: Lubomir Rintel <[email protected]>
> ---
> drivers/gpio/gpio-pxa.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c
> index 9888b62f37afb..567742d962aef 100644
> --- a/drivers/gpio/gpio-pxa.c
> +++ b/drivers/gpio/gpio-pxa.c
> @@ -652,8 +652,8 @@ static int pxa_gpio_probe(struct platform_device *pdev)
> if (!pchip->irqdomain)
> return -ENOMEM;
>
> - irq0 = platform_get_irq_byname(pdev, "gpio0");
> - irq1 = platform_get_irq_byname(pdev, "gpio1");
> + irq0 = platform_get_irq_byname_optional(pdev, "gpio0");
> + irq1 = platform_get_irq_byname_optional(pdev, "gpio1");
> irq_mux = platform_get_irq_byname(pdev, "gpio_mux");
> if ((irq0 > 0 && irq1 <= 0) || (irq0 <= 0 && irq1 > 0)
> || (irq_mux <= 0))
> --
> 2.24.1
>

Patch applied. Thanks!

Bartosz

2020-02-05 17:58:33

by Robert Jarzmik

Subject: Re: [PATCH] gpio: pxa: Avoid a warning when gpio0 and gpio1 IRQS are not there

Bartosz Golaszewski <[email protected]> writes:

> wt., 28 sty 2020 o 22:08 Lubomir Rintel <[email protected]> napisał(a):
>>
>> Not all platforms use those. Let's use
>> platform_get_irq_byname_optional() instead platform_get_irq_byname() so
>> that we avoid a useless warning:
>>
>> [ 1.359455] pxa-gpio d4019000.gpio: IRQ gpio0 not found
>> [ 1.359583] pxa-gpio d4019000.gpio: IRQ gpio1 not found
>>
>> Signed-off-by: Lubomir Rintel <[email protected]>
Okay, what would have really be nice in the commit message was to state _which_
platform doesn't use these, and still use pxa-gpio as their gpio driver.

Cheers.

--
Robert

PS: And yes, my response is late, but I'm moving house so my ping is huge
lately.