2018-09-27 15:13:05

by Mihir Mehta

Subject: [PATCH] fat: Expand a slightly out-of-date comment

The file namei.c seems to have been renamed to namei_msdos.c, so I
decided to update the comment with the correct name, and expand it a bit
to tell the reader what to look for.
---
fs/fat/dir.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/fat/dir.c b/fs/fat/dir.c
index b833ffe..d954e18 100644
--- a/fs/fat/dir.c
+++ b/fs/fat/dir.c
@@ -368,7 +368,8 @@ static int fat_parse_short(struct super_block *sb,
}

memcpy(work, de->name, sizeof(work));
- /* see namei.c, msdos_format_name */
+ /* For an explanation of the special treatment of 0x05 in
+ filenames, see msdos_format_name in namei_msdos.c */
if (work[0] == 0x05)
work[0] = 0xE5;

--
2.7.4

2018-09-28 10:34:44

by OGAWA Hirofumi

Subject: Re: [PATCH] fat: Expand a slightly out-of-date comment

Mihir Mehta <[email protected]> writes:

> The file namei.c seems to have been renamed to namei_msdos.c, so I
> decided to update the comment with the correct name, and expand it a bit
> to tell the reader what to look for.
> ---
> fs/fat/dir.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/fat/dir.c b/fs/fat/dir.c
> index b833ffe..d954e18 100644
> --- a/fs/fat/dir.c
> +++ b/fs/fat/dir.c
> @@ -368,7 +368,8 @@ static int fat_parse_short(struct super_block *sb,
> }
>
> memcpy(work, de->name, sizeof(work));
> - /* see namei.c, msdos_format_name */
> + /* For an explanation of the special treatment of 0x05 in
> + filenames, see msdos_format_name in namei_msdos.c */
> if (work[0] == 0x05)
> work[0] = 0xE5;

Sorry. However, could you use

/*
*
*/

style comment? Otherwise, looks good.

Thanks.
--
OGAWA Hirofumi <[email protected]>

2018-09-28 19:52:18

by Mihir Mehta

Subject: [PATCH] fat: Expand a slightly out-of-date comment

The file namei.c seems to have been renamed to namei_msdos.c, so I
decided to update the comment with the correct name, and expand it a bit
to tell the reader what to look for.
---
fs/fat/dir.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/fs/fat/dir.c b/fs/fat/dir.c
index 7f5f369..f4db13f 100644
--- a/fs/fat/dir.c
+++ b/fs/fat/dir.c
@@ -369,7 +369,9 @@ static int fat_parse_short(struct super_block *sb,
}

memcpy(work, de->name, sizeof(work));
- /* see namei.c, msdos_format_name */
+ /* For an explanation of the special treatment of 0x05 in
+ * filenames, see msdos_format_name in namei_msdos.c
+ */
if (work[0] == 0x05)
work[0] = 0xE5;

--
2.7.4

2018-09-29 10:05:33

by OGAWA Hirofumi

Subject: Re: [PATCH] fat: Expand a slightly out-of-date comment

Mihir Mehta <[email protected]> writes:

> The file namei.c seems to have been renamed to namei_msdos.c, so I
> decided to update the comment with the correct name, and expand it a bit
> to tell the reader what to look for.
> ---
> fs/fat/dir.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/fat/dir.c b/fs/fat/dir.c
> index 7f5f369..f4db13f 100644
> --- a/fs/fat/dir.c
> +++ b/fs/fat/dir.c
> @@ -369,7 +369,9 @@ static int fat_parse_short(struct super_block *sb,
> }
>
> memcpy(work, de->name, sizeof(work));
> - /* see namei.c, msdos_format_name */
> + /* For an explanation of the special treatment of 0x05 in
> + * filenames, see msdos_format_name in namei_msdos.c
> + */
> if (work[0] == 0x05)
> work[0] = 0xE5;

Acked-by: OGAWA Hirofumi <[email protected]>

Thanks.
--
OGAWA Hirofumi <[email protected]>

2018-10-02 22:33:11

by Andrew Morton

Subject: Re: [PATCH] fat: Expand a slightly out-of-date comment

On Fri, 28 Sep 2018 14:49:47 -0500 Mihir Mehta <[email protected]> wrote:

> The file namei.c seems to have been renamed to namei_msdos.c, so I
> decided to update the comment with the correct name, and expand it a bit
> to tell the reader what to look for.

Please send us a Signed-off-by: for this patch, as per
Documentation/process/submitting-patches.rst, section 11.

Thanks.

2018-10-02 23:51:15

by Mihir Mehta

Subject: [PATCH] fat: Expand a slightly out-of-date comment

The file namei.c seems to have been renamed to namei_msdos.c, so I
decided to update the comment with the correct name, and expand it a bit
to tell the reader what to look for.

Signed-off-by: Mihir Mehta <[email protected]>
---
fs/fat/dir.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/fs/fat/dir.c b/fs/fat/dir.c
index 7f5f369..ce5f958 100644
--- a/fs/fat/dir.c
+++ b/fs/fat/dir.c
@@ -369,7 +369,9 @@ static int fat_parse_short(struct super_block *sb,
}

memcpy(work, de->name, sizeof(work));
- /* see namei.c, msdos_format_name */
+ /* For an explanation of the special treatment of 0x05 in
+ * filenames, see msdos_format_name in namei_msdos.c
+ */
if (work[0] == 0x05)
work[0] = 0xE5;

--
2.7.4