2017-08-16 12:36:59

by Corentin Labbe

[permalink] [raw]
Subject: [PATCH] powerpc: powernv: Fix build error on const discarding

When building a random powerpc kernel I hit this build error:
CC arch/powerpc/platforms/powernv/opal-imc.o
arch/powerpc/platforms/powernv/opal-imc.c: In function « disable_nest_pmu_counters »:
arch/powerpc/platforms/powernv/opal-imc.c:130:13: error : assignment discards « const » qualifier from pointer target type [-Werror=discarded-qualifiers]
l_cpumask = cpumask_of_node(nid);
^
This patch simply add const to l_cpumask to fix this issue.

Signed-off-by: Corentin Labbe <[email protected]>
---
arch/powerpc/platforms/powernv/opal-imc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/powernv/opal-imc.c b/arch/powerpc/platforms/powernv/opal-imc.c
index b903bf5e6006..21f6531fae20 100644
--- a/arch/powerpc/platforms/powernv/opal-imc.c
+++ b/arch/powerpc/platforms/powernv/opal-imc.c
@@ -123,7 +123,7 @@ static int imc_pmu_create(struct device_node *parent, int pmu_index, int domain)
static void disable_nest_pmu_counters(void)
{
int nid, cpu;
- struct cpumask *l_cpumask;
+ const struct cpumask *l_cpumask;

get_online_cpus();
for_each_online_node(nid) {
--
2.13.0


2017-08-17 12:52:19

by Michael Ellerman

[permalink] [raw]
Subject: Re: [PATCH] powerpc: powernv: Fix build error on const discarding

Corentin Labbe <[email protected]> writes:

> When building a random powerpc kernel I hit this build error:
> CC arch/powerpc/platforms/powernv/opal-imc.o
> arch/powerpc/platforms/powernv/opal-imc.c: In function « disable_nest_pmu_counters »:
> arch/powerpc/platforms/powernv/opal-imc.c:130:13: error : assignment discards « const » qualifier from pointer target type [-Werror=discarded-qualifiers]
> l_cpumask = cpumask_of_node(nid);
> ^
> This patch simply add const to l_cpumask to fix this issue.

Thanks. I'm not sure why we haven't seen that.

Do you mind attaching your .config ?

cheers

2017-08-18 12:58:28

by Corentin Labbe

[permalink] [raw]
Subject: Re: [PATCH] powerpc: powernv: Fix build error on const discarding

On Thu, Aug 17, 2017 at 10:52:11PM +1000, Michael Ellerman wrote:
> Corentin Labbe <[email protected]> writes:
>
> > When building a random powerpc kernel I hit this build error:
> > CC arch/powerpc/platforms/powernv/opal-imc.o
> > arch/powerpc/platforms/powernv/opal-imc.c: In function ??disable_nest_pmu_counters??:
> > arch/powerpc/platforms/powernv/opal-imc.c:130:13: error?: assignment discards ??const?? qualifier from pointer target type [-Werror=discarded-qualifiers]
> > l_cpumask = cpumask_of_node(nid);
> > ^
> > This patch simply add const to l_cpumask to fix this issue.
>
> Thanks. I'm not sure why we haven't seen that.
>
> Do you mind attaching your .config ?
>
> cheers

Yes

Regards

Attachments:
(No filename) (736.00 B)
 powerpc_config (92.67 kB)
 Download all attachments

2017-08-25 01:26:39

by Michael Ellerman

[permalink] [raw]
Subject: Re: [PATCH] powerpc: powernv: Fix build error on const discarding

Corentin Labbe <[email protected]> writes:

> On Thu, Aug 17, 2017 at 10:52:11PM +1000, Michael Ellerman wrote:
>> Corentin Labbe <[email protected]> writes:
>>
>> > When building a random powerpc kernel I hit this build error:
>> > CC arch/powerpc/platforms/powernv/opal-imc.o
>> > arch/powerpc/platforms/powernv/opal-imc.c: In function « disable_nest_pmu_counters »:
>> > arch/powerpc/platforms/powernv/opal-imc.c:130:13: error : assignment discards « const » qualifier from pointer target type [-Werror=discarded-qualifiers]
>> > l_cpumask = cpumask_of_node(nid);
>> > ^
>> > This patch simply add const to l_cpumask to fix this issue.
>>
>> Thanks. I'm not sure why we haven't seen that.
>>
>> Do you mind attaching your .config ?
>>
>> cheers
>
> Yes

Thanks.

So the key is:

> CONFIG_PPC_POWERNV=y
...
> # CONFIG_NUMA is not set


Which none of our configs have.

I'll add a test build of that.

Thanks.

cheers

2017-08-31 11:36:17

by Michael Ellerman

[permalink] [raw]
Subject: Re: powerpc: powernv: Fix build error on const discarding

On Wed, 2017-08-16 at 12:34:44 UTC, Corentin Labbe wrote:
> When building a random powerpc kernel I hit this build error:
> CC arch/powerpc/platforms/powernv/opal-imc.o
> arch/powerpc/platforms/powernv/opal-imc.c: In function « disable_nest_pmu_counters »:
> arch/powerpc/platforms/powernv/opal-imc.c:130:13: error : assignment discards « const » qualifier from pointer target type [-Werror=discarded-qualifiers]
> l_cpumask = cpumask_of_node(nid);
> ^
> This patch simply add const to l_cpumask to fix this issue.
>
> Signed-off-by: Corentin Labbe <[email protected]>
> Reviewed-by: Madhavan Srinivasan <[email protected]>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/6538ac30841638b2fd345725a9fd15

cheers