commit d1669912 (idle: Implement generic idle function) added a new
generic idle along with support for hlt/nohlt command line options to
override default idle loop behavior. However, the command-line
processing is never compiled.
The command-line handling is wrapped by CONFIG_GENERIC_IDLE_POLL_SETUP
and arches that use this feature select it in their Kconfigs.
However, no Kconfig definition was created for this option, so it is
never enabled, and therefore command-line override of the idle-loop
behavior is broken after migrating to the generic idle loop.
To fix, add a Kconfig definition for GENERIC_IDLE_POLL_SETUP.
Tested on ARM (OMAP4/Panda) which enables the command-line overrides
by default.
Cc: Thomas Gleixner <[email protected]>
Cc: Linus Torvalds <[email protected]>
Cc: Rusty Russell <[email protected]>
Cc: Paul McKenney <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Srivatsa S. Bhat <[email protected]>
Cc: Magnus Damm <[email protected]>
Signed-off-by: Kevin Hilman <[email protected]>
---
Applies on tip/smp/hotplug where generic idle feature is added
arch/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/Kconfig b/arch/Kconfig
index 1455579..e0ef57b 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -216,6 +216,9 @@ config USE_GENERIC_SMP_HELPERS
config GENERIC_SMP_IDLE_THREAD
bool
+config GENERIC_IDLE_POLL_SETUP
+ bool
+
# Select if arch init_task initializer is different to init/init_task.c
config ARCH_INIT_TASK
bool
--
1.8.2
On 04/25/2013 05:49 AM, Kevin Hilman wrote:
> commit d1669912 (idle: Implement generic idle function) added a new
> generic idle along with support for hlt/nohlt command line options to
> override default idle loop behavior. However, the command-line
> processing is never compiled.
>
> The command-line handling is wrapped by CONFIG_GENERIC_IDLE_POLL_SETUP
> and arches that use this feature select it in their Kconfigs.
> However, no Kconfig definition was created for this option, so it is
> never enabled, and therefore command-line override of the idle-loop
> behavior is broken after migrating to the generic idle loop.
>
> To fix, add a Kconfig definition for GENERIC_IDLE_POLL_SETUP.
>
> Tested on ARM (OMAP4/Panda) which enables the command-line overrides
> by default.
>
> Cc: Thomas Gleixner <[email protected]>
> Cc: Linus Torvalds <[email protected]>
> Cc: Rusty Russell <[email protected]>
> Cc: Paul McKenney <[email protected]>
> Cc: Peter Zijlstra <[email protected]>
> Cc: Srivatsa S. Bhat <[email protected]>
> Cc: Magnus Damm <[email protected]>
> Signed-off-by: Kevin Hilman <[email protected]>
> ---
Reviewed-by: Srivatsa S. Bhat <[email protected]>
Regards,
Srivatsa S. Bhat
> Applies on tip/smp/hotplug where generic idle feature is added
>
> arch/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/Kconfig b/arch/Kconfig
> index 1455579..e0ef57b 100644
> --- a/arch/Kconfig
> +++ b/arch/Kconfig
> @@ -216,6 +216,9 @@ config USE_GENERIC_SMP_HELPERS
> config GENERIC_SMP_IDLE_THREAD
> bool
>
> +config GENERIC_IDLE_POLL_SETUP
> + bool
> +
> # Select if arch init_task initializer is different to init/init_task.c
> config ARCH_INIT_TASK
> bool
>
"Srivatsa S. Bhat" <[email protected]> writes:
> On 04/25/2013 05:49 AM, Kevin Hilman wrote:
>> commit d1669912 (idle: Implement generic idle function) added a new
>> generic idle along with support for hlt/nohlt command line options to
>> override default idle loop behavior. However, the command-line
>> processing is never compiled.
>>
>> The command-line handling is wrapped by CONFIG_GENERIC_IDLE_POLL_SETUP
>> and arches that use this feature select it in their Kconfigs.
>> However, no Kconfig definition was created for this option, so it is
>> never enabled, and therefore command-line override of the idle-loop
>> behavior is broken after migrating to the generic idle loop.
>>
>> To fix, add a Kconfig definition for GENERIC_IDLE_POLL_SETUP.
>>
>> Tested on ARM (OMAP4/Panda) which enables the command-line overrides
>> by default.
>>
>> Cc: Thomas Gleixner <[email protected]>
>> Cc: Linus Torvalds <[email protected]>
>> Cc: Rusty Russell <[email protected]>
>> Cc: Paul McKenney <[email protected]>
>> Cc: Peter Zijlstra <[email protected]>
>> Cc: Srivatsa S. Bhat <[email protected]>
>> Cc: Magnus Damm <[email protected]>
>> Signed-off-by: Kevin Hilman <[email protected]>
>> ---
>
> Reviewed-by: Srivatsa S. Bhat <[email protected]>
Thanks for the review.
>> Applies on tip/smp/hotplug where generic idle feature is added
Thomas, can this get into tip/smp/hotplug so the command-line override
is not broken in v3.10?
Thanks,
Kevin
>>
>> arch/Kconfig | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/Kconfig b/arch/Kconfig
>> index 1455579..e0ef57b 100644
>> --- a/arch/Kconfig
>> +++ b/arch/Kconfig
>> @@ -216,6 +216,9 @@ config USE_GENERIC_SMP_HELPERS
>> config GENERIC_SMP_IDLE_THREAD
>> bool
>>
>> +config GENERIC_IDLE_POLL_SETUP
>> + bool
>> +
>> # Select if arch init_task initializer is different to init/init_task.c
>> config ARCH_INIT_TASK
>> bool
>>
Commit-ID: 485cf5dac2966b93ef2b6211cf2fd42d66c823e6
Gitweb: http://git.kernel.org/tip/485cf5dac2966b93ef2b6211cf2fd42d66c823e6
Author: Kevin Hilman <[email protected]>
AuthorDate: Wed, 24 Apr 2013 17:19:13 -0700
Committer: Thomas Gleixner <[email protected]>
CommitDate: Sun, 5 May 2013 08:29:40 +0200
idle: Fix hlt/nohlt command-line handling in new generic idle
commit d1669912 (idle: Implement generic idle function) added a new
generic idle along with support for hlt/nohlt command line options to
override default idle loop behavior. However, the command-line
processing is never compiled.
The command-line handling is wrapped by CONFIG_GENERIC_IDLE_POLL_SETUP
and arches that use this feature select it in their Kconfigs.
However, no Kconfig definition was created for this option, so it is
never enabled, and therefore command-line override of the idle-loop
behavior is broken after migrating to the generic idle loop.
To fix, add a Kconfig definition for GENERIC_IDLE_POLL_SETUP.
Tested on ARM (OMAP4/Panda) which enables the command-line overrides
by default.
Signed-off-by: Kevin Hilman <[email protected]>
Reviewed-by: Srivatsa S. Bhat <[email protected]>
Cc: Linus Torvalds <[email protected]>
Cc: Rusty Russell <[email protected]>
Cc: Paul McKenney <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Magnus Damm <[email protected]>
Cc: [email protected]
Cc: [email protected]
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Thomas Gleixner <[email protected]>
---
arch/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/Kconfig b/arch/Kconfig
index 99f0e17..3e64403 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -213,6 +213,9 @@ config USE_GENERIC_SMP_HELPERS
config GENERIC_SMP_IDLE_THREAD
bool
+config GENERIC_IDLE_POLL_SETUP
+ bool
+
# Select if arch init_task initializer is different to init/init_task.c
config ARCH_INIT_TASK
bool